Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357252 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-03-14 15:10 +0100 |
| Last post | 2016-03-14 18:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] net: mediatek: remove incorrect dma_mask assignment Arnd Bergmann <arnd@arndb.de> - 2016-03-14 15:10 +0100
Re: [PATCH 2/3] net: mediatek: remove incorrect dma_mask assignment David Miller <davem@davemloft.net> - 2016-03-14 18:10 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-03-14 15:10 +0100 |
| Subject | [PATCH 2/3] net: mediatek: remove incorrect dma_mask assignment |
| Message-ID | <rcBm1-4LW-1@gated-at.bofh.it> |
Device drivers should not mess with the DMA mask directly, but instead call dma_set_mask() etc if needed. In case of the mtk_eth_soc driver, the mask already gets set correctly when the device is created, and setting it again is against the documented API. This removes the incorrect setting. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 3e42204adfe5..87f417712da0 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1676,9 +1676,6 @@ static int mtk_probe(struct platform_device *pdev) struct mtk_eth *eth; int err; - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); - pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; - device_reset(&pdev->dev); match = of_match_device(of_mtk_match, &pdev->dev); -- 2.7.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-03-14 18:10 +0100 |
| Message-ID | <rcEae-6JJ-9@gated-at.bofh.it> |
| In reply to | #1357252 |
From: Arnd Bergmann <arnd@arndb.de> Date: Mon, 14 Mar 2016 15:07:11 +0100 > Device drivers should not mess with the DMA mask directly, > but instead call dma_set_mask() etc if needed. > > In case of the mtk_eth_soc driver, the mask already gets set > correctly when the device is created, and setting it again > is against the documented API. > > This removes the incorrect setting. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web