Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1356108 > unrolled thread

Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver

Started byDmitry Torokhov <dmitry.torokhov@gmail.com>
First post2016-03-11 19:10 +0100
Last post2016-03-16 13:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-03-11 19:10 +0100
    Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver Andrew Duggan <andrew.duggan@gmail.com> - 2016-03-11 19:40 +0100
    Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver Linus Walleij <linus.walleij@linaro.org> - 2016-03-16 13:00 +0100

#1356108 — Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2016-03-11 19:10 +0100
SubjectRe: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver
Message-ID<rbzFD-1Ep-9@gated-at.bofh.it>
On Thu, Mar 03, 2016 at 06:11:38PM +0100, Benjamin Tissoires wrote:
> On Feb 12 2016 or thereabouts, Andrew Duggan wrote:
> > On 02/12/2016 04:54 AM, Linus Walleij wrote:
> > >On Wed, Feb 10, 2016 at 11:23 PM, Andrew Duggan <aduggan@synaptics.com> wrote:
> > >
> > >>This is the v5 patch series which fixes the issues identified by kbuild
> > >>and coccinelle in the previous patch series. These include:
> > >>
> > >>- Using ARRAY_SIZE instead of a custom macro to calculate the size of the
> > >>   function handler array.
> > >>- Remove setting the .owner field for the driver in rmi_i2c and rmi_spi
> > >>   since the i2c-core and spi set that field.
> > >>- Fix if statment in rmi_f30 which was testing has_led twice instead of
> > >>   testing has_gpio.
> > >Works like a charm.
> > >Tested-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > Thanks for testing. At this point except for the touchscreen binding rename
> > fix needed in patch 5, all of the outstanding issues have been addressed. If
> > the rest of the patch series is acceptable, then I can do a final v6 respin
> > which fixes the binding and also removes the HID patch. But, if more work
> > needs to be done on the patch series I can wait to do the respin. Dmitry,
> > what do you think of the patch series at this point?
> 
> Dmitry, ping on this one...
> 
> I'd like to see the series in 4.6, and we are getting closer of the
> merge window. Could we get some of your time on this?

I adjusted the binding on patch 5 (to read -x-mm and y-mm) and applied
the first 9 leaving the HID out for now.

Thanks.

-- 
Dmitry

[toc] | [next] | [standalone]


#1356125

FromAndrew Duggan <andrew.duggan@gmail.com>
Date2016-03-11 19:40 +0100
Message-ID<rbA8G-1R9-13@gated-at.bofh.it>
In reply to#1356108
On Fri, Mar 11, 2016 at 10:05 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Mar 03, 2016 at 06:11:38PM +0100, Benjamin Tissoires wrote:
>> On Feb 12 2016 or thereabouts, Andrew Duggan wrote:
>> > On 02/12/2016 04:54 AM, Linus Walleij wrote:
>> > >On Wed, Feb 10, 2016 at 11:23 PM, Andrew Duggan <aduggan@synaptics.com> wrote:
>> > >
>> > >>This is the v5 patch series which fixes the issues identified by kbuild
>> > >>and coccinelle in the previous patch series. These include:
>> > >>
>> > >>- Using ARRAY_SIZE instead of a custom macro to calculate the size of the
>> > >>   function handler array.
>> > >>- Remove setting the .owner field for the driver in rmi_i2c and rmi_spi
>> > >>   since the i2c-core and spi set that field.
>> > >>- Fix if statment in rmi_f30 which was testing has_led twice instead of
>> > >>   testing has_gpio.
>> > >Works like a charm.
>> > >Tested-by: Linus Walleij <linus.walleij@linaro.org>
>> >
>> > Thanks for testing. At this point except for the touchscreen binding rename
>> > fix needed in patch 5, all of the outstanding issues have been addressed. If
>> > the rest of the patch series is acceptable, then I can do a final v6 respin
>> > which fixes the binding and also removes the HID patch. But, if more work
>> > needs to be done on the patch series I can wait to do the respin. Dmitry,
>> > what do you think of the patch series at this point?
>>
>> Dmitry, ping on this one...
>>
>> I'd like to see the series in 4.6, and we are getting closer of the
>> merge window. Could we get some of your time on this?
>
> I adjusted the binding on patch 5 (to read -x-mm and y-mm) and applied
> the first 9 leaving the HID out for now.
>

Great! Thanks everyone for testing and reviewing.

Andrew

> Thanks.
>
> --
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]


#1358921

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-03-16 13:00 +0100
Message-ID<rdihj-8te-7@gated-at.bofh.it>
In reply to#1356108
On Fri, Mar 11, 2016 at 7:05 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Mar 03, 2016 at 06:11:38PM +0100, Benjamin Tissoires wrote:

>> I'd like to see the series in 4.6, and we are getting closer of the
>> merge window. Could we get some of your time on this?
>
> I adjusted the binding on patch 5 (to read -x-mm and y-mm) and applied
> the first 9 leaving the HID out for now.

Thanks to everyone involved that we finally got this in upstream shape
after all these years!

Yours,
Linus Walleij

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web