Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1355666 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-03-11 09:00 +0100 |
| Last post | 2016-03-14 15:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-11 09:00 +0100
Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() Oded Gabbay <oded.gabbay@gmail.com> - 2016-03-14 15:00 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-03-11 09:00 +0100 |
| Subject | [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() |
| Message-ID | <rbq9j-2WM-1@gated-at.bofh.it> |
At the end of the function we expect "status" to be zero, but it's
either -EINVAL or unitialized.
Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
index c34c393..d5e19b5 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
@@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
union SQ_CMD_BITS *in_reg_sq_cmd,
union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
{
- int status;
+ int status = 0;
union SQ_CMD_BITS reg_sq_cmd;
union GRBM_GFX_INDEX_BITS reg_gfx_index;
struct HsaDbgWaveMsgAMDGen2 *pMsg;
[toc] | [next] | [standalone]
| From | Oded Gabbay <oded.gabbay@gmail.com> |
|---|---|
| Date | 2016-03-14 15:00 +0100 |
| Subject | Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() |
| Message-ID | <rcBco-4sZ-35@gated-at.bofh.it> |
| In reply to | #1355666 |
On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> At the end of the function we expect "status" to be zero, but it's
> either -EINVAL or unitialized.
>
> Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> index c34c393..d5e19b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
> union SQ_CMD_BITS *in_reg_sq_cmd,
> union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
> {
> - int status;
> + int status = 0;
> union SQ_CMD_BITS reg_sq_cmd;
> union GRBM_GFX_INDEX_BITS reg_gfx_index;
> struct HsaDbgWaveMsgAMDGen2 *pMsg;
Thanks,
applied to my fixes tree.
Oded
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web