Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1356420 > unrolled thread
| Started by | Andy Yan <andy.yan@kernel-upstream.org> |
|---|---|
| First post | 2016-03-12 14:40 +0100 |
| Last post | 2016-03-14 13:20 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Andy Yan <andy.yan@kernel-upstream.org> - 2016-03-12 14:40 +0100
[PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y Andy Yan <andy.yan@kernel-upstream.org> - 2016-03-12 14:40 +0100
Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y Thierry Reding <treding@nvidia.com> - 2016-03-14 13:30 +0100
Re: [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Thierry Reding <treding@nvidia.com> - 2016-03-14 13:20 +0100
| From | Andy Yan <andy.yan@kernel-upstream.org> |
|---|---|
| Date | 2016-03-12 14:40 +0100 |
| Subject | [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y |
| Message-ID | <rbRVT-6O6-11@gated-at.bofh.it> |
All the current rk3066 based boards use pwm modulate vdd_logic voltage, the board may hang when the system boot and run to a higher frequency without pwm enabled, so enable it as builtin. Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 8e8b2ac..94639b1 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -757,7 +757,7 @@ CONFIG_PWM_ATMEL=m CONFIG_PWM_ATMEL_TCB=m CONFIG_PWM_FSL_FTM=m CONFIG_PWM_RENESAS_TPU=y -CONFIG_PWM_ROCKCHIP=m +CONFIG_PWM_ROCKCHIP=y CONFIG_PWM_SAMSUNG=m CONFIG_PWM_SUN4I=y CONFIG_PWM_TEGRA=y -- 1.9.1
[toc] | [next] | [standalone]
| From | Andy Yan <andy.yan@kernel-upstream.org> |
|---|---|
| Date | 2016-03-12 14:40 +0100 |
| Subject | [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y |
| Message-ID | <rbRVU-6O6-29@gated-at.bofh.it> |
| In reply to | #1356420 |
Some platform like Rockchip rk3066 use pwm as a regulator to modulate cpu voltage, so pwm regulator should be enabled at system boot time if the system want to run with high frequency. Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 94639b1..e0178f2 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -477,7 +477,7 @@ CONFIG_REGULATOR_MAX77693=m CONFIG_REGULATOR_MAX77802=m CONFIG_REGULATOR_PALMAS=y CONFIG_REGULATOR_PBIAS=y -CONFIG_REGULATOR_PWM=m +CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_QCOM_RPM=y CONFIG_REGULATOR_QCOM_SMD_RPM=y CONFIG_REGULATOR_S2MPS11=y -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Thierry Reding <treding@nvidia.com> |
|---|---|
| Date | 2016-03-14 13:30 +0100 |
| Subject | Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y |
| Message-ID | <rczNg-3Fk-13@gated-at.bofh.it> |
| In reply to | #1356422 |
[Multipart message — attachments visible in raw view] — view raw
On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote: > Some platform like Rockchip rk3066 use pwm as a regulator to modulate > cpu voltage, so pwm regulator should be enabled at system boot time if > the system want to run with high frequency. > > Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> > --- > > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This really belongs in patch 1/2. But then the same comments hold true and I think you'll need to come up with a proper fix that prevents the switch to a higher frequency if don't have the necessary regulator, or make the Kconfig symbol bool if all else fails. If you make the Kconfig symbol bool I'd expect a really good explanation in the commit message as to why it can't be fixed properly. Thierry
[toc] | [prev] | [next] | [standalone]
| From | Thierry Reding <treding@nvidia.com> |
|---|---|
| Date | 2016-03-14 13:20 +0100 |
| Message-ID | <rczDA-3BO-15@gated-at.bofh.it> |
| In reply to | #1356420 |
[Multipart message — attachments visible in raw view] — view raw
On Sat, Mar 12, 2016 at 08:50:29PM +0800, Andy Yan wrote: > All the current rk3066 based boards use pwm modulate vdd_logic > voltage, the board may hang when the system boot and run to a higher > frequency without pwm enabled, so enable it as builtin. I don't understand the rationale here. Surely if the system can't safely switch to a higher frequency because the regulator isn't available, then it should be prevented from switching, shouldn't it? Making this change alone will not prevent users from switching this back to =m on their own. So either you need to add code to prevent a switch to an unsupported frequency in the absence of the regulator, or you need to change the PWM_ROCKCHIP Kconfig option to be bool instead, though the latter is of course a somewhat ugly hack, whereas the former would be a proper fix. Thierry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web