Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1355278 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2016-03-10 18:40 +0100 |
| Last post | 2016-03-17 09:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] s390: disable postinit-readonly for now Kees Cook <keescook@chromium.org> - 2016-03-10 18:40 +0100
Re: [PATCH] s390: disable postinit-readonly for now Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-12 12:20 +0100
Re: [PATCH] s390: disable postinit-readonly for now Christian Borntraeger <borntraeger@de.ibm.com> - 2016-03-16 20:50 +0100
Re: [PATCH] s390: disable postinit-readonly for now Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-03-17 09:50 +0100
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-03-10 18:40 +0100 |
| Subject | [PATCH] s390: disable postinit-readonly for now |
| Message-ID | <rbcJ3-1SN-5@gated-at.bofh.it> |
This is a temporary fix to let lkdtm run again on s390, though it'll
still fail the ro_after_init tests. Until rodata and ro_after_init
sections can be split on s390, disable special handling of ro_after_init.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
for -next ...
---
arch/s390/include/asm/cache.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
index 4d7ccac5fd1d..22da3b34c655 100644
--- a/arch/s390/include/asm/cache.h
+++ b/arch/s390/include/asm/cache.h
@@ -15,4 +15,7 @@
#define __read_mostly __attribute__((__section__(".data..read_mostly")))
+/* Read-only memory is marked before mark_rodata_ro() is called. */
+#define __ro_after_init __read_mostly
+
#endif
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [next] | [standalone]
| From | Heiko Carstens <heiko.carstens@de.ibm.com> |
|---|---|
| Date | 2016-03-12 12:20 +0100 |
| Message-ID | <rbPKp-568-3@gated-at.bofh.it> |
| In reply to | #1355278 |
On Thu, Mar 10, 2016 at 09:31:44AM -0800, Kees Cook wrote:
> This is a temporary fix to let lkdtm run again on s390, though it'll
> still fail the ro_after_init tests. Until rodata and ro_after_init
> sections can be split on s390, disable special handling of ro_after_init.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> for -next ...
> ---
> arch/s390/include/asm/cache.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
> index 4d7ccac5fd1d..22da3b34c655 100644
> --- a/arch/s390/include/asm/cache.h
> +++ b/arch/s390/include/asm/cache.h
> @@ -15,4 +15,7 @@
>
> #define __read_mostly __attribute__((__section__(".data..read_mostly")))
>
> +/* Read-only memory is marked before mark_rodata_ro() is called. */
> +#define __ro_after_init __read_mostly
> +
> #endif
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
[toc] | [prev] | [next] | [standalone]
| From | Christian Borntraeger <borntraeger@de.ibm.com> |
|---|---|
| Date | 2016-03-16 20:50 +0100 |
| Message-ID | <rdpCa-4V9-23@gated-at.bofh.it> |
| In reply to | #1355278 |
On 03/10/2016 06:31 PM, Kees Cook wrote:
> This is a temporary fix to let lkdtm run again on s390, though it'll
> still fail the ro_after_init tests. Until rodata and ro_after_init
> sections can be split on s390, disable special handling of ro_after_init.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> for -next ...
Given that the other patches are already merged in linus master via Ingo,
do you want this to go via Ingo as well?
> ---
> arch/s390/include/asm/cache.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
> index 4d7ccac5fd1d..22da3b34c655 100644
> --- a/arch/s390/include/asm/cache.h
> +++ b/arch/s390/include/asm/cache.h
> @@ -15,4 +15,7 @@
>
> #define __read_mostly __attribute__((__section__(".data..read_mostly")))
>
> +/* Read-only memory is marked before mark_rodata_ro() is called. */
> +#define __ro_after_init __read_mostly
> +
> #endif
>
[toc] | [prev] | [next] | [standalone]
| From | Heiko Carstens <heiko.carstens@de.ibm.com> |
|---|---|
| Date | 2016-03-17 09:50 +0100 |
| Message-ID | <rdBN0-4Xk-5@gated-at.bofh.it> |
| In reply to | #1359259 |
On Wed, Mar 16, 2016 at 08:47:44PM +0100, Christian Borntraeger wrote:
> On 03/10/2016 06:31 PM, Kees Cook wrote:
> > This is a temporary fix to let lkdtm run again on s390, though it'll
> > still fail the ro_after_init tests. Until rodata and ro_after_init
> > sections can be split on s390, disable special handling of ro_after_init.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> > for -next ...
>
> Given that the other patches are already merged in linus master via Ingo,
> do you want this to go via Ingo as well?
Let's route this via the s390 tree. I will add another patch to get rid of
the bogus "This architecture does not have kernel memory protection."
message printed to the console, just like parisc.
> > ---
> > arch/s390/include/asm/cache.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
> > index 4d7ccac5fd1d..22da3b34c655 100644
> > --- a/arch/s390/include/asm/cache.h
> > +++ b/arch/s390/include/asm/cache.h
> > @@ -15,4 +15,7 @@
> >
> > #define __read_mostly __attribute__((__section__(".data..read_mostly")))
> >
> > +/* Read-only memory is marked before mark_rodata_ro() is called. */
> > +#define __ro_after_init __read_mostly
> > +
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web