Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1355100 > unrolled thread

[PATCH v2] phy: remove documentation of removed members of phy_device structure

Started byLABBE Corentin <clabbe.montjoie@gmail.com>
First post2016-03-10 14:00 +0100
Last post2016-03-14 03:20 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] phy: remove documentation of removed members of phy_device structure LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-03-10 14:00 +0100
    Re: [PATCH v2] phy: remove documentation of removed members of  phy_device structure Andrew Lunn <andrew@lunn.ch> - 2016-03-10 15:30 +0100
    Re: [PATCH v2] phy: remove documentation of removed members of  phy_device structure Florian Fainelli <f.fainelli@gmail.com> - 2016-03-10 19:00 +0100
    Re: [PATCH v2] phy: remove documentation of removed members of  phy_device structure David Miller <davem@davemloft.net> - 2016-03-14 03:20 +0100

#1355100 — [PATCH v2] phy: remove documentation of removed members of phy_device structure

FromLABBE Corentin <clabbe.montjoie@gmail.com>
Date2016-03-10 14:00 +0100
Subject[PATCH v2] phy: remove documentation of removed members of phy_device structure
Message-ID<rb8m7-78l-19@gated-at.bofh.it>
Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
bus and dev member of the phy_device structure.
This patch remove the documentation about those members.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 include/linux/phy.h | 3 ---
 1 file changed, 3 deletions(-)

Changes since v1
- remove also documentation for dev and bus

diff --git a/include/linux/phy.h b/include/linux/phy.h
index d6f3641..2abd791 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -327,8 +327,6 @@ struct phy_c45_device_ids {
 /* phy_device: An instance of a PHY
  *
  * drv: Pointer to the driver for this PHY instance
- * bus: Pointer to the bus this PHY is on
- * dev: driver model device structure for this PHY
  * phy_id: UID for this device found during discovery
  * c45_ids: 802.3-c45 Device Identifers if is_c45.
  * is_c45:  Set to true if this phy uses clause 45 addressing.
@@ -338,7 +336,6 @@ struct phy_c45_device_ids {
  * suspended: Set to true if this phy has been suspended successfully.
  * state: state of the PHY for management purposes
  * dev_flags: Device-specific flags used by the PHY driver.
- * addr: Bus address of PHY
  * link_timeout: The number of timer firings to wait before the
  * giving up on the current attempt at acquiring a link
  * irq: IRQ number of the PHY's interrupt (-1 if none)
-- 
2.4.10

[toc] | [next] | [standalone]


#1355155 — Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

FromAndrew Lunn <andrew@lunn.ch>
Date2016-03-10 15:30 +0100
SubjectRe: [PATCH v2] phy: remove documentation of removed members of phy_device structure
Message-ID<rb9Lc-89a-17@gated-at.bofh.it>
In reply to#1355100
On Thu, Mar 10, 2016 at 01:58:58PM +0100, LABBE Corentin wrote:
> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Hi Corentin

Thanks for updating the patch with the extra removals.

       Andrew

> ---
>  include/linux/phy.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> Changes since v1
> - remove also documentation for dev and bus
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index d6f3641..2abd791 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -327,8 +327,6 @@ struct phy_c45_device_ids {
>  /* phy_device: An instance of a PHY
>   *
>   * drv: Pointer to the driver for this PHY instance
> - * bus: Pointer to the bus this PHY is on
> - * dev: driver model device structure for this PHY
>   * phy_id: UID for this device found during discovery
>   * c45_ids: 802.3-c45 Device Identifers if is_c45.
>   * is_c45:  Set to true if this phy uses clause 45 addressing.
> @@ -338,7 +336,6 @@ struct phy_c45_device_ids {
>   * suspended: Set to true if this phy has been suspended successfully.
>   * state: state of the PHY for management purposes
>   * dev_flags: Device-specific flags used by the PHY driver.
> - * addr: Bus address of PHY
>   * link_timeout: The number of timer firings to wait before the
>   * giving up on the current attempt at acquiring a link
>   * irq: IRQ number of the PHY's interrupt (-1 if none)
> -- 
> 2.4.10
> 

[toc] | [prev] | [next] | [standalone]


#1355291 — Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

FromFlorian Fainelli <f.fainelli@gmail.com>
Date2016-03-10 19:00 +0100
SubjectRe: [PATCH v2] phy: remove documentation of removed members of phy_device structure
Message-ID<rbd2r-1Zy-25@gated-at.bofh.it>
In reply to#1355100
On 10/03/16 04:58, LABBE Corentin wrote:
> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

[toc] | [prev] | [next] | [standalone]


#1356830 — Re: [PATCH v2] phy: remove documentation of removed members of phy_device structure

FromDavid Miller <davem@davemloft.net>
Date2016-03-14 03:20 +0100
SubjectRe: [PATCH v2] phy: remove documentation of removed members of phy_device structure
Message-ID<rcqgV-5LW-15@gated-at.bofh.it>
In reply to#1355100
From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: Thu, 10 Mar 2016 13:58:58 +0100

> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr,
> bus and dev member of the phy_device structure.
> This patch remove the documentation about those members.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web