Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1354887 > unrolled thread

[PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c

Started bynancygoel62 <nancygoel62@gmail.com>
First post2016-03-10 08:10 +0100
Last post2016-03-11 04:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c nancygoel62 <nancygoel62@gmail.com> - 2016-03-10 08:10 +0100
    Re: [PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at  a line in baseband.c Greg KH <gregkh@linuxfoundation.org> - 2016-03-11 04:30 +0100

#1354887 — [PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c

Fromnancygoel62 <nancygoel62@gmail.com>
Date2016-03-10 08:10 +0100
Subject[PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c
Message-ID<rb2Tn-3sO-5@gated-at.bofh.it>
This is a patch to the baseband.c file that fixes the warnings of more than 80 characters at a line by the checkpatch.pl tool

Signed-off-by: Nancy Goel <nancygoel62@gmail.com>
---
 drivers/staging/vt6655/baseband.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 1e6c0c4..88aff82 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -36,8 +36,10 @@
  * Revision History:
  *      06-10-2003 Bryan YC Fan:  Re-write codes to support VT3253 spec.
  *      08-07-2003 Bryan YC Fan:  Add MAXIM2827/2825 and RFMD2959 support.
- *      08-26-2003 Kyle Hsu    :  Modify BBuGetFrameTime() and BBvCalculateParameter().
- *                                cancel the setting of MAC_REG_SOFTPWRCTL on BBbVT3253Init().
+ *      08-26-2003 Kyle Hsu    :  Modify BBuGetFrameTime() and
+ *								  BBvCalculateParameter().
+ *                                cancel the setting of MAC_REG_SOFTPWRCTL
+ *								  on BBbVT3253Init().
  *                                Add the comments.
  *      09-01-2003 Bryan YC Fan:  RF & BB tables updated.
  *                                Modified BBvLoopbackOn & BBvLoopbackOff().
@@ -2160,10 +2162,12 @@ bool BBbVT3253Init(struct vnt_private *priv)
 
 
 		/* {{ RobertYu:20050223, request by JerryChung */
-		/* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */
-		/*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/
-		/* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */
-		/*bResult &= BBbWriteEmbedded(dwIoBase,0x0a,0x28);*/
+		/* Init ANT B select,TX Config CR09 = 0x61->0x45, */
+		/* 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */
+		/* bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/
+		/* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28 */
+		/* (VC1/VC2 define, make the ANT_A, ANT_B inverted) */
+		/* bResult &= BBbWriteEmbedded(dwIoBase,0x0a,0x28);*/
 		/* Select VC1/VC2, CR215 = 0x02->0x06 */
 		bResult &= BBbWriteEmbedded(priv, 0xd7, 0x06);
 		/* }} */
-- 
1.9.1

[toc] | [next] | [standalone]


#1355575 — Re: [PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-03-11 04:30 +0100
SubjectRe: [PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c
Message-ID<rblW2-4T-1@gated-at.bofh.it>
In reply to#1354887
On Thu, Mar 10, 2016 at 12:39:08PM +0530, nancygoel62 wrote:
> This is a patch to the baseband.c file that fixes the warnings of more than 80 characters at a line by the checkpatch.pl tool
> 
> Signed-off-by: Nancy Goel <nancygoel62@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)

Your From: line doesn't match your signed-off-by name :(

Also, please wrap your changelog entries at 72 columns.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web