Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1353408 > unrolled thread

Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

Started byEduardo Valentin <edubezval@gmail.com>
First post2016-03-08 22:10 +0100
Last post2016-03-08 23:00 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional  property in DT binding Eduardo Valentin <edubezval@gmail.com> - 2016-03-08 22:10 +0100
    Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional  property in DT binding Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-08 22:40 +0100
      Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional  property in DT binding Eduardo Valentin <edubezval@gmail.com> - 2016-03-08 23:00 +0100

#1353408 — Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

FromEduardo Valentin <edubezval@gmail.com>
Date2016-03-08 22:10 +0100
SubjectRe: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding
Message-ID<rax3b-6qY-7@gated-at.bofh.it>
On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> index faa62059b5c5..70b4c16c7ed8 100644
> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> @@ -41,9 +41,6 @@
>  		for current TMU channel
>  	-- "tmu_sclk" clock for functional operation of the current TMU
>  		channel
> -- vtmu-supply: This entry is optional and provides the regulator node supplying
> -		voltage to TMU. If needed this entry can be placed inside
> -		board/platform specific dts file.
>  
>  The Exynos TMU supports generating interrupts when reaching given
>  temperature thresholds. Number of supported thermal trip points depends

Where is this patch based on? I checked it on my fixes and linus
branches, also on linux-next 0308 branch, and none of those apply clean.

Can you please send this based on upstream kernel?

> @@ -65,6 +62,12 @@ Following properties are mandatory (depending on SoC):
>  - samsung,tmu_default_temp_offset: Default temperature offset
>  - samsung,tmu_cal_type: Callibration type
>  
> +** Optional properties:
> +
> +- vtmu-supply: This entry is optional and provides the regulator node supplying
> +		voltage to TMU. If needed this entry can be placed inside
> +		board/platform specific dts file.
> +
>  Example 1):
>  
>  	tmu@100C0000 {
> -- 
> 2.5.0
> 

[toc] | [next] | [standalone]


#1353427

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-03-08 22:40 +0100
Message-ID<raxwd-6Ct-9@gated-at.bofh.it>
In reply to#1353408
Hello Eduardo,

On 03/08/2016 06:07 PM, Eduardo Valentin wrote:
> On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
>> The Exynos Thermal Management Unit binding says that the vtmu-supply
>> is optional but is listed in the required properties section. Add an
>> optional properties section and move the regulator property there.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> index faa62059b5c5..70b4c16c7ed8 100644
>> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> @@ -41,9 +41,6 @@
>>  		for current TMU channel
>>  	-- "tmu_sclk" clock for functional operation of the current TMU
>>  		channel
>> -- vtmu-supply: This entry is optional and provides the regulator node supplying
>> -		voltage to TMU. If needed this entry can be placed inside
>> -		board/platform specific dts file.
>>  
>>  The Exynos TMU supports generating interrupts when reaching given
>>  temperature thresholds. Number of supported thermal trip points depends
> 
> Where is this patch based on? I checked it on my fixes and linus
> branches, also on linux-next 0308 branch, and none of those apply clean.
>

I mentioned in the cover letter [0] that this series were based on top
of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts.

Those have not landed yet either so maybe you could look at those first?
 
> Can you please send this based on upstream kernel?
>

Ok, my intention was to make picking both patch series easier but if
this is inconvenient to you, I can base on top of current mainline
and let you handle the merge conflicts (or ask Krzysztof to resend
on top of my patches).

[0]: https://lkml.org/lkml/2016/2/18/591
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]


#1353434

FromEduardo Valentin <edubezval@gmail.com>
Date2016-03-08 23:00 +0100
Message-ID<raxPA-6Jq-23@gated-at.bofh.it>
In reply to#1353427
On Tue, Mar 08, 2016 at 06:30:17PM -0300, Javier Martinez Canillas wrote:
> Hello Eduardo,
> 
> On 03/08/2016 06:07 PM, Eduardo Valentin wrote:
> > On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> >> The Exynos Thermal Management Unit binding says that the vtmu-supply
> >> is optional but is listed in the required properties section. Add an
> >> optional properties section and move the regulator property there.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >> ---
> >>
> >>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
> >>  1 file changed, 6 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> index faa62059b5c5..70b4c16c7ed8 100644
> >> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> @@ -41,9 +41,6 @@
> >>  		for current TMU channel
> >>  	-- "tmu_sclk" clock for functional operation of the current TMU
> >>  		channel
> >> -- vtmu-supply: This entry is optional and provides the regulator node supplying
> >> -		voltage to TMU. If needed this entry can be placed inside
> >> -		board/platform specific dts file.
> >>  
> >>  The Exynos TMU supports generating interrupts when reaching given
> >>  temperature thresholds. Number of supported thermal trip points depends
> > 
> > Where is this patch based on? I checked it on my fixes and linus
> > branches, also on linux-next 0308 branch, and none of those apply clean.
> >
> 
> I mentioned in the cover letter [0] that this series were based on top
> of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts.
> 
> Those have not landed yet either so maybe you could look at those first?
>  
> > Can you please send this based on upstream kernel?
> >
> 
> Ok, my intention was to make picking both patch series easier but if
> this is inconvenient to you, I can base on top of current mainline
> and let you handle the merge conflicts (or ask Krzysztof to resend
> on top of my patches).
> 
> [0]: https://lkml.org/lkml/2016/2/18/591

Got it. I am checking his patches first then.

>  
> Best regards,
> -- 
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web