Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1352289 > unrolled thread

[PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2016-03-08 01:00 +0100
    RE: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-03-08 03:00 +0100
      Re: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings Lee Jones <lee.jones@linaro.org> - 2016-03-08 06:00 +0100

#1352289 — [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Wenyou Yang <wenyou.yang@atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 act8945a.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/mfd/act8945a.c
+++ b/drivers/mfd/act8945a.c
@@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc
 static struct i2c_driver act8945a_i2c_driver = {
 	.driver = {
 		   .name = "act8945a",
-		   .owner = THIS_MODULE,
 		   .of_match_table = of_match_ptr(act8945a_of_match),
 	},
 	.probe = act8945a_i2c_probe,

[toc] | [next] | [standalone]

#1352548

Hi Fengguang Wu,

Thank you for your patch.

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@intel.com]
> Sent: 2016年3月8日 7:54
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: kbuild-all@01.org; Lee Jones <lee.jones@linaro.org>; Rob Herring
> <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland
> <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> Gala <galak@codeaurora.org>; Ferre, Nicolas <Nicolas.FERRE@atmel.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Yang, Wenyou
> <Wenyou.Yang@atmel.com>
> Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
> 
> drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Wenyou Yang <wenyou.yang@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Reviewed-by: Wenyou Yang <wenyou.yang@atmel.com>

> ---
> 
>  act8945a.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/mfd/act8945a.c
> +++ b/drivers/mfd/act8945a.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc  static
> struct i2c_driver act8945a_i2c_driver = {
>  	.driver = {
>  		   .name = "act8945a",
> -		   .owner = THIS_MODULE,
>  		   .of_match_table = of_match_ptr(act8945a_of_match),
>  	},
>  	.probe = act8945a_i2c_probe,


Best Regards,
Wenyou Yang

[toc] | [prev] | [next] | [standalone]

#1352627

On Tue, 08 Mar 2016, Yang, Wenyou wrote:

> Hi Fengguang Wu,
> 
> Thank you for your patch.
> 
> > -----Original Message-----
> > From: kbuild test robot [mailto:lkp@intel.com]
> > Sent: 2016年3月8日 7:54
> > To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> > Cc: kbuild-all@01.org; Lee Jones <lee.jones@linaro.org>; Rob Herring
> > <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland
> > <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> > Gala <galak@codeaurora.org>; Ferre, Nicolas <Nicolas.FERRE@atmel.com>;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Yang, Wenyou
> > <Wenyou.Yang@atmel.com>
> > Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
> > 
> > drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
> > 
> >  Remove .owner field if calls are used which set it automatically
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > CC: Wenyou Yang <wenyou.yang@atmel.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Reviewed-by: Wenyou Yang <wenyou.yang@atmel.com>

Please fix this code up into the original patch and resubmit the set.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web