Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350775 > unrolled thread

Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

Started byRob Herring <robh@kernel.org>
First post2016-03-05 05:30 +0100
Last post2016-03-09 01:20 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings Rob Herring <robh@kernel.org> - 2016-03-05 05:30 +0100
    RE: [PATCH v3 3/7] QE: Add uqe_serial document to bindings Qiang Zhao <qiang.zhao@nxp.com> - 2016-03-07 04:00 +0100
      Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings Scott Wood <oss@buserror.net> - 2016-03-07 18:30 +0100
        RE: [PATCH v3 3/7] QE: Add uqe_serial document to bindings Qiang Zhao <qiang.zhao@nxp.com> - 2016-03-08 02:20 +0100
          Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings Scott Wood <oss@buserror.net> - 2016-03-09 01:20 +0100

#1350775 — Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

FromRob Herring <robh@kernel.org>
Date2016-03-05 05:30 +0100
SubjectRe: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
Message-ID<r9c0O-H5-33@gated-at.bofh.it>
On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> 	- modify tx/rx-clock-name specification
> Changes for v2
> 	- NA 
> 
>  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> new file mode 100644
> index 0000000..436c71c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> @@ -0,0 +1,19 @@
> +* Serial
> +
> +Currently defined compatibles:
> +- ucc_uart

I guess this is in use already and okay. However, looking at the driver 
there really should be SoC specific compatible strings here since the 
driver is looking up the SoC compatible string and composing the 
firmware filename from that.

> +
> +Properties for ucc_uart:
> +port-number : port number of UCC-UART
> +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> +		   should be "clk1"-"clk28" for external clock source.
> +
> +Example:
> +
> +	ucc_serial: ucc@2200 {
> +		device_type = "serial";

Drop device_type. It should only be used in a few legacy cases.

Looks like the driver is matching on this. Please drop it from the 
driver too. I'd leave dts files for now, but they should be updated too 
later.

> +		compatible = "ucc_uart";
> +		port-number = <1>;
> +		rx-clock-name = "brg2";
> +		tx-clock-name = "brg2";
> +	};
> -- 
> 2.1.0.27.g96db324
>

[toc] | [next] | [standalone]

#1351275

FromQiang Zhao <qiang.zhao@nxp.com>
Date2016-03-07 04:00 +0100
Message-ID<r9TyN-5eG-1@gated-at.bofh.it>
In reply to#1350775
On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Saturday, March 05, 2016 12:26 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> 
> On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > Add uqe_serial document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > 	- modify tx/rx-clock-name specification Changes for v2
> > 	- NA
> >
> >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19
> +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > new file mode 100644
> > index 0000000..436c71c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > +++ txt
> > @@ -0,0 +1,19 @@
> > +* Serial
> > +
> > +Currently defined compatibles:
> > +- ucc_uart
> 
> I guess this is in use already and okay. However, looking at the driver there
> really should be SoC specific compatible strings here since the driver is looking
> up the SoC compatible string and composing the firmware filename from that.

Ok, I will changed both driver and this compatible.

> 
> > +
> > +Properties for ucc_uart:
> > +port-number : port number of UCC-UART tx/rx-clock-name : should be
> > +"brg1"-"brg16" for internal clock source,
> > +		   should be "clk1"-"clk28" for external clock source.
> > +
> > +Example:
> > +
> > +	ucc_serial: ucc@2200 {
> > +		device_type = "serial";
> 
> Drop device_type. It should only be used in a few legacy cases.
> 
> Looks like the driver is matching on this. Please drop it from the driver too. I'd
> leave dts files for now, but they should be updated too later.

Ok, Thank you for your Reviewing, I will drop it

> 
> > +		compatible = "ucc_uart";
> > +		port-number = <1>;
> > +		rx-clock-name = "brg2";
> > +		tx-clock-name = "brg2";
> > +	};
> > --
> > 2.1.0.27.g96db324
> >

[toc] | [prev] | [next] | [standalone]

#1351818

FromScott Wood <oss@buserror.net>
Date2016-03-07 18:30 +0100
Message-ID<ra78J-5Qh-1@gated-at.bofh.it>
In reply to#1351275
On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:
> On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: Saturday, March 05, 2016 12:26 PM
> > To: Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> > <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > 
> > On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > > Add uqe_serial document to
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > > 
> > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > ---
> > > Changes for v2
> > > 	- modify tx/rx-clock-name specification Changes for v2
> > > 	- NA
> > > 
> > >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19
> > +++++++++++++++++++
> > >  1 file changed, 19 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > > new file mode 100644
> > > index 0000000..436c71c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > +++ txt
> > > @@ -0,0 +1,19 @@
> > > +* Serial
> > > +
> > > +Currently defined compatibles:
> > > +- ucc_uart
> > 
> > I guess this is in use already and okay. However, looking at the driver
> > there
> > really should be SoC specific compatible strings here since the driver is
> > looking
> > up the SoC compatible string and composing the firmware filename from
> > that.
> 
> Ok, I will changed both driver and this compatible.

But don't break existing device trees while doing so.

-Scott

[toc] | [prev] | [next] | [standalone]

#1352527

FromQiang Zhao <qiang.zhao@nxp.com>
Date2016-03-08 02:20 +0100
Message-ID<raetz-2gX-9@gated-at.bofh.it>
In reply to#1351818
On Tue, Mar 08, 2016 at 1:28AM, Scott Wood wrote:
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Tuesday, March 08, 2016 1:28 AM
> To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> Cc: Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org
> Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> 
> On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:
> > On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> > > -----Original Message-----
> > > From: Rob Herring [mailto:robh@kernel.org]
> > > Sent: Saturday, March 05, 2016 12:26 PM
> > > To: Qiang Zhao <qiang.zhao@nxp.com>
> > > Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> > > <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > >
> > > On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > > > Add uqe_serial document to
> > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > t
> > > >
> > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > ---
> > > > Changes for v2
> > > > 	- modify tx/rx-clock-name specification Changes for v2
> > > > 	- NA
> > > >
> > > >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19
> > > +++++++++++++++++++
> > > >  1 file changed, 19 insertions(+)
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > t
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > txt
> > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > txt
> > > > new file mode 100644
> > > > index 0000000..436c71c
> > > > --- /dev/null
> > > > +++
> b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > +++ txt
> > > > @@ -0,0 +1,19 @@
> > > > +* Serial
> > > > +
> > > > +Currently defined compatibles:
> > > > +- ucc_uart
> > >
> > > I guess this is in use already and okay. However, looking at the
> > > driver there really should be SoC specific compatible strings here
> > > since the driver is looking up the SoC compatible string and
> > > composing the firmware filename from that.
> >
> > Ok, I will changed both driver and this compatible.
> 
> But don't break existing device trees while doing so.

Do I need to send driver patch in this patchset or a individual patch?

BR
-Zhao Qiang

[toc] | [prev] | [next] | [standalone]

#1353500

FromScott Wood <oss@buserror.net>
Date2016-03-09 01:20 +0100
Message-ID<raA14-8s0-9@gated-at.bofh.it>
In reply to#1352527
On Tue, 2016-03-08 at 01:16 +0000, Qiang Zhao wrote:
> On Tue, Mar 08, 2016 at 1:28AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Tuesday, March 08, 2016 1:28 AM
> > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
> > dev@lists.ozlabs.org
> > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > 
> > On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:
> > > On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> > > > -----Original Message-----
> > > > From: Rob Herring [mailto:robh@kernel.org]
> > > > Sent: Saturday, March 05, 2016 12:26 PM
> > > > To: Qiang Zhao <qiang.zhao@nxp.com>
> > > > Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> > > > <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > > > 
> > > > On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > > > > Add uqe_serial document to
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > > t
> > > > > 
> > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > ---
> > > > > Changes for v2
> > > > > 	- modify tx/rx-clock-name specification Changes for v2
> > > > > 	- NA
> > > > > 
> > > > >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19
> > > > +++++++++++++++++++
> > > > >  1 file changed, 19 insertions(+)
> > > > >  create mode 100644
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > > t
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > txt
> > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > txt
> > > > > new file mode 100644
> > > > > index 0000000..436c71c
> > > > > --- /dev/null
> > > > > +++
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > +++ txt
> > > > > @@ -0,0 +1,19 @@
> > > > > +* Serial
> > > > > +
> > > > > +Currently defined compatibles:
> > > > > +- ucc_uart
> > > > 
> > > > I guess this is in use already and okay. However, looking at the
> > > > driver there really should be SoC specific compatible strings here
> > > > since the driver is looking up the SoC compatible string and
> > > > composing the firmware filename from that.
> > > 
> > > Ok, I will changed both driver and this compatible.
> > 
> > But don't break existing device trees while doing so.
> 
> Do I need to send driver patch in this patchset or a individual patch?

Doesn't matter.

-Scott

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web