Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1354114 > unrolled thread

[PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620

Back to article view | Back to linux.kernel

Contents

  [PATCH V2 0/6]  thermal: add devm_ version of thermal_zone register and driver for max77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-09 14:30 +0100
    [PATCH V2 6/6] thermal: Add DT binding doc for thermal of PMIC max77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-09 14:30 +0100
      Re: [PATCH V2 6/6] thermal: Add DT binding doc for thermal of PMIC  max77620 Eduardo Valentin <edubezval@gmail.com> - 2016-03-09 20:30 +0100
    [PATCH V2 3/6] thermal: Add devm_thermal_zone_of_sensor_register() in managed devices list Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-09 14:30 +0100
      Re: [PATCH V2 3/6] thermal: Add  devm_thermal_zone_of_sensor_register() in managed devices list Eduardo Valentin <edubezval@gmail.com> - 2016-03-09 20:40 +0100
    Re: [PATCH V2 0/6]  thermal: add devm_ version of thermal_zone  register and driver for max77620 Eduardo Valentin <edubezval@gmail.com> - 2016-03-09 19:30 +0100
    Re: [PATCH V2 0/6]  thermal: add devm_ version of thermal_zone  register and driver for max77620 Eduardo Valentin <edubezval@gmail.com> - 2016-03-09 20:40 +0100
      Re: [PATCH V2 0/6]  thermal: add devm_ version of thermal_zone register  and driver for max77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-10 08:10 +0100

#1354114 — [PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620

The series add the devm_ version of thermal_zone_of_sensor_register/
unregister, interface details, and use this in new thermal driver
for max77620.

The header file for max77620 is part of MFD patch
	https://lkml.org/lkml/2016/2/11/186

Changes from V1:
- Run checkpatch with --strict and fix all warnings.
- Added details of interfaces in spifs-api.txt
- Added DT binding doc.

Laxman Dewangan (6):
  thermal: doc: Add details of
    thermal_zone_of_sensor_{register,unregister}
  thermal: of-thermal: Add devm version of
    thermal_zone_of_sensor_register
  thermal: Add devm_thermal_zone_of_sensor_register() in managed devices
    list
  thermal: doc: Add details of
    devm_thermal_zone_of_sensor_{register,unregister}
  thermal: max77620: Add thermal driver for reporting junction temp
  thermal: Add DT binding doc for thermal of PMIC max77620

 .../bindings/thermal/thermal-max77620.txt          |  43 ++++++
 Documentation/driver-model/devres.txt              |   4 +
 Documentation/thermal/sysfs-api.txt                |  68 ++++++++++
 drivers/thermal/Kconfig                            |  10 ++
 drivers/thermal/Makefile                           |   1 +
 drivers/thermal/of-thermal.c                       |  81 +++++++++++
 drivers/thermal/thermal-max77620.c                 | 151 +++++++++++++++++++++
 include/linux/thermal.h                            |  18 +++
 8 files changed, 376 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/thermal-max77620.txt
 create mode 100644 drivers/thermal/thermal-max77620.c

-- 
2.1.4

[toc] | [next] | [standalone]

#1354116 — [PATCH V2 6/6] thermal: Add DT binding doc for thermal of PMIC max77620

Maxim Semiconductor MAX77620 supports alarm interrupts when
its die temperature crosses 120C and 140C. These threshold
temperatures are not configurable.

Add DT binding document to details out the DT property related
to MAX77620 thermal functionality.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

---
Changes from V1:
- New in series to add DT binding doc per V1 review.

 .../bindings/thermal/thermal-max77620.txt          | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/thermal-max77620.txt

diff --git a/Documentation/devicetree/bindings/thermal/thermal-max77620.txt b/Documentation/devicetree/bindings/thermal/thermal-max77620.txt
new file mode 100644
index 0000000..d76412f
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/thermal-max77620.txt
@@ -0,0 +1,43 @@
+Thermal driver for MAX77620 Power management IC from Maxim Semiconductor.
+
+Maxim Semiconductor MAX77620 supports alarm interrupts when its
+die temperature crosses 120C and 140C. These threshold temperatures
+are not configurable. Device does not provide the real temperature
+of die other than just indicating whether temperature is above or
+below threshold level.
+
+Required properties:
+-------------------
+#thermal-sensor-cells:	Please refer <devicetree/bindings/thermal/thermal.txt>
+			for more details.
+			The value must be 0.
+
+For more details, please refer generic thermal DT binding document
+<devicetree/bindings/thermal/thermal.txt>.
+
+Please refer <devicetree/bindings/mfd/max77620.txt> for mfd DT binding
+document for the MAX77620.
+
+Example:
+--------
+#include <dt-bindings/mfd/max77620.h>
+...
+spmic: max77620@3c {
+	compatible = "maxim,max77620";
+
+	#thermal-sensor-cells = <0>;
+};
+
+thermal-zones {
+	PMIC-Die {
+		thermal-sensors = <&spmic>;
+		trips {
+			die_temp_thresh: hot-die {
+				temperature = <120000>;
+				type = "active";
+				hysteresis = <0>;
+			};
+		};
+	};
+};
+
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1354375 — Re: [PATCH V2 6/6] thermal: Add DT binding doc for thermal of PMIC max77620

On Wed, Mar 09, 2016 at 06:40:10PM +0530, Laxman Dewangan wrote:
> Maxim Semiconductor MAX77620 supports alarm interrupts when
> its die temperature crosses 120C and 140C. These threshold
> temperatures are not configurable.
> 
> Add DT binding document to details out the DT property related
> to MAX77620 thermal functionality.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> 
> ---
> Changes from V1:
> - New in series to add DT binding doc per V1 review.
> 
>  .../bindings/thermal/thermal-max77620.txt          | 43 ++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/thermal-max77620.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-max77620.txt b/Documentation/devicetree/bindings/thermal/thermal-max77620.txt
> new file mode 100644
> index 0000000..d76412f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/thermal-max77620.txt
> @@ -0,0 +1,43 @@
> +Thermal driver for MAX77620 Power management IC from Maxim Semiconductor.
> +
> +Maxim Semiconductor MAX77620 supports alarm interrupts when its
> +die temperature crosses 120C and 140C. These threshold temperatures
> +are not configurable. Device does not provide the real temperature
> +of die other than just indicating whether temperature is above or
> +below threshold level.
> +
> +Required properties:
> +-------------------
> +#thermal-sensor-cells:	Please refer <devicetree/bindings/thermal/thermal.txt>
> +			for more details.
> +			The value must be 0.
> +
> +For more details, please refer generic thermal DT binding document
> +<devicetree/bindings/thermal/thermal.txt>.
> +
> +Please refer <devicetree/bindings/mfd/max77620.txt> for mfd DT binding
> +document for the MAX77620.
> +
> +Example:
> +--------
> +#include <dt-bindings/mfd/max77620.h>
> +...
> +spmic: max77620@3c {
> +	compatible = "maxim,max77620";
> +
> +	#thermal-sensor-cells = <0>;
> +};
> +
> +thermal-zones {
> +	PMIC-Die {
> +		thermal-sensors = <&spmic>;
> +		trips {
> +			die_temp_thresh: hot-die {
> +				temperature = <120000>;
> +				type = "active";
> +				hysteresis = <0>;
> +			};
> +		};
> +	};
> +};


Considering that this is an example (and people will copy and paste it),
please add all the required DT properties for a thermal-zone node.

> +
> -- 
> 2.1.4
> 

[toc] | [prev] | [next] | [standalone]

#1354118 — [PATCH V2 3/6] thermal: Add devm_thermal_zone_of_sensor_register() in managed devices list

The interface thermal_zone_of_sensor_register() and
thermal_zone_of_sensor_unregister() gained their devm_
wrappers. Add these APIs in the list of managed devices.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

---
Changes from V1:
- No change.

 Documentation/driver-model/devres.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
index 5930d9a..dd7ce58 100644
--- a/Documentation/driver-model/devres.txt
+++ b/Documentation/driver-model/devres.txt
@@ -342,6 +342,10 @@ SLAVE DMA ENGINE
 SPI
   devm_spi_register_master()
 
+THERMAL
+ devm_thermal_zone_of_sensor_register()
+ devm_thermal_zone_of_sensor_unregister()
+
 WATCHDOG
   devm_watchdog_register_device()
   devm_watchdog_unregister_device()
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1354387 — Re: [PATCH V2 3/6] thermal: Add devm_thermal_zone_of_sensor_register() in managed devices list

On Wed, Mar 09, 2016 at 06:40:07PM +0530, Laxman Dewangan wrote:
> The interface thermal_zone_of_sensor_register() and
> thermal_zone_of_sensor_unregister() gained their devm_
> wrappers. Add these APIs in the list of managed devices.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

Acked-by: Eduardo Valentin <edubezval@gmail.com>


This should probably go via the documentation tree.


> 
> ---
> Changes from V1:
> - No change.
> 
>  Documentation/driver-model/devres.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
> index 5930d9a..dd7ce58 100644
> --- a/Documentation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -342,6 +342,10 @@ SLAVE DMA ENGINE
>  SPI
>    devm_spi_register_master()
>  
> +THERMAL
> + devm_thermal_zone_of_sensor_register()
> + devm_thermal_zone_of_sensor_unregister()
> +
>  WATCHDOG
>    devm_watchdog_register_device()
>    devm_watchdog_unregister_device()
> -- 
> 2.1.4
> 

[toc] | [prev] | [next] | [standalone]

#1354336 — Re: [PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620

[Multipart message — attachments visible in raw view] — view raw

Laxman,


On Wed, Mar 09, 2016 at 06:40:04PM +0530, Laxman Dewangan wrote:
> The series add the devm_ version of thermal_zone_of_sensor_register/
> unregister, interface details, and use this in new thermal driver
> for max77620.
> 
> The header file for max77620 is part of MFD patch
> 	https://lkml.org/lkml/2016/2/11/186
> 
> Changes from V1:
> - Run checkpatch with --strict and fix all warnings.
> - Added details of interfaces in spifs-api.txt
> - Added DT binding doc.

Thanks a lot for working on the comments. I don't see anything specific
right now. So, I am starting a couple of automated testing on this
series. If I find something, I will let you know.

[toc] | [prev] | [next] | [standalone]

#1354389 — Re: [PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620

[Multipart message — attachments visible in raw view] — view raw

On Wed, Mar 09, 2016 at 06:40:04PM +0530, Laxman Dewangan wrote:
> The series add the devm_ version of thermal_zone_of_sensor_register/
> unregister, interface details, and use this in new thermal driver
> for max77620.
> 
> The header file for max77620 is part of MFD patch
> 	https://lkml.org/lkml/2016/2/11/186
> 
> Changes from V1:
> - Run checkpatch with --strict and fix all warnings.
> - Added details of interfaces in spifs-api.txt
> - Added DT binding doc.
> 
> Laxman Dewangan (6):
>   thermal: doc: Add details of
>     thermal_zone_of_sensor_{register,unregister}
>   thermal: of-thermal: Add devm version of
>     thermal_zone_of_sensor_register
>   thermal: Add devm_thermal_zone_of_sensor_register() in managed devices
>     list
>   thermal: doc: Add details of
>     devm_thermal_zone_of_sensor_{register,unregister}
>   thermal: max77620: Add thermal driver for reporting junction temp
>   thermal: Add DT binding doc for thermal of PMIC max77620


Add patches 1-3 in my tree. Patch 4 should probably go via documentation
tree. And patch 5 needs dependency to be sorted, and 6 need minor changes.

[toc] | [prev] | [next] | [standalone]

#1354888 — Re: [PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620

On Thursday 10 March 2016 01:02 AM, Eduardo Valentin wrote:
> * PGP Signed by an unknown key
>
> On Wed, Mar 09, 2016 at 06:40:04PM +0530, Laxman Dewangan wrote:
>> The series add the devm_ version of thermal_zone_of_sensor_register/
>> unregister, interface details, and use this in new thermal driver
>> for max77620.
>>
>> The header file for max77620 is part of MFD patch
>> 	https://lkml.org/lkml/2016/2/11/186
>>
>> Changes from V1:
>> - Run checkpatch with --strict and fix all warnings.
>> - Added details of interfaces in spifs-api.txt
>> - Added DT binding doc.
>>
>> Laxman Dewangan (6):
>>    thermal: doc: Add details of
>>      thermal_zone_of_sensor_{register,unregister}
>>    thermal: of-thermal: Add devm version of
>>      thermal_zone_of_sensor_register
>>    thermal: Add devm_thermal_zone_of_sensor_register() in managed devices
>>      list
>>    thermal: doc: Add details of
>>      devm_thermal_zone_of_sensor_{register,unregister}
>>    thermal: max77620: Add thermal driver for reporting junction temp
>>    thermal: Add DT binding doc for thermal of PMIC max77620
>
> Add patches 1-3 in my tree. Patch 4 should probably go via documentation
> tree. And patch 5 needs dependency to be sorted, and 6 need minor changes.
>
Thanks for accepting patches.

patch 5 needs mfd patches which is under review. So until that is 
merged, compilation will fail due to header dependency.

Will add complete information on example of patch 6.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web