Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1354086 > unrolled thread

Re: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early: Squelch frame size warning

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early:  Squelch frame size warning Ingo Molnar <mingo@kernel.org> - 2016-03-09 13:50 +0100
    Re: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early:  Squelch frame size warning Borislav Petkov <bp@alien8.de> - 2016-03-09 14:50 +0100
      [PATCH] x86/i386-defconfig: Set CONFIG_FRAME_WARN to Kconfig default Borislav Petkov <bp@alien8.de> - 2016-03-09 14:50 +0100
        [tip:x86/build] x86/defconfigs/32: Set CONFIG_FRAME_WARN to the  Kconfig default tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-03-09 15:00 +0100

#1354086 — Re: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early: Squelch frame size warning

* Borislav Petkov <bp@alien8.de> wrote:

> On Thu, Jan 07, 2016 at 07:59:56AM -0700, tim.gardner@canonical.com wrote:
> > From: Tim Gardner <tim.gardner@canonical.com>
> > 
> > arch/x86/kernel/cpu/microcode/intel.c: In function 'save_mc_for_early':
> > arch/x86/kernel/cpu/microcode/intel.c:516:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> Ok, so this looks like a 32-bit warning to me.
> 
> Hmm, so, on the one hand we do have:
> 
> $ git grep CONFIG_FRAME_WARN arch/x86/
> arch/x86/configs/i386_defconfig:291:CONFIG_FRAME_WARN=2048
> 
> which came in with:
> 
> 5cb04df8d3f0 ("x86: defconfig updates")
> 
> and OTOH:
> 
> config FRAME_WARN
>         int "Warn for stack frames larger than (needs gcc 4.4)"
>         range 0 8192
>         default 0 if KASAN
>         default 1024 if !64BIT
> 		^^^^
> 
>         default 2048 if 64BIT
>         help
>           Tell gcc to warn at build time for stack frames larger than this.
>           Setting this too low will cause a lot of warnings.
>           Setting it to 0 disables the warning.
>           Requires gcc 4.4
> 
> which is still 1024.
> 
> tip guys, maybe it is time to update lib/Kconfig.debug too?

I think we should rather update the 32-bit defconfig? 64-bit stacks are more 
generous, and a 2K stack footprint is pretty extreme on 32-bit I think ...

Thanks,

	Ingo

[toc] | [next] | [standalone]

#1354142

On Wed, Mar 09, 2016 at 01:41:17PM +0100, Ingo Molnar wrote:
> I think we should rather update the 32-bit defconfig? 64-bit stacks
> are more generous, and a 2K stack footprint is pretty extreme on
> 32-bit I think ...

See reply to this message.

With it, i386 defconfig of tip/master builds fine and without warnings
even though relevant stuff is selected:

$ grep -E "(MICROCODE|FRAME_WARN)" .config
CONFIG_MICROCODE=y
CONFIG_MICROCODE_INTEL=y
CONFIG_MICROCODE_AMD=y
CONFIG_MICROCODE_OLD_INTERFACE=y
CONFIG_FRAME_WARN=1024

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [next] | [standalone]

#1354143 — [PATCH] x86/i386-defconfig: Set CONFIG_FRAME_WARN to Kconfig default

Sync it to the Kconfig default for 32-bit.

Signed-off-by: Borislav Petkov <bp@suse.de>
---
 arch/x86/configs/i386_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 028be48c8839..e25a1630320c 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -288,7 +288,7 @@ CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_UTF8=y
 CONFIG_PRINTK_TIME=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
-CONFIG_FRAME_WARN=2048
+CONFIG_FRAME_WARN=1024
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_UNUSED_SYMBOLS is not set
 CONFIG_DEBUG_KERNEL=y
-- 
2.3.5

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [next] | [standalone]

#1354146 — [tip:x86/build] x86/defconfigs/32: Set CONFIG_FRAME_WARN to the Kconfig default

Commit-ID:  8b30a8b3c636a155bab9176ad209964c9c22252d
Gitweb:     http://git.kernel.org/tip/8b30a8b3c636a155bab9176ad209964c9c22252d
Author:     Borislav Petkov <bp@alien8.de>
AuthorDate: Wed, 9 Mar 2016 14:48:21 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 9 Mar 2016 14:53:41 +0100

x86/defconfigs/32: Set CONFIG_FRAME_WARN to the Kconfig default

Sync it to the Kconfig default for 32-bit.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: tim.gardner@canonical.com
Link: http://lkml.kernel.org/r/20160309134821.GD6564@pd.tnic
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/configs/i386_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 028be48..e25a163 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -288,7 +288,7 @@ CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_UTF8=y
 CONFIG_PRINTK_TIME=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
-CONFIG_FRAME_WARN=2048
+CONFIG_FRAME_WARN=1024
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_UNUSED_SYMBOLS is not set
 CONFIG_DEBUG_KERNEL=y

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web