Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1354149 > unrolled thread
| Started by | Mihai Mihalache <mihai.d.mihalache@intel.com> |
|---|---|
| First post | 2016-03-09 15:00 +0100 |
| Last post | 2016-03-10 04:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] regulator: gpio: check return value of of_get_named_gpio Mihai Mihalache <mihai.d.mihalache@intel.com> - 2016-03-09 15:00 +0100
Re: [PATCH] regulator: gpio: check return value of of_get_named_gpio Mark Brown <broonie@kernel.org> - 2016-03-10 04:20 +0100
| From | Mihai Mihalache <mihai.d.mihalache@intel.com> |
|---|---|
| Date | 2016-03-09 15:00 +0100 |
| Subject | [PATCH] regulator: gpio: check return value of of_get_named_gpio |
| Message-ID | <raMOC-cx-25@gated-at.bofh.it> |
At boot time the regulator driver can be initialized before the gpio, in which case the call to of_get_named_gpio will return EPROBE_DEFER. This value is silently passed to regulator_register which will return success, although the gpio is not registered (regulator_ena_gpio_request not called) as the value passed is detected as invalid. The gpio_regulator_probe will therefore succeed with no gpio requested. Signed-off-by: Mihai Mihalache <mihai.d.mihalache@intel.com> Reviewed-by: Hans Holmberg <hans.holmberg@intel.com> --- drivers/regulator/gpio-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 464018d..429294f 100644 --- a/drivers/regulator/gpio-regulator.c +++ b/drivers/regulator/gpio-regulator.c @@ -162,6 +162,8 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np, of_property_read_u32(np, "startup-delay-us", &config->startup_delay); config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0); + if(IS_ERR_VALUE(config->enable_gpio)) + return ERR_PTR(config->enable_gpio); /* Fetch GPIOs. - optional property*/ ret = of_gpio_count(np); -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-03-10 04:20 +0100 |
| Message-ID | <raZiO-Rs-7@gated-at.bofh.it> |
| In reply to | #1354149 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Mar 09, 2016 at 05:50:42AM -0800, Mihai Mihalache wrote: > config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0); > + if(IS_ERR_VALUE(config->enable_gpio)) > + return ERR_PTR(config->enable_gpio); Please follow the kernel coding style - if(.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web