Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1351908 > unrolled thread

[PATCH] arch/microblaze: export isa_io_base to modules

Started byNicolai Stange <nicstange@gmail.com>
First post2016-03-07 20:40 +0100
Last post2016-03-07 21:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] arch/microblaze: export isa_io_base to modules Nicolai Stange <nicstange@gmail.com> - 2016-03-07 20:40 +0100
    Re: [PATCH] arch/microblaze: export isa_io_base to modules Bjorn Helgaas <helgaas@kernel.org> - 2016-03-07 21:40 +0100

#1351908 — [PATCH] arch/microblaze: export isa_io_base to modules

FromNicolai Stange <nicstange@gmail.com>
Date2016-03-07 20:40 +0100
Subject[PATCH] arch/microblaze: export isa_io_base to modules
Message-ID<ra9ay-784-19@gated-at.bofh.it>
As discovered by the kbuild test robot, an allmodconfig build on
microblaze bails out with

  ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
  ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
  ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
  ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
  ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined!
  [... plus dozens more throughout the tree]

Export isa_io_base to modules by means of EXPORT_SYMBOL().

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
 arch/microblaze/pci/pci-common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
index ae838ed..fba7a46 100644
--- a/arch/microblaze/pci/pci-common.c
+++ b/arch/microblaze/pci/pci-common.c
@@ -48,6 +48,8 @@ static int global_phb_number;		/* Global phb counter */
 resource_size_t isa_mem_base;
 
 unsigned long isa_io_base;
+EXPORT_SYMBOL(isa_io_base);
+
 static int pci_bus_count;
 
 struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
-- 
2.7.2

[toc] | [next] | [standalone]


#1351965

FromBjorn Helgaas <helgaas@kernel.org>
Date2016-03-07 21:40 +0100
Message-ID<raa6D-7JQ-25@gated-at.bofh.it>
In reply to#1351908
On Mon, Mar 07, 2016 at 08:29:24PM +0100, Nicolai Stange wrote:
> As discovered by the kbuild test robot, an allmodconfig build on
> microblaze bails out with
> 
>   ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined!
>   [... plus dozens more throughout the tree]
> 
> Export isa_io_base to modules by means of EXPORT_SYMBOL().
> 
> Signed-off-by: Nicolai Stange <nicstange@gmail.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Michal, this was sent to you, so I assume you'll handle it.  Let me
know if you want me to do anything else with it.

> ---
>  arch/microblaze/pci/pci-common.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
> index ae838ed..fba7a46 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -48,6 +48,8 @@ static int global_phb_number;		/* Global phb counter */
>  resource_size_t isa_mem_base;
>  
>  unsigned long isa_io_base;
> +EXPORT_SYMBOL(isa_io_base);
> +
>  static int pci_bus_count;
>  
>  struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
> -- 
> 2.7.2
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web