Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350951 > unrolled thread

Re: Linux 4.4.4 [regression]

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Linux 4.4.4 [regression] Greg KH <gregkh@linuxfoundation.org> - 2016-03-05 18:50 +0100
    Re: Linux 4.4.4 [regression] Jörg-Volker Peetz <jvpeetz@web.de> - 2016-03-06 14:20 +0100
      Re: Linux 4.4.4 [regression] Greg KH <gregkh@linuxfoundation.org> - 2016-03-07 02:20 +0100
        Re: Linux 4.4.4 [regression] Jörg-Volker Peetz <jvpeetz@web.de> - 2016-03-07 15:30 +0100
          Re: Linux 4.4.4 [regression] Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-07 17:30 +0100
            RE: Linux 4.4.4 [regression] "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-03-07 18:10 +0100
              RE: Linux 4.4.4 [regression] "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-03-07 19:10 +0100

#1350951 — Re: Linux 4.4.4 [regression]

On Sat, Mar 05, 2016 at 11:48:45AM +0100, Jörg-Volker Peetz wrote:
> On my HP Pavilion dv7 with hybrid graphics (AMD HD 4200 - AMD 5400) X can't be
> started anymore. When trying to start X with "startx" Xorg freezes to an
> un-killable process before switching to a frame buffer. From another console I'm
> able to kill the xinit process which brings the first console back to the shell
> prompt. I can find nothing relevant in the logs.
> 
> The last few lines in Xorg.0.log are:
> 
> ...
> [    61.007] (==) ModulePath set to "/usr/lib/xorg/modules"
> [    61.007] (II) The server relies on udev to provide the list of input devices.
> 	If no devices become available, reconfigure udev or disable AutoAddDevices.
> [    61.007] (II) Loader magic: 0x5571980cbdc0
> [    61.008] (II) Module ABI versions:
> [    61.008] 	X.Org ANSI C Emulation: 0.4
> [    61.008] 	X.Org Video Driver: 20.0
> [    61.008] 	X.Org XInput driver : 22.1
> [    61.008] 	X.Org Server Extension : 9.0
> [    61.009] (++) using VT number 1
> 
> [    61.009] (EE) systemd-logind: failed to get session: The name
> org.freedesktop.login1 was not provided by any .service files
> [    61.010] (II) xfree86: Adding drm device (/dev/dri/card0)
> [    61.011] (II) xfree86: Adding drm device (/dev/dri/card1)
> 
> which are the same as with 4.4.3. There the log continues with
> 
>  [    65.782] (--) PCI:*(0:1:5:0) 1002:9712:103c:1443 rev 0, Mem @
> 0xd0000000/268435456, 0xf0400000/65536, 0xf0300000/1048576, I/O @ 0x00004000/256
> [    65.782] (--) PCI: (0:2:0:0) 1002:68e0:103c:1443 rev 0, Mem @
> 0xe0000000/268435456, 0xf0200000/131072, I/O @ 0x00003000/256, BIOS @
> 0x????????/131072
> [    65.782] (II) LoadModule: "glx"
> [    65.784] (II) Loading /usr/lib/xorg/modules/extensions/libglx.so
> [    65.801] (II) Module glx: vendor="X.Org Foundation"
> ...
> 
> I attach the config file.

Can you use 'git bisect' between 4.4.3 and 4.4.4 to track down the
offending patch?

thanks,

greg k-h

[toc] | [next] | [standalone]

#1351119

Greg KH wrote on 03/05/16 18:41:
>
> Can you use 'git bisect' between 4.4.3 and 4.4.4 to track down the
> offending patch?
>
> thanks,
>
> greg k-h
>

It's one line of code that freezes X during start on my HP Pavilion dv7 hybrid
graphic (AMD HD 42000 - AMD HD 5400):

# git bisect visualize
commit b36e52c44ce6728824546d8b5f05b844cede96f1
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Tue Nov 24 14:32:44 2015 -0500

drm/radeon: call hpd_irq_event on resume

commit dbb17a21c131eca94eb31136eee9a7fe5aff00d9 upstream.

Need to call this on resume if displays changes during
suspend in order to properly be notified of changes.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Removing the line inserted by this patch from 4.4.4 makes X on my laptop work again.
Just for the records: with the above patch the laptop freezes during shutdown
and has to be switched off by pressing the power button several seconds until
power-off.

Regards,
jvp.

[toc] | [prev] | [next] | [standalone]

#1351236

On Sun, Mar 06, 2016 at 02:18:31PM +0100, Jörg-Volker Peetz wrote:
> Greg KH wrote on 03/05/16 18:41:
> >
> > Can you use 'git bisect' between 4.4.3 and 4.4.4 to track down the
> > offending patch?
> >
> > thanks,
> >
> > greg k-h
> >
> 
> It's one line of code that freezes X during start on my HP Pavilion dv7 hybrid
> graphic (AMD HD 42000 - AMD HD 5400):
> 
> # git bisect visualize
> commit b36e52c44ce6728824546d8b5f05b844cede96f1
> Author: Alex Deucher <alexander.deucher@amd.com>
> Date: Tue Nov 24 14:32:44 2015 -0500
> 
> drm/radeon: call hpd_irq_event on resume
> 
> commit dbb17a21c131eca94eb31136eee9a7fe5aff00d9 upstream.
> 
> Need to call this on resume if displays changes during
> suspend in order to properly be notified of changes.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Removing the line inserted by this patch from 4.4.4 makes X on my laptop work again.
> Just for the records: with the above patch the laptop freezes during shutdown
> and has to be switched off by pressing the power button several seconds until
> power-off.

Ah, good to know.  Alex, any ideas?

Also, does this same problem also happen in 4.5-rc7?  If so, that's
good.  If not, I'm worried that I might have missed a fixup patch
somewhere.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1351631

Greg KH wrote on 03/07/16 02:14:
> On Sun, Mar 06, 2016 at 02:18:31PM +0100, Jörg-Volker Peetz wrote:
>> Greg KH wrote on 03/05/16 18:41:
>>>
>>> Can you use 'git bisect' between 4.4.3 and 4.4.4 to track down the
>>> offending patch?
>>>
>>
>> It's one line of code that freezes X during start on my HP Pavilion dv7 hybrid
>> graphic (AMD HD 42000 - AMD HD 5400):
>>
>> # git bisect visualize
>> commit b36e52c44ce6728824546d8b5f05b844cede96f1
>> Author: Alex Deucher <alexander.deucher@amd.com>
>> Date: Tue Nov 24 14:32:44 2015 -0500
>>
>> drm/radeon: call hpd_irq_event on resume
>>
>> commit dbb17a21c131eca94eb31136eee9a7fe5aff00d9 upstream.
>>
>> Need to call this on resume if displays changes during
>> suspend in order to properly be notified of changes.
>>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> Removing the line inserted by this patch from 4.4.4 makes X on my laptop work again.
>> Just for the records: with the above patch the laptop freezes during shutdown
>> and has to be switched off by pressing the power button several seconds until
>> power-off.
> 
> Ah, good to know.  Alex, any ideas?
> 
> Also, does this same problem also happen in 4.5-rc7?  If so, that's
> good.  If not, I'm worried that I might have missed a fixup patch
> somewhere.
> 
This same problem with X does happen in 4.5-rc7. And removing the line
introduced by patch b36e52c44ce6728824546d8b5f05b844cede96f1 makes X go again on
my laptop.

Best regards,
jvp.

[toc] | [prev] | [next] | [standalone]

#1351763

On Mon, Mar 7, 2016 at 6:20 AM, Jörg-Volker Peetz <jvpeetz@web.de> wrote:
>
> This same problem with X does happen in 4.5-rc7. And removing the line
> introduced by patch b36e52c44ce6728824546d8b5f05b844cede96f1 makes X go again on
> my laptop.

Ok, so that's dbb17a21c131eca94eb31136eee9a7fe5aff00d9 in mainline.

Dave, Alex: that commit makes Jörg-Volker's HP Pavilion dv7 with
hybrid graphics (AMD HD 4200 - AMD 5400) unable to run X. No
suspend/resume in sight, just starting X hangs.

I'd guess it's the "radeon_switcheroo_set_state()" craziness (based on
that hybrid graphics thing), but we need to do something since this is
a regression.

Just revert for now? Or do you have other suggestions for Jörg-Volker to test?

Maybe that call to drm_helper_hpd_irq_event() should be purely in the
real resume path?

Or maybe there is something that the switcheroo code does that just
interacts badly with the code in drm_helper_hpd_irq_event()? Deadlock
on mode_config.mutex or something?

I suspect we just need to revert, but if somebody who knows the code
sees some obvious fix, holler quickly, please.

                        Linus

[toc] | [prev] | [next] | [standalone]

#1351804

[Multipart message — attachments visible in raw view] — view raw

> -----Original Message-----
> From: linus971@gmail.com [mailto:linus971@gmail.com] On Behalf Of Linus
> Torvalds
> Sent: Monday, March 07, 2016 11:21 AM
> To: Jörg-Volker Peetz; Dave Airlie; DRI mailing list
> Cc: Greg KH; Linux Kernel Mailing List; Andrew Morton; stable; lwn@lwn.net;
> Jiri Slaby; Deucher, Alexander
> Subject: Re: Linux 4.4.4 [regression]
> 
> On Mon, Mar 7, 2016 at 6:20 AM, Jörg-Volker Peetz <jvpeetz@web.de>
> wrote:
> >
> > This same problem with X does happen in 4.5-rc7. And removing the line
> > introduced by patch b36e52c44ce6728824546d8b5f05b844cede96f1 makes
> X go again on
> > my laptop.
> 
> Ok, so that's dbb17a21c131eca94eb31136eee9a7fe5aff00d9 in mainline.
> 
> Dave, Alex: that commit makes Jörg-Volker's HP Pavilion dv7 with
> hybrid graphics (AMD HD 4200 - AMD 5400) unable to run X. No
> suspend/resume in sight, just starting X hangs.
> 
> I'd guess it's the "radeon_switcheroo_set_state()" craziness (based on
> that hybrid graphics thing), but we need to do something since this is
> a regression.
> 
> Just revert for now? Or do you have other suggestions for Jörg-Volker to
> test?

Can you attach your dmesg output?

> 
> Maybe that call to drm_helper_hpd_irq_event() should be purely in the
> real resume path?
> 
> Or maybe there is something that the switcheroo code does that just
> interacts badly with the code in drm_helper_hpd_irq_event()? Deadlock
> on mode_config.mutex or something?
> 
> I suspect we just need to revert, but if somebody who knows the code
> sees some obvious fix, holler quickly, please.

Yes, It's probably something related to switcheroo.  Does the attached patch help?

Alex

[toc] | [prev] | [next] | [standalone]

#1351846

> -----Original Message-----
> From: Jörg-Volker Peetz [mailto:jvpeetz@web.de]
> Sent: Monday, March 07, 2016 12:40 PM
> To: Deucher, Alexander; 'Linus Torvalds'; Dave Airlie; DRI mailing list
> Cc: Greg KH; Linux Kernel Mailing List; stable; lwn@lwn.net; Andrew Morton;
> Jiri Slaby
> Subject: Re: Linux 4.4.4 [regression]
> 
> Deucher, Alexander wrote on 03/07/16 17:44:
> >> -----Original Message-----
> >> From: linus971@gmail.com [mailto:linus971@gmail.com] On Behalf Of
> Linus
> >> Torvalds
> >> Sent: Monday, March 07, 2016 11:21 AM
> >> To: Jörg-Volker Peetz; Dave Airlie; DRI mailing list
> >> Cc: Greg KH; Linux Kernel Mailing List; Andrew Morton; stable;
> lwn@lwn.net;
> >> Jiri Slaby; Deucher, Alexander
> >> Subject: Re: Linux 4.4.4 [regression]
> >>
> >> On Mon, Mar 7, 2016 at 6:20 AM, Jörg-Volker Peetz <jvpeetz@web.de>
> >> wrote:
> >>>
> >>> This same problem with X does happen in 4.5-rc7. And removing the line
> >>> introduced by patch b36e52c44ce6728824546d8b5f05b844cede96f1
> makes
> >> X go again on
> >>> my laptop.
> >>
> >> Ok, so that's dbb17a21c131eca94eb31136eee9a7fe5aff00d9 in mainline.
> >>
> >> Dave, Alex: that commit makes Jörg-Volker's HP Pavilion dv7 with
> >> hybrid graphics (AMD HD 4200 - AMD 5400) unable to run X. No
> >> suspend/resume in sight, just starting X hangs.
> >>
> >> I'd guess it's the "radeon_switcheroo_set_state()" craziness (based on
> >> that hybrid graphics thing), but we need to do something since this is
> >> a regression.
> >>
> >> Just revert for now? Or do you have other suggestions for Jörg-Volker to
> >> test?
> >
> > Can you attach your dmesg output?
> >
> I append the dmesg output from 4.5-rc7 (as vacuous as it is) and from my
> running
> system with 4.4.4 without the problematic code line.
> Will try your attached patch next.

Thanks.  The patch won't make any difference in the case of your system.  It looks like you have a muxed system so I suspect what's happening is that one of the display is being reported as connected for both the IGP and the dGPU and then the desktop environment gets confused or there some sort problem in the detect functions since the mux is not switched to the dGPU.  I don't see an easy fix unless Dave has any ideas.  I'd say just revert for now. 

Alex

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web