Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1350205 > unrolled thread

Re: [RFC V4 PATCH] trace: writeback: replace cgroup path to cgroup ino

Started byTejun Heo <tj@kernel.org>
First post2016-03-04 14:00 +0100
Last post2016-03-07 15:10 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RFC V4 PATCH] trace: writeback: replace cgroup path to cgroup  ino Tejun Heo <tj@kernel.org> - 2016-03-04 14:00 +0100
    Re: [RFC V4 PATCH] trace: writeback: replace cgroup path to cgroup  ino "Shi, Yang" <yang.shi@linaro.org> - 2016-03-07 04:40 +0100
      Re: [RFC V4 PATCH] trace: writeback: replace cgroup path to cgroup  ino Steven Rostedt <rostedt@goodmis.org> - 2016-03-07 15:10 +0100

#1350205 — Re: [RFC V4 PATCH] trace: writeback: replace cgroup path to cgroup ino

FromTejun Heo <tj@kernel.org>
Date2016-03-04 14:00 +0100
SubjectRe: [RFC V4 PATCH] trace: writeback: replace cgroup path to cgroup ino
Message-ID<r8XuO-6XQ-1@gated-at.bofh.it>
On Thu, Mar 03, 2016 at 01:08:57AM -0800, Yang Shi wrote:
> commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback
> tracepoints to report cgroup") made writeback tracepoints print out cgroup
> path when CGROUP_WRITEBACK is enabled, but it may trigger the below bug on -rt
> kernel since kernfs_path and kernfs_path_len are called by tracepoints, which
> acquire spin lock that is sleepable on -rt kernel.

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

[toc] | [next] | [standalone]


#1351284

From"Shi, Yang" <yang.shi@linaro.org>
Date2016-03-07 04:40 +0100
Message-ID<r9Ubv-5PK-1@gated-at.bofh.it>
In reply to#1350205
Hi Steven,

Any comment on this one? I'm supposed it will be taken by your tracing tree?

Thanks,
Yang


On 3/4/2016 4:52 AM, Tejun Heo wrote:
> On Thu, Mar 03, 2016 at 01:08:57AM -0800, Yang Shi wrote:
>> commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback
>> tracepoints to report cgroup") made writeback tracepoints print out cgroup
>> path when CGROUP_WRITEBACK is enabled, but it may trigger the below bug on -rt
>> kernel since kernfs_path and kernfs_path_len are called by tracepoints, which
>> acquire spin lock that is sleepable on -rt kernel.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Thanks.
>

[toc] | [prev] | [next] | [standalone]


#1351613

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-03-07 15:10 +0100
Message-ID<ra41c-3Qk-5@gated-at.bofh.it>
In reply to#1351284
On Sun, 6 Mar 2016 19:32:26 -0800
"Shi, Yang" <yang.shi@linaro.org> wrote:

> Hi Steven,
> 
> Any comment on this one? I'm supposed it will be taken by your tracing tree?
> 

Usually trace events go in through their subsystem, but since this one
only touches the include/trace/events/ directory, I could pull it in
too.

-- Steve

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web