Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1351552 > unrolled thread

Re: [PATCH RESEND] 8021q:Add missing statements to switch case in the function, register_vlan_device

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH RESEND] 8021q:Add missing statements to switch case in  the function, register_vlan_device Patrick McHardy <kaber@trash.net> - 2016-03-07 12:40 +0100

#1351552 — Re: [PATCH RESEND] 8021q:Add missing statements to switch case in the function, register_vlan_device

On 06.03, Nicholas Krause wrote:
> This adds the proper snprintf and break statement for formatting
> the vlan_net structure pointer, vn's name using snprintf for if
> the switch case, VLAN_NAME_TYPE_PLUS_VID occurs for this particular
> switch statement inside the function, register_vlan_device.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  net/8021q/vlan.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index 59555f0..91ef50e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -246,8 +246,11 @@ static int register_vlan_device(struct net_device *real_dev, u16 vlan_id)
>  		/* Put our vlan.VID in the name.
>  		 * Name will look like:	 vlan0005
>  		 */
> +		snprintf(name, IFNAMSIZ, "%s%i", real_dev->name, vlan_id);
> +		break;

As the comment indicates, the fall-through is intended like this.

>  	default:
>  		snprintf(name, IFNAMSIZ, "vlan%.4i", vlan_id);
> +		break;
>  	}
>  
>  	new_dev = alloc_netdev(sizeof(struct vlan_dev_priv), name,
> -- 
> 2.1.4
> 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web