Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451371 > unrolled thread

Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

Started byGregory CLEMENT <gregory.clement@free-electrons.com>
First post2016-07-27 18:10 +0200
Last post2016-07-27 18:20 +0200
Articles 2 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-07-27 18:10 +0200
    Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-07-27 18:20 +0200

#1451371 — Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

FromGregory CLEMENT <gregory.clement@free-electrons.com>
Date2016-07-27 18:10 +0200
SubjectRe: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND
Message-ID<rZzzb-1Cb-17@gated-at.bofh.it>
Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
It looks good:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


> ---
>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
> index a18f516..6648a3f 100644
> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
> @@ -182,15 +182,35 @@
>  
>  			nfc: flash@d0000 {
>  				status = "okay";
> -				#address-cells = <1>;
> -				#size-cells = <1>;
> -
>  				num-cs = <1>;
>  				nand-ecc-strength = <4>;
>  				nand-ecc-step-size = <512>;
>  				marvell,nand-keep-config;
>  				marvell,nand-enable-arbiter;
>  				nand-on-flash-bbt;
> +
> +				partitions {
> +					compatible = "fixed-partitions";
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +
> +					partition@0 {
> +						label = "U-Boot";
> +						reg = <0x00000000 0x00800000>;
> +						read-only;
> +					};
> +
> +					partition@800000 {
> +						label = "uImage";
> +						reg = <0x00800000 0x00400000>;
> +						read-only;
> +					};
> +
> +					partition@c00000 {
> +						label = "Root";
> +						reg = <0x00c00000 0x3f400000>;
> +					};
> +				};
>  			};
>  
>  			usb3@f0000 {
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[toc] | [next] | [standalone]


#1451399

FromGregory CLEMENT <gregory.clement@free-electrons.com>
Date2016-07-27 18:20 +0200
Message-ID<rZzIT-1FV-69@gated-at.bofh.it>
In reply to#1451371
Hi,
 
 On mer., juil. 27 2016, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Grzegorz,
>  
>  On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
>
>> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> It looks good:
>
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

And here again the title prefix should be change to:
"ARM: dts: mvebu: a385-db-ap:" also do not forget fo add a commit log.

Thanks,

Gregory

>
>> ---
>>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
>> index a18f516..6648a3f 100644
>> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
>> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
>> @@ -182,15 +182,35 @@
>>  
>>  			nfc: flash@d0000 {
>>  				status = "okay";
>> -				#address-cells = <1>;
>> -				#size-cells = <1>;
>> -
>>  				num-cs = <1>;
>>  				nand-ecc-strength = <4>;
>>  				nand-ecc-step-size = <512>;
>>  				marvell,nand-keep-config;
>>  				marvell,nand-enable-arbiter;
>>  				nand-on-flash-bbt;
>> +
>> +				partitions {
>> +					compatible = "fixed-partitions";
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
>> +
>> +					partition@0 {
>> +						label = "U-Boot";
>> +						reg = <0x00000000 0x00800000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@800000 {
>> +						label = "uImage";
>> +						reg = <0x00800000 0x00400000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@c00000 {
>> +						label = "Root";
>> +						reg = <0x00c00000 0x3f400000>;
>> +					};
>> +				};
>>  			};
>>  
>>  			usb3@f0000 {
>> -- 
>> 1.8.3.1
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web