Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451262 > unrolled thread

Re: [PATCH v1] x86, kasan, ftrace: Put APIC interrupt handlers into .irqentry.text

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v1] x86, kasan, ftrace: Put APIC interrupt handlers into  .irqentry.text Steven Rostedt <rostedt@goodmis.org> - 2016-07-27 14:50 +0200
    Re: [PATCH v1] x86, kasan, ftrace: Put APIC interrupt handlers into  .irqentry.text Steven Rostedt <rostedt@goodmis.org> - 2016-07-27 15:10 +0200

#1451262 — Re: [PATCH v1] x86, kasan, ftrace: Put APIC interrupt handlers into .irqentry.text

On Fri, 15 Jul 2016 17:19:46 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi,
> 
> [auto build test WARNING on tip/x86/core]
> [also build test WARNING on v4.7-rc7 next-20160714]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Alexander-Potapenko/x86-kasan-ftrace-Put-APIC-interrupt-handlers-into-irqentry-text/20160715-152601
> config: x86_64-acpi-redef (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/x86/entry/entry_64.S:674:15: warning: extra tokens at end of #ifdef directive  
>     #ifdef defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_KASAN)

Alexander,

Can you send a v2 with this fixed?

-- Steve

>                   ^
> 
> vim +674 arch/x86/entry/entry_64.S
> 
>    658	END(\sym)
>    659	.endm
>    660	
>    661	#ifdef CONFIG_TRACING
>    662	#define trace(sym) trace_##sym
>    663	#define smp_trace(sym) smp_trace_##sym
>    664	
>    665	.macro trace_apicinterrupt num sym
>    666	apicinterrupt3 \num trace(\sym) smp_trace(\sym)
>    667	.endm
>    668	#else
>    669	.macro trace_apicinterrupt num sym do_sym
>    670	.endm
>    671	#endif
>    672	
>    673	/* Make sure APIC interrupt handlers end up in the irqentry section. */
>  > 674	#ifdef defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_KASAN)  
>    675	#define PUSH_SECTION_IRQENTRY	.pushsection .irqentry.text, "ax"
>    676	#define POP_SECTION_IRQENTRY	.popsection
>    677	#else
>    678	#define PUSH_SECTION_IRQENTRY
>    679	#define POP_SECTION_IRQENTRY
>    680	#endif
>    681	
>    682	.macro apicinterrupt num sym do_sym
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1451264

On Wed, 27 Jul 2016 15:52:08 +0300
Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:

> > Alexander,
> > 
> > Can you send a v2 with this fixed?
> >   
> 
> He did - http://lkml.kernel.org/g/<1468575763-144889-1-git-send-email-glider@google.com>
> 

Bah, you're right. I never marked that patch as "todo" and was
searching for a v2 with my "todo" filter on, so I missed it.

Sorry for the noise.

-- Steve

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web