Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451096 > unrolled thread

RE: [PATCH v4 5/7] thunderbolt: Networking state machine

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [PATCH v4 5/7] thunderbolt: Networking state machine "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-27 09:40 +0200

#1451096 — RE: [PATCH v4 5/7] thunderbolt: Networking state machine

On Mon, Jul 25 2016, 01:36 AM, Lukas Wunner wrote:
> On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote:
> > +	const unique_id_be proto_uuid =
> APPLE_THUNDERBOLT_IP_PROTOCOL_UUID;
> > +
> > +	if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid,
> > +		   sizeof(proto_uuid)) != 0) {
> 
> You may want to use the uuid_be data type provided by <linux/uuid.h>
> instead of rolling your own, as well as the helper uuid_be_cmp() defined
> ibidem.
> 

All the messages in Thunderbolt consist BE DWORDs.
I didn't find uuid definition in the kernel that accurately describes the uuid structure in the messages, which is 4 BE DWORDs.
But on the other hand, all the driver does is copy/compare of uuids, and it can treat uuids as byte array (i.e. uuid_be).
I'll change it in the next patches.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web