Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450538 > unrolled thread
| Started by | James Morris <jmorris@namei.org> |
|---|---|
| First post | 2016-07-26 13:40 +0200 |
| Last post | 2016-07-26 19:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling James Morris <jmorris@namei.org> - 2016-07-26 13:40 +0200
Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling John Johansen <john.johansen@canonical.com> - 2016-07-26 19:00 +0200
| From | James Morris <jmorris@namei.org> |
|---|---|
| Date | 2016-07-26 13:40 +0200 |
| Subject | Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling |
| Message-ID | <rZ8Sm-1mU-15@gated-at.bofh.it> |
On Mon, 25 Jul 2016, John Johansen wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added Kconfig option could never work and just causes a build error
> when disabled:
>
> security/apparmor/lsm.c:675:25: error: 'CONFIG_SECURITY_APPARMOR_HASH_DEFAULT' undeclared here (not in a function)
> bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;
>
> The problem is that the macro undefined in this case, and we need to use the IS_ENABLED()
> helper to turn it into a boolean constant.
>
> Another minor problem with the original patch is that the option is even offered
> in sysfs when SECURITY_APPARMOR_HASH is not enabled, so this also hides the option
> in that case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6059f71f1e94 ("apparmor: add parameter to control whether policy hashing is used")
> Signed-off-by: John Johansen <john.johansen@canonical.com>
Please rebase this against current Linus.
--
James Morris
<jmorris@namei.org>
[toc] | [next] | [standalone]
| From | John Johansen <john.johansen@canonical.com> |
|---|---|
| Date | 2016-07-26 19:00 +0200 |
| Message-ID | <rZdS2-4t5-15@gated-at.bofh.it> |
| In reply to | #1450538 |
On 07/26/2016 04:38 AM, James Morris wrote:
> On Mon, 25 Jul 2016, John Johansen wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The newly added Kconfig option could never work and just causes a build error
>> when disabled:
>>
>> security/apparmor/lsm.c:675:25: error: 'CONFIG_SECURITY_APPARMOR_HASH_DEFAULT' undeclared here (not in a function)
>> bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;
>>
>> The problem is that the macro undefined in this case, and we need to use the IS_ENABLED()
>> helper to turn it into a boolean constant.
>>
>> Another minor problem with the original patch is that the option is even offered
>> in sysfs when SECURITY_APPARMOR_HASH is not enabled, so this also hides the option
>> in that case.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 6059f71f1e94 ("apparmor: add parameter to control whether policy hashing is used")
>> Signed-off-by: John Johansen <john.johansen@canonical.com>
>
> Please rebase this against current Linus.
>
Well this is a fix for a patch in the security next queue, so linus doesn't
have it yet. I can wait for your 4.8 pull request and rebase then
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web