Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450565 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-07-26 14:30 +0200 |
| Last post | 2016-07-26 23:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] lkdtm: fix maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-07-26 14:30 +0200
Re: [PATCH] lkdtm: fix maybe-uninitialized warning Kees Cook <keescook@chromium.org> - 2016-07-26 17:30 +0200
Re: [PATCH] lkdtm: fix maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-07-26 23:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-26 14:30 +0200 |
| Subject | [PATCH] lkdtm: fix maybe-uninitialized warning |
| Message-ID | <rZ9EJ-1T0-15@gated-at.bofh.it> |
The do_usercopy_stack() function uses uninitialized stack data to initialize
more of the stack, which causes a warning in some configurations (ARM allmodconfig):
drivers/misc/lkdtm_usercopy.c:52:15: warning: 'bad_stack' may be used uninitialized in this function [-Wmaybe-uninitialized]
The warning gets reports by Mark Brown's build bot and looks correct (we are trying
to trick the compiler here, and sometimes the compiler notices), and I could reproduce
it with gcc-4.7 through gcc-5.3 but not gcc-6.1 for some reason.
This changes the code to use the low byte of the address of the stack to initialize
the stack data, instead of using data from the stack itself, to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: a3dff71c1c88 ("lkdtm: split usercopy tests to separate file")
---
drivers/misc/lkdtm_usercopy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/lkdtm_usercopy.c b/drivers/misc/lkdtm_usercopy.c
index 5a3fd76eec27..5525a204db93 100644
--- a/drivers/misc/lkdtm_usercopy.c
+++ b/drivers/misc/lkdtm_usercopy.c
@@ -49,7 +49,7 @@ static noinline void do_usercopy_stack(bool to_user, bool bad_frame)
/* This is a pointer to outside our current stack frame. */
if (bad_frame) {
- bad_stack = do_usercopy_stack_callee((uintptr_t)bad_stack);
+ bad_stack = do_usercopy_stack_callee((uintptr_t)&bad_stack);
} else {
/* Put start address just inside stack. */
bad_stack = task_stack_page(current) + THREAD_SIZE;
--
2.9.0
[toc] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-07-26 17:30 +0200 |
| Message-ID | <rZcsW-3C5-13@gated-at.bofh.it> |
| In reply to | #1450565 |
On Tue, Jul 26, 2016 at 5:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The do_usercopy_stack() function uses uninitialized stack data to initialize
> more of the stack, which causes a warning in some configurations (ARM allmodconfig):
>
> drivers/misc/lkdtm_usercopy.c:52:15: warning: 'bad_stack' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> The warning gets reports by Mark Brown's build bot and looks correct (we are trying
> to trick the compiler here, and sometimes the compiler notices), and I could reproduce
> it with gcc-4.7 through gcc-5.3 but not gcc-6.1 for some reason.
>
> This changes the code to use the low byte of the address of the stack to initialize
> the stack data, instead of using data from the stack itself, to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a3dff71c1c88 ("lkdtm: split usercopy tests to separate file")
Acked-by: Kees Cook <keescook@chromium.org>
I thought I already sent this fix to Greg? Maybe it got lost...
-Kees
> ---
> drivers/misc/lkdtm_usercopy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm_usercopy.c b/drivers/misc/lkdtm_usercopy.c
> index 5a3fd76eec27..5525a204db93 100644
> --- a/drivers/misc/lkdtm_usercopy.c
> +++ b/drivers/misc/lkdtm_usercopy.c
> @@ -49,7 +49,7 @@ static noinline void do_usercopy_stack(bool to_user, bool bad_frame)
>
> /* This is a pointer to outside our current stack frame. */
> if (bad_frame) {
> - bad_stack = do_usercopy_stack_callee((uintptr_t)bad_stack);
> + bad_stack = do_usercopy_stack_callee((uintptr_t)&bad_stack);
> } else {
> /* Put start address just inside stack. */
> bad_stack = task_stack_page(current) + THREAD_SIZE;
> --
> 2.9.0
>
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-26 23:00 +0200 |
| Message-ID | <rZhCh-6Qe-11@gated-at.bofh.it> |
| In reply to | #1450652 |
On Tuesday, July 26, 2016 8:21:37 AM CEST Kees Cook wrote:
> On Tue, Jul 26, 2016 at 5:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The do_usercopy_stack() function uses uninitialized stack data to initialize
> > more of the stack, which causes a warning in some configurations (ARM allmodconfig):
> >
> > drivers/misc/lkdtm_usercopy.c:52:15: warning: 'bad_stack' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >
> > The warning gets reports by Mark Brown's build bot and looks correct (we are trying
> > to trick the compiler here, and sometimes the compiler notices), and I could reproduce
> > it with gcc-4.7 through gcc-5.3 but not gcc-6.1 for some reason.
> >
> > This changes the code to use the low byte of the address of the stack to initialize
> > the stack data, instead of using data from the stack itself, to avoid the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: a3dff71c1c88 ("lkdtm: split usercopy tests to separate file")
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> I thought I already sent this fix to Greg?
Possible. I mentioned the problem to you when it first showed up,
but noticed today that I didn't have a patch for it in my testing
tree (since I test with gcc-6.1, which doesn't show the bug).
> Maybe it got lost...
More likely that it's still in his backlog then.
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web