Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451627 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-07-28 04:20 +0200 |
| Last post | 2016-07-28 13:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Wei Yongjun <weiyj.lk@gmail.com> - 2016-07-28 04:20 +0200
Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Brian Starkey <brian.starkey@arm.com> - 2016-07-28 10:30 +0200
Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Daniel Vetter <daniel@ffwll.ch> - 2016-07-28 13:10 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-07-28 04:20 +0200 |
| Subject | [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() |
| Message-ID | <rZJ5v-870-5@gated-at.bofh.it> |
Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
instead of the endpoint')
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 4e61ea5..44b24cb 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
/* Set the CRTC's port so that the encoder component can find it */
ep = of_graph_get_next_endpoint(dev->of_node, NULL);
- if (!ep)
+ if (!ep) {
+ ret = -EINVAL;
goto port_fail;
+ }
malidp->crtc.port = of_get_next_parent(ep);
ret = component_bind_all(dev, drm);
[toc] | [next] | [standalone]
| From | Brian Starkey <brian.starkey@arm.com> |
|---|---|
| Date | 2016-07-28 10:30 +0200 |
| Subject | Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() |
| Message-ID | <rZORz-3Ef-15@gated-at.bofh.it> |
| In reply to | #1451627 |
Hi Wei,
On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
>Fix to return error code -EINVAL from the error handling
>case instead of 0, as done elsewhere in this function.
>
>Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
>instead of the endpoint')
>Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>---
Thanks for cleaning up after me! :-)
Acked-by: Brian Starkey <brian.starkey@arm.com>
@Sean, can you pick this up on top of 3c31760e760c?
Cheers,
Brian
> drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
>index 4e61ea5..44b24cb 100644
>--- a/drivers/gpu/drm/arm/malidp_drv.c
>+++ b/drivers/gpu/drm/arm/malidp_drv.c
>@@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
>
> /* Set the CRTC's port so that the encoder component can find it */
> ep = of_graph_get_next_endpoint(dev->of_node, NULL);
>- if (!ep)
>+ if (!ep) {
>+ ret = -EINVAL;
> goto port_fail;
>+ }
> malidp->crtc.port = of_get_next_parent(ep);
>
> ret = component_bind_all(dev, drm);
>
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2016-07-28 13:10 +0200 |
| Subject | Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() |
| Message-ID | <rZRmp-5r9-17@gated-at.bofh.it> |
| In reply to | #1451797 |
On Thu, Jul 28, 2016 at 09:22:21AM +0100, Brian Starkey wrote:
> Hi Wei,
>
> On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
> > Fix to return error code -EINVAL from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
> > instead of the endpoint')
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> > ---
>
> Thanks for cleaning up after me! :-)
>
> Acked-by: Brian Starkey <brian.starkey@arm.com>
Applied to drm-misc, thanks.
-Daniel
>
> @Sean, can you pick this up on top of 3c31760e760c?
>
> Cheers,
> Brian
>
> > drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..44b24cb 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
> >
> > /* Set the CRTC's port so that the encoder component can find it */
> > ep = of_graph_get_next_endpoint(dev->of_node, NULL);
> > - if (!ep)
> > + if (!ep) {
> > + ret = -EINVAL;
> > goto port_fail;
> > + }
> > malidp->crtc.port = of_get_next_parent(ep);
> >
> > ret = component_bind_all(dev, drm);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web