Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451635 > unrolled thread

[GIT PULL] binfmt_misc updates for 4.7+ merge window

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] binfmt_misc updates for 4.7+ merge window James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-07-28 04:40 +0200
    Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Joe Perches <joe@perches.com> - 2016-07-28 05:00 +0200
      Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 05:20 +0200
        Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 05:30 +0200
          Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Joe Perches <joe@perches.com> - 2016-07-28 05:40 +0200
            Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-07-28 13:10 +0200
          Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 05:40 +0200
            Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 05:40 +0200
              Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Joe Perches <joe@perches.com> - 2016-07-28 06:00 +0200
        Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Joe Perches <joe@perches.com> - 2016-07-28 05:30 +0200
        Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window Joe Perches <joe@perches.com> - 2016-07-28 05:30 +0200

#1451635 — [GIT PULL] binfmt_misc updates for 4.7+ merge window

First off, the intention of this pull is to declare that I'll be the
binfmt_misc maintainer (mainly on the grounds of you touched it last,
it's yours).  There's no MAINTAINERS entry, but get_maintainers.pl will
now finger me.

The update itself is to allow architecture emulation containers to
function such that the emulation binary can be housed outside the
container itself.  The container and fs parts both have acks from
relevant experts.

The change is user visible. To use the new feature you have to add an F
option to your binfmt_misc configuration.  However, the existing tools,
like systemd-binfmt work with this without modification.

It's also all been incubated in linux-next for over a month.

The update is available here:

git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git binfmt-for-linus

The short changelog is:

James Bottomley (3):
      binfmt_misc: add F option description to documentation
      binfmt_misc: add persistent opened binary handler for containers
      fs: add filp_clone_open API

And the diffstat:

 Documentation/binfmt_misc.txt |  7 +++++++
 fs/binfmt_misc.c              | 41 +++++++++++++++++++++++++++++++++++++++--
 fs/internal.h                 |  1 +
 fs/open.c                     | 20 ++++++++++++++++++++
 4 files changed, 67 insertions(+), 2 deletions(-)

James

[toc] | [next] | [standalone]

#1451651

On Wed, 2016-07-27 at 22:31 -0400, James Bottomley wrote:
> First off, the intention of this pull is to declare that I'll be the
> binfmt_misc maintainer (mainly on the grounds of you touched it last,
> it's yours).  There's no MAINTAINERS entry, but get_maintainers.pl will
> now finger me.

No, it will not finger you.
Not by default, not without a MAINTAINERS entry.

It'll continue to list only Al Viro unless a --git cmdline option
is specified and almost no one uses that.

[toc] | [prev] | [next] | [standalone]

#1451684

On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
>
> It'll continue to list only Al Viro unless a --git cmdline option
> is specified and almost no one uses that.

Did you actually try it.

The get_maintainer.pl script should use "--git-fallback" by default,
so in the absence of a an exact match (which it won't have) it _will_
in fact pick out recent git authorship.

(Where "recent" means "in the last year" by default).

I depend that recent authorship matching quite a lot. In fact, I think
the reason nobody uses "--git" is that the default "--git-fallback" is
sufficient most of the time.

                Linus

[toc] | [prev] | [next] | [standalone]

#1451687

On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
>> Did you actually try it.
>
> yes.

Well, in that case the script is buggy. It self-documents as having
"--git-fallback" on by default, and I'm not seeing anybody claiming
explicit maintenance of fs/binfmt_misc.c.

Al's match comes from a wildcard, not an exact one.

Hmm. Fishy.

             Linus

[toc] | [prev] | [next] | [standalone]

#1451691

On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com> wrote:
> > 
> > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > > 
> > > Did you actually try it.
> > yes.
> Well, in that case the script is buggy. It self-documents as having
> "--git-fallback" on by default, and I'm not seeing anybody claiming
> explicit maintenance of fs/binfmt_misc.c.
> 
> Al's match comes from a wildcard, not an exact one.

Nope, the script doesn't have a defect here.
It's documented what the script does with wildcards.

You _could_ argue that the file pattern specified
for VFS is inappropriate though,

[toc] | [prev] | [next] | [standalone]

#1451879

On Wed, 2016-07-27 at 20:30 -0700, Joe Perches wrote:
> On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> > On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com>
> > wrote:
> > > 
> > > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > > > 
> > > > Did you actually try it.
> > > yes.
> > Well, in that case the script is buggy. It self-documents as having
> > "--git-fallback" on by default, and I'm not seeing anybody claiming
> > explicit maintenance of fs/binfmt_misc.c.
> > 
> > Al's match comes from a wildcard, not an exact one.
> 
> Nope, the script doesn't have a defect here.
> It's documented what the script does with wildcards.
> 
> You _could_ argue that the file pattern specified
> for VFS is inappropriate though,

If people prefer, I can add a MAINTAINERS entry ... it's just that none
of the binfmts currently has one, plus linux-fsdevel is still fingered
as the list and that's the place to send patches and bug reports
anyway.

James

[toc] | [prev] | [next] | [standalone]

#1451693

On Wed, Jul 27, 2016 at 8:26 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Hmm. Fishy.

Hmm. The exact match logic is a bit odd, and clearly doesn't mean what
I thought it meant. Reading that perl code just makes me more
confused.

I'd actually prefer to make "--git" the default, if you are inside a
git repository. Because obviously the *actual* default is too hard to
understand ;)

               Linus

[toc] | [prev] | [next] | [standalone]

#1451697

On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I'd actually prefer to make "--git" the default, if you are inside a
> git repository. Because obviously the *actual* default is too hard to
> understand ;)

I'd also like to make the "-f" optional.

I constantly forget it, and curse it. It should be trivial to see "the
argument is a file that is tracked in git, so it clearly isn't the
name of a patch".

               Linus

[toc] | [prev] | [next] | [standalone]

#1451705

On Wed, 2016-07-27 at 20:33 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > I'd actually prefer to make "--git" the default, if you are inside a
> > git repository. Because obviously the *actual* default is too hard to
> > understand ;)

Well, you are in the minority there.

Most people seem not to want to be cc'd on stuff they may have
sent an odd patch on but don't actually maintain.

You could create a .get_maintainer.conf file and add --git
to it if you want that.

> I'd also like to make the "-f" optional.
> 
> I constantly forget it, and curse it. It should be trivial to see "the
> argument is a file that is tracked in git, so it clearly isn't the
> name of a patch".

You could send a patch ;)

I'll look at it in any case.

[toc] | [prev] | [next] | [standalone]

#1451688

On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
> > 
> > 
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.

yes.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c 
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS
and infrastructure))
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel@vger.kernel.org (open list)
joe@XPS-9350:~/linux/next$ ./scripts/get_maintainer.pl -f
fs/binfmt_misc.c --git
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS
and
infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49
=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley@HansenPartnership.com>
(commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_li
nes:2/16=12%)
Serge Hallyn <serge.hallyn@canonical.com> (commit_signer:1/3=33%)
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel@vger.kernel.org (open list)

> The get_maintainer.pl script should use "--git-fallback" by default,
> so in the absence of a an exact match (which it won't have) it _will_
> in fact pick out recent git authorship.
> 
> (Where "recent" means "in the last year" by default).
> 
> I depend that recent authorship matching quite a lot. In fact, I think
> the reason nobody uses "--git" is that the default "--git-fallback" is
> sufficient most of the time.
> 
>                 Linus

[toc] | [prev] | [next] | [standalone]

#1451689

On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.

Sorry about the last reply, typing with a broken arm is a bit difficult.

Yes.  I gather you did not.

The VFS MAINTAINERS entry is:

FILESYSTEMS (VFS and infrastructure)
M:	Alexander Viro <viro@zeniv.linux.org.uk>
L:	linux-fsdevel@vger.kernel.org
S:	Maintained
F:	fs/*

so that matches this file location.

$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c 
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS and infrastructure))
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel@vger.kernel.org (open list)
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c --git
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS and infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley@HansenPartnership.com> (commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_lines:2/16=12%)
Serge Hallyn <serge.hallyn@canonical.com> (commit_signer:1/3=33%)
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel@vger.kernel.org (open list)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web