Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451067 > unrolled thread

Re: linux-next: build warnings after merge of the libata tree

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: linux-next: build warnings after merge of the libata tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-27 08:40 +0200
    Re: linux-next: build warnings after merge of the libata tree Tejun Heo <tj@kernel.org> - 2016-07-27 19:40 +0200

#1451067 — Re: linux-next: build warnings after merge of the libata tree

Hi Tejun,

On Thu, 21 Jul 2016 10:44:59 -0400 Tejun Heo <tj@kernel.org> wrote:
>
> On Thu, Jul 21, 2016 at 03:26:03PM +1000, Stephen Rothwell wrote:
> > Hi Tejun,
> > 
> > After merging the libata tree, today's linux-next build (arm
> > multi_v7_defconfig) produced these warning:
> > 
> > drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> > drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> >     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> >                             ^
> > drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> > drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> >     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> >                             ^
> > 
> > Introduced by commit
> > 
> >   9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()")  
> 
> Already reverted the patch.  Sorry about that.

This patch is still in the libata tree
(git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git#for-next)
-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1451432

On Wed, Jul 27, 2016 at 04:32:31PM +1000, Stephen Rothwell wrote:
> This patch is still in the libata tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git#for-next)

Oops, forgot to revert for-next.  Fixed up now.

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web