Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1449317 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-07-25 09:10 +0200 |
| Last post | 2016-07-26 09:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] rtc: at91sam9: Fix missing spin_lock_init() Wei Yongjun <weiyj.lk@gmail.com> - 2016-07-25 09:10 +0200
Re: [PATCH -next] rtc: at91sam9: Fix missing spin_lock_init() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-26 09:50 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-07-25 09:10 +0200 |
| Subject | [PATCH -next] rtc: at91sam9: Fix missing spin_lock_init() |
| Message-ID | <rYIbw-1BM-15@gated-at.bofh.it> |
The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> --- drivers/rtc/rtc-at91sam9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c index 99732e6..7418a76 100644 --- a/drivers/rtc/rtc-at91sam9.c +++ b/drivers/rtc/rtc-at91sam9.c @@ -375,6 +375,7 @@ static int at91_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; + spin_lock_init(&rtc->lock); rtc->irq = irq; /* platform setup code should have handled this; sigh */
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-07-26 09:50 +0200 |
| Message-ID | <rZ5hL-7Cz-7@gated-at.bofh.it> |
| In reply to | #1449317 |
On 25/07/2016 at 07:05:11 +0000, Wei Yongjun wrote : > The driver allocates the spinlock but not initialize it. > Use spin_lock_init() on it to initialize it correctly. > > This is detected by Coccinelle semantic patch. > > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> > --- > drivers/rtc/rtc-at91sam9.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web