Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445612 > unrolled thread

[PATCH] power:bq27xxx: 27000/10 read FLAGS register as single

Started by"H. Nikolaus Schaller" <hns@goldelico.com>
First post2016-07-18 18:20 +0200
Last post2016-07-26 15:10 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-18 18:20 +0200
    Re: [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-26 08:10 +0200
    Re: [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single Pali Rohár <pali.rohar@gmail.com> - 2016-07-26 09:30 +0200
    Re: [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single "Andrew F. Davis" <afd@ti.com> - 2016-07-26 15:10 +0200

#1445612 — [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single

From"H. Nikolaus Schaller" <hns@goldelico.com>
Date2016-07-18 18:20 +0200
Subject[PATCH] power:bq27xxx: 27000/10 read FLAGS register as single
Message-ID<rWjqV-8vS-17@gated-at.bofh.it>
The bq27000 and bq27010 have a single byte FLAGS register.
Other gauges have 16 bit FLAGS registers.

For reading the FLAGS register it is sufficient to read the single
register instead of reading RSOC at the next higher address as
well and then ignore the high byte.

This does not change functionality but optimizes i2c and hdq
traffic.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 drivers/power/bq27xxx_battery.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index 45f6ebf..56712b2 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -656,8 +656,9 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
 static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
 {
 	int flags;
+	bool has_singe_flag = di->chip == BQ27000 || di->chip == BQ27010;
 
-	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
+	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, has_singe_flag);
 	if (flags < 0) {
 		dev_err(di->dev, "error reading flag register:%d\n", flags);
 		return flags;
@@ -760,7 +761,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,
 	}
 
 	if (di->chip == BQ27000 || di->chip == BQ27010) {
-		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
+		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, true);
 		if (flags & BQ27000_FLAG_CHGS) {
 			dev_dbg(di->dev, "negative current!\n");
 			curr = -curr;
-- 
2.7.3

[toc] | [next] | [standalone]

#1450387

From"H. Nikolaus Schaller" <hns@goldelico.com>
Date2016-07-26 08:10 +0200
Message-ID<rZ3IZ-6QU-3@gated-at.bofh.it>
In reply to#1445612
ping

> Am 18.07.2016 um 18:12 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
> 
> The bq27000 and bq27010 have a single byte FLAGS register.
> Other gauges have 16 bit FLAGS registers.
> 
> For reading the FLAGS register it is sufficient to read the single
> register instead of reading RSOC at the next higher address as
> well and then ignore the high byte.
> 
> This does not change functionality but optimizes i2c and hdq
> traffic.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/power/bq27xxx_battery.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 45f6ebf..56712b2 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -656,8 +656,9 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
> static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
> {
> 	int flags;
> +	bool has_singe_flag = di->chip == BQ27000 || di->chip == BQ27010;
> 
> -	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
> +	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, has_singe_flag);
> 	if (flags < 0) {
> 		dev_err(di->dev, "error reading flag register:%d\n", flags);
> 		return flags;
> @@ -760,7 +761,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,
> 	}
> 
> 	if (di->chip == BQ27000 || di->chip == BQ27010) {
> -		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
> +		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, true);
> 		if (flags & BQ27000_FLAG_CHGS) {
> 			dev_dbg(di->dev, "negative current!\n");
> 			curr = -curr;
> -- 
> 2.7.3
>

[toc] | [prev] | [next] | [standalone]

#1450435

FromPali Rohár <pali.rohar@gmail.com>
Date2016-07-26 09:30 +0200
Message-ID<rZ4Yp-7w9-3@gated-at.bofh.it>
In reply to#1445612
On Monday 18 July 2016 18:12:09 H. Nikolaus Schaller wrote:
> The bq27000 and bq27010 have a single byte FLAGS register.
> Other gauges have 16 bit FLAGS registers.
> 
> For reading the FLAGS register it is sufficient to read the single
> register instead of reading RSOC at the next higher address as
> well and then ignore the high byte.
> 
> This does not change functionality but optimizes i2c and hdq
> traffic.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Looks good, add my Acked-by.

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1450593

From"Andrew F. Davis" <afd@ti.com>
Date2016-07-26 15:10 +0200
Message-ID<rZahr-2lS-3@gated-at.bofh.it>
In reply to#1445612
On 07/18/2016 11:12 AM, H. Nikolaus Schaller wrote:
> The bq27000 and bq27010 have a single byte FLAGS register.
> Other gauges have 16 bit FLAGS registers.
> 
> For reading the FLAGS register it is sufficient to read the single
> register instead of reading RSOC at the next higher address as
> well and then ignore the high byte.
> 
> This does not change functionality but optimizes i2c and hdq
> traffic.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---

Matches the datasheet,

Acked-by: Andrew F. Davis <afd@ti.com>

>  drivers/power/bq27xxx_battery.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 45f6ebf..56712b2 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -656,8 +656,9 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
>  static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
>  {
>  	int flags;
> +	bool has_singe_flag = di->chip == BQ27000 || di->chip == BQ27010;
>  
> -	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
> +	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, has_singe_flag);
>  	if (flags < 0) {
>  		dev_err(di->dev, "error reading flag register:%d\n", flags);
>  		return flags;
> @@ -760,7 +761,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,
>  	}
>  
>  	if (di->chip == BQ27000 || di->chip == BQ27010) {
> -		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
> +		flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, true);
>  		if (flags & BQ27000_FLAG_CHGS) {
>  			dev_dbg(di->dev, "negative current!\n");
>  			curr = -curr;
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web