Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1449089 > unrolled thread

[PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue

Started byNadim almas <nadim.902@gmail.com>
First post2016-07-24 09:40 +0200
Last post2016-07-24 22:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue Nadim almas <nadim.902@gmail.com> - 2016-07-24 09:40 +0200
    Re: [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character  line limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-07-24 22:50 +0200

#1449089 — [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue

FromNadim almas <nadim.902@gmail.com>
Date2016-07-24 09:40 +0200
Subject[PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue
Message-ID<rYmaZ-57g-1@gated-at.bofh.it>
From: sarique <nadim.902@gmail.com>

fixed a coding style issue.

Signed-off-by: Nadim almas <nadim.902@gmail.com.com>
---
 drivers/staging/android/ion/ion.c        | 3 ++-
 drivers/staging/comedi/drivers/ssv_dnp.c | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index a2cf93b..52345df 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1358,7 +1358,8 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 		struct ion_handle *handle;
 
 		mutex_lock(&client->lock);
-		handle = ion_handle_get_by_id_nolock(client, data.handle.handle);
+		handle = ion_handle_get_by_id_nolock(client,
+data.handle.handle);
 		if (IS_ERR(handle)) {
 			mutex_unlock(&client->lock);
 			return PTR_ERR(handle);
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging/comedi/drivers/ssv_dnp.c
index f9f634f..5674427 100644
--- a/drivers/staging/comedi/drivers/ssv_dnp.c
+++ b/drivers/staging/comedi/drivers/ssv_dnp.c
@@ -121,9 +121,9 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
 	}
 
 	val = inb(CSCDR);
-	if (data[0] == COMEDI_OUTPUT)
+	if (data[0] == COMEDI_OUTPUT) 
 		val |= mask;
-	else
+	 else
 		val &= ~mask;
 	outb(val, CSCDR);
 
-- 
2.7.4

[toc] | [next] | [standalone]


#1449205 — Re: [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-07-24 22:50 +0200
SubjectRe: [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue
Message-ID<rYyvw-40h-7@gated-at.bofh.it>
In reply to#1449089
On Sun, Jul 24, 2016 at 12:37:31AM -0700, Nadim almas wrote:
> From: sarique <nadim.902@gmail.com>
> 
> fixed a coding style issue.

What issue?

> 
> Signed-off-by: Nadim almas <nadim.902@gmail.com.com>

Your From: and signed-off-by names do not match up :(

And where are the other 31 patches in this series?

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web