Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449100 > unrolled thread

[PATCH] libnvdimm-btt: Delete an unnecessary check before the function call "__nd_device_register"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] libnvdimm-btt: Delete an unnecessary check before the  function call "__nd_device_register" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-24 11:20 +0200
    Re: [PATCH] libnvdimm-btt: Delete an unnecessary check before the  function call "__nd_device_register" Dan Williams <dan.j.williams@intel.com> - 2016-07-24 17:20 +0200

#1449100 — [PATCH] libnvdimm-btt: Delete an unnecessary check before the function call "__nd_device_register"

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 24 Jul 2016 11:05:34 +0200

The __nd_device_register() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/nvdimm/btt_devs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/nvdimm/btt_devs.c b/drivers/nvdimm/btt_devs.c
index 816d0da..3fa7919 100644
--- a/drivers/nvdimm/btt_devs.c
+++ b/drivers/nvdimm/btt_devs.c
@@ -198,8 +198,7 @@ struct device *nd_btt_create(struct nd_region *nd_region)
 {
 	struct device *dev = __nd_btt_create(nd_region, 0, NULL, NULL);
 
-	if (dev)
-		__nd_device_register(dev);
+	__nd_device_register(dev);
 	return dev;
 }
 
-- 
2.9.2

[toc] | [next] | [standalone]

#1449155

On Sun, Jul 24, 2016 at 2:16 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 24 Jul 2016 11:05:34 +0200
>
> The __nd_device_register() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Thanks, applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web