Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449044 > unrolled thread

[PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot chengang@emindsoft.com.cn - 2016-07-24 05:50 +0200
    Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot Michael Ellerman <mpe@ellerman.id.au> - 2016-07-25 07:20 +0200

#1449044 — [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot

From: Chen Gang <chengang@emindsoft.com.cn>

For pure bool function's return value, bool is a little better more or
less than int.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/powerpc/include/asm/mman.h | 8 ++++----
 include/linux/mman.h            | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h
index 2563c43..fc420ce 100644
--- a/arch/powerpc/include/asm/mman.h
+++ b/arch/powerpc/include/asm/mman.h
@@ -31,13 +31,13 @@ static inline pgprot_t arch_vm_get_page_prot(unsigned long vm_flags)
 }
 #define arch_vm_get_page_prot(vm_flags) arch_vm_get_page_prot(vm_flags)
 
-static inline int arch_validate_prot(unsigned long prot)
+static inline bool arch_validate_prot(unsigned long prot)
 {
 	if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO))
-		return 0;
+		return false;
 	if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO))
-		return 0;
-	return 1;
+		return false;
+	return true;
 }
 #define arch_validate_prot(prot) arch_validate_prot(prot)
 
diff --git a/include/linux/mman.h b/include/linux/mman.h
index 33e17f6..634c4c5 100644
--- a/include/linux/mman.h
+++ b/include/linux/mman.h
@@ -49,7 +49,7 @@ static inline void vm_unacct_memory(long pages)
  *
  * Returns true if the prot flags are valid
  */
-static inline int arch_validate_prot(unsigned long prot)
+static inline bool arch_validate_prot(unsigned long prot)
 {
 	return (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM)) == 0;
 }
-- 
1.9.3

[toc] | [next] | [standalone]

#1449285

chengang@emindsoft.com.cn writes:

> From: Chen Gang <chengang@emindsoft.com.cn>
>
> For pure bool function's return value, bool is a little better more or
> less than int.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/powerpc/include/asm/mman.h | 8 ++++----
>  include/linux/mman.h            | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)

LGTM.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

Andrew do you want to take this or should I?

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web