Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449696 > unrolled thread

[Patch 0/1] apparmor: fix to 4.8 pull request

Started byJohn Johansen <john.johansen@canonical.com>
First post2016-07-25 20:00 +0200
Last post2016-07-26 19:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [Patch 0/1] apparmor: fix to 4.8 pull request John Johansen <john.johansen@canonical.com> - 2016-07-25 20:00 +0200
    [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling John Johansen <john.johansen@canonical.com> - 2016-07-25 20:00 +0200
      Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter  handling James Morris <jmorris@namei.org> - 2016-07-26 13:40 +0200
        Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter  handling John Johansen <john.johansen@canonical.com> - 2016-07-26 19:00 +0200

#1449696 — [Patch 0/1] apparmor: fix to 4.8 pull request

FromJohn Johansen <john.johansen@canonical.com>
Date2016-07-25 20:00 +0200
Subject[Patch 0/1] apparmor: fix to 4.8 pull request
Message-ID<rYSky-7wc-23@gated-at.bofh.it>
Hi James,

can you please pull the following bug fix to the 4.8 pull-request

The following changes since commit d4d03f74a73f3b8b2801d4d02011b6b69778cbcc:

  apparmor: fix arg_size computation for when setprocattr is null terminated (2016-07-12 08:43:10 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor for-security

for you to fetch changes up to dc6f823283a3a97044655745cb5fd69749a0555a:

  apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling (2016-07-25 10:44:59 -0700)

----------------------------------------------------------------
Arnd Bergmann (1):
      apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling

 security/apparmor/crypto.c        | 3 +++
 security/apparmor/lsm.c           | 4 +++-
 security/apparmor/policy_unpack.c | 3 +--
 3 files changed, 7 insertions(+), 3 deletions(-)

[toc] | [next] | [standalone]

#1449698 — [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling

FromJohn Johansen <john.johansen@canonical.com>
Date2016-07-25 20:00 +0200
Subject[PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling
Message-ID<rYSky-7wc-25@gated-at.bofh.it>
In reply to#1449696
From: Arnd Bergmann <arnd@arndb.de>

The newly added Kconfig option could never work and just causes a build error
when disabled:

security/apparmor/lsm.c:675:25: error: 'CONFIG_SECURITY_APPARMOR_HASH_DEFAULT' undeclared here (not in a function)
 bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;

The problem is that the macro undefined in this case, and we need to use the IS_ENABLED()
helper to turn it into a boolean constant.

Another minor problem with the original patch is that the option is even offered
in sysfs when SECURITY_APPARMOR_HASH is not enabled, so this also hides the option
in that case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 6059f71f1e94 ("apparmor: add parameter to control whether policy hashing is used")
Signed-off-by: John Johansen <john.johansen@canonical.com>
---
 security/apparmor/crypto.c        | 3 +++
 security/apparmor/lsm.c           | 4 +++-
 security/apparmor/policy_unpack.c | 3 +--
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/security/apparmor/crypto.c b/security/apparmor/crypto.c
index 532471d..b75dab0 100644
--- a/security/apparmor/crypto.c
+++ b/security/apparmor/crypto.c
@@ -39,6 +39,9 @@ int aa_calc_profile_hash(struct aa_profile *profile, u32 version, void *start,
 	int error = -ENOMEM;
 	u32 le32_version = cpu_to_le32(version);
 
+	if (!aa_g_hash_policy)
+		return 0;
+
 	if (!apparmor_tfm)
 		return 0;
 
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index 3be30c7..41b8cb1 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -671,9 +671,11 @@ enum profile_mode aa_g_profile_mode = APPARMOR_ENFORCE;
 module_param_call(mode, param_set_mode, param_get_mode,
 		  &aa_g_profile_mode, S_IRUSR | S_IWUSR);
 
+#ifdef CONFIG_SECURITY_APPARMOR_HASH
 /* whether policy verification hashing is enabled */
-bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;
+bool aa_g_hash_policy = IS_ENABLED(CONFIG_SECURITY_APPARMOR_HASH_DEFAULT);
 module_param_named(hash_policy, aa_g_hash_policy, aabool, S_IRUSR | S_IWUSR);
+#endif
 
 /* Debug mode */
 bool aa_g_debug;
diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
index b9b1c66..1381206 100644
--- a/security/apparmor/policy_unpack.c
+++ b/security/apparmor/policy_unpack.c
@@ -778,8 +778,7 @@ int aa_unpack(void *udata, size_t size, struct list_head *lh, const char **ns)
 		if (error)
 			goto fail_profile;
 
-		if (aa_g_hash_policy)
-			error = aa_calc_profile_hash(profile, e.version, start,
+		error = aa_calc_profile_hash(profile, e.version, start,
 						     e.pos - start);
 		if (error)
 			goto fail_profile;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1450538 — Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling

FromJames Morris <jmorris@namei.org>
Date2016-07-26 13:40 +0200
SubjectRe: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling
Message-ID<rZ8Sm-1mU-15@gated-at.bofh.it>
In reply to#1449698
On Mon, 25 Jul 2016, John Johansen wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added Kconfig option could never work and just causes a build error
> when disabled:
> 
> security/apparmor/lsm.c:675:25: error: 'CONFIG_SECURITY_APPARMOR_HASH_DEFAULT' undeclared here (not in a function)
>  bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;
> 
> The problem is that the macro undefined in this case, and we need to use the IS_ENABLED()
> helper to turn it into a boolean constant.
> 
> Another minor problem with the original patch is that the option is even offered
> in sysfs when SECURITY_APPARMOR_HASH is not enabled, so this also hides the option
> in that case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6059f71f1e94 ("apparmor: add parameter to control whether policy hashing is used")
> Signed-off-by: John Johansen <john.johansen@canonical.com>

Please rebase this against current Linus.

-- 
James Morris
<jmorris@namei.org>

[toc] | [prev] | [next] | [standalone]

#1450687 — Re: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling

FromJohn Johansen <john.johansen@canonical.com>
Date2016-07-26 19:00 +0200
SubjectRe: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling
Message-ID<rZdS2-4t5-15@gated-at.bofh.it>
In reply to#1450538
On 07/26/2016 04:38 AM, James Morris wrote:
> On Mon, 25 Jul 2016, John Johansen wrote:
> 
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The newly added Kconfig option could never work and just causes a build error
>> when disabled:
>>
>> security/apparmor/lsm.c:675:25: error: 'CONFIG_SECURITY_APPARMOR_HASH_DEFAULT' undeclared here (not in a function)
>>  bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;
>>
>> The problem is that the macro undefined in this case, and we need to use the IS_ENABLED()
>> helper to turn it into a boolean constant.
>>
>> Another minor problem with the original patch is that the option is even offered
>> in sysfs when SECURITY_APPARMOR_HASH is not enabled, so this also hides the option
>> in that case.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 6059f71f1e94 ("apparmor: add parameter to control whether policy hashing is used")
>> Signed-off-by: John Johansen <john.johansen@canonical.com>
> 
> Please rebase this against current Linus.
> 
Well this is a fix for a patch in the security next queue, so linus doesn't
have it yet. I can wait for your 4.8 pull request and rebase then

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web