Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1449260 > unrolled thread

[PATCH 05/14] mips: migrate exception table users off module.h and onto extable.h

Started byPaul Gortmaker <paul.gortmaker@windriver.com>
First post2016-07-25 05:50 +0200
Last post2016-07-25 11:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 05/14] mips: migrate exception table users off module.h and onto extable.h Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-25 05:50 +0200
    Re: [PATCH 05/14] mips: migrate exception table users off module.h  and onto extable.h kbuild test robot <lkp@intel.com> - 2016-07-25 11:10 +0200

#1449260 — [PATCH 05/14] mips: migrate exception table users off module.h and onto extable.h

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-07-25 05:50 +0200
Subject[PATCH 05/14] mips: migrate exception table users off module.h and onto extable.h
Message-ID<rYF3X-7Xa-17@gated-at.bofh.it>
These files were only including module.h for exception table
related functions.  We've now separated that content out into its
own file "extable.h" so now move over to that and avoid all the
extra header content in module.h that we don't really need to compile
these files.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 arch/mips/kernel/module.c | 1 +
 arch/mips/kernel/traps.c  | 2 +-
 arch/mips/mm/extable.c    | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/module.c b/arch/mips/kernel/module.c
index 79850e376ef6..94627a3a6a0d 100644
--- a/arch/mips/kernel/module.c
+++ b/arch/mips/kernel/module.c
@@ -20,6 +20,7 @@
 
 #undef DEBUG
 
+#include <linux/extable.h>
 #include <linux/moduleloader.h>
 #include <linux/elf.h>
 #include <linux/mm.h>
diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 6fb4704bd156..b4522e3a0562 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -20,7 +20,7 @@
 #include <linux/kexec.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
-#include <linux/module.h>
+#include <linux/extable.h>
 #include <linux/mm.h>
 #include <linux/sched.h>
 #include <linux/smp.h>
diff --git a/arch/mips/mm/extable.c b/arch/mips/mm/extable.c
index 9d25d2ba4b9e..e474fa2efed4 100644
--- a/arch/mips/mm/extable.c
+++ b/arch/mips/mm/extable.c
@@ -5,7 +5,7 @@
  *
  * Copyright (C) 1997, 99, 2001 - 2004 Ralf Baechle <ralf@linux-mips.org>
  */
-#include <linux/module.h>
+#include <linux/extable.h>
 #include <linux/spinlock.h>
 #include <asm/branch.h>
 #include <asm/uaccess.h>
-- 
2.8.4

[toc] | [next] | [standalone]


#1449386 — Re: [PATCH 05/14] mips: migrate exception table users off module.h and onto extable.h

Fromkbuild test robot <lkp@intel.com>
Date2016-07-25 11:10 +0200
SubjectRe: [PATCH 05/14] mips: migrate exception table users off module.h and onto extable.h
Message-ID<rYK3D-2IR-3@gated-at.bofh.it>
In reply to#1449260

[Multipart message — attachments visible in raw view] — view raw

Hi,

[auto build test ERROR on next-20160724]
[cannot apply to stable/master linus/master linux/master v4.7-rc7 v4.7-rc6 v4.7-rc5 v4.7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paul-Gortmaker/split-exception-table-content-out-of-module-h-into-extable-h/20160725-152314
config: mips-jz4740 (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All errors (new ones prefixed by >>):

   arch/mips/kernel/traps.c: In function 'show_registers':
>> arch/mips/kernel/traps.c:354:2: error: implicit declaration of function 'print_modules' [-Werror=implicit-function-declaration]
     print_modules();
     ^
   cc1: some warnings being treated as errors

vim +/print_modules +354 arch/mips/kernel/traps.c

c1bf207d David Daney     2010-08-03  348  void show_registers(struct pt_regs *regs)
^1da177e Linus Torvalds  2005-04-16  349  {
39b8d525 Ralf Baechle    2008-04-28  350  	const int field = 2 * sizeof(unsigned long);
83e4da1e Leonid Yegoshin 2013-10-08  351  	mm_segment_t old_fs = get_fs();
39b8d525 Ralf Baechle    2008-04-28  352  
eae23f2c Ralf Baechle    2007-10-14  353  	__show_regs(regs);
^1da177e Linus Torvalds  2005-04-16 @354  	print_modules();
39b8d525 Ralf Baechle    2008-04-28  355  	printk("Process %s (pid: %d, threadinfo=%p, task=%p, tls=%0*lx)\n",
39b8d525 Ralf Baechle    2008-04-28  356  	       current->comm, current->pid, current_thread_info(), current,
39b8d525 Ralf Baechle    2008-04-28  357  	      field, current_thread_info()->tp_value);

:::::: The code at line 354 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web