Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1448135 > unrolled thread

[PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver

Started byHoan Tran <hotran@apm.com>
First post2016-07-21 23:00 +0200
Last post2016-07-22 00:20 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver Hoan Tran <hotran@apm.com> - 2016-07-21 23:00 +0200
    [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran <hotran@apm.com> - 2016-07-21 23:00 +0200
      Re: [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding  documentation Guenter Roeck <linux@roeck-us.net> - 2016-07-22 00:10 +0200
    [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran <hotran@apm.com> - 2016-07-21 23:00 +0200
      Re: [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device  tree Guenter Roeck <linux@roeck-us.net> - 2016-07-22 00:20 +0200

#1448135 — [PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver

FromHoan Tran <hotran@apm.com>
Date2016-07-21 23:00 +0200
Subject[PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver
Message-ID<rXtex-4cZ-9@gated-at.bofh.it>
This patch set adds hardware temperature and power reading support for
APM X-Gene SoC using the mailbox communication interface.
For device tree, it is the standard DT mailbox.
For ACPI, it is the PCC mailbox.

For ACPI, this patch is built on top and depends on patch[1]:
[1] http://www.spinics.net/lists/linux-acpi/msg66041.html
 - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

v3
 - Order include files alphabetically
 - Use sign_extend32() to decode temperature
 - Use DEVICE_ATTR_RO() for temperature and power attributes
 - Temperature and power attributes start with index 1
 - Use !!amsg->param2
 - Fix checkpatch WARNING with --strict flag
 - Use hwmon_device_register_with_groups()
 - Check invalid sensor data

v2
 - Increase power reading accurateness by using 2 registers
(a register for Watt, another for milli-Watt)
 - Remove power reading for SoC
 - Fix review comments from Guenter

v1
 - Initial

Hoan Tran (3):
  Documentation: dtb: xgene: Add hwmon dts binding documentation
  hwmon: xgene: Add hwmon driver
  arm64: dts: apm: Add X-Gene SoC hwmon to device tree

 .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt  |  14 +
 Documentation/hwmon/xgene-hwmon                    |  30 +
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi         |   5 +
 arch/arm64/boot/dts/apm/apm-storm.dtsi             |   5 +
 drivers/hwmon/Kconfig                              |   7 +
 drivers/hwmon/Makefile                             |   1 +
 drivers/hwmon/xgene-hwmon.c                        | 755 +++++++++++++++++++++
 7 files changed, 817 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
 create mode 100644 Documentation/hwmon/xgene-hwmon
 create mode 100644 drivers/hwmon/xgene-hwmon.c

-- 
1.9.1

[toc] | [next] | [standalone]


#1448137 — [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

FromHoan Tran <hotran@apm.com>
Date2016-07-21 23:00 +0200
Subject[PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation
Message-ID<rXtey-4cZ-27@gated-at.bofh.it>
In reply to#1448135
This patch adds the APM X-Gene hwmon device tree node documentation.

Signed-off-by: Hoan Tran <hotran@apm.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt          | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt

diff --git a/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt b/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
new file mode 100644
index 0000000..59b3855
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
@@ -0,0 +1,14 @@
+APM X-Gene hwmon driver
+
+APM X-Gene SOC sensors are accessed over the "SLIMpro" mailbox.
+
+Required properties :
+ - compatible : should be "apm,xgene-slimpro-hwmon"
+ - mboxes : use the label reference for the mailbox as the first parameter.
+	    The second parameter is the channel number.
+
+Example :
+	hwmonslimpro {
+		compatible = "apm,xgene-slimpro-hwmon";
+		mboxes = <&mailbox 7>;
+	};
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1448214 — Re: [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

FromGuenter Roeck <linux@roeck-us.net>
Date2016-07-22 00:10 +0200
SubjectRe: [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation
Message-ID<rXuki-597-31@gated-at.bofh.it>
In reply to#1448137
On Thu, Jul 21, 2016 at 01:55:55PM -0700, Hoan Tran wrote:
> This patch adds the APM X-Gene hwmon device tree node documentation.
> 
> Signed-off-by: Hoan Tran <hotran@apm.com>
> Acked-by: Rob Herring <robh@kernel.org>

Applied to hwmon-next.

Thanks,
Guenter

[toc] | [prev] | [next] | [standalone]


#1448138 — [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree

FromHoan Tran <hotran@apm.com>
Date2016-07-21 23:00 +0200
Subject[PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree
Message-ID<rXtey-4cZ-29@gated-at.bofh.it>
In reply to#1448135
This patch adds DT node to enable hwmon driver for APM X-Gene SoC.

Signed-off-by: Hoan Tran <hotran@apm.com>
---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 5 +++++
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index c569f76..a5935f5 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -472,6 +472,11 @@
 			mboxes = <&mailbox 0>;
 		};
 
+		hwmonslimpro {
+			compatible = "apm,xgene-slimpro-hwmon";
+			mboxes = <&mailbox 7>;
+		};
+
 		serial0: serial@10600000 {
 			device_type = "serial";
 			compatible = "ns16550";
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 5147d76..f8ea5b5 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -716,6 +716,11 @@
 			mboxes = <&mailbox 0>;
 		};
 
+		hwmonslimpro {
+			compatible = "apm,xgene-slimpro-hwmon";
+			mboxes = <&mailbox 7>;
+		};
+
 		serial0: serial@1c020000 {
 			status = "disabled";
 			device_type = "serial";
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1448218 — Re: [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree

FromGuenter Roeck <linux@roeck-us.net>
Date2016-07-22 00:20 +0200
SubjectRe: [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree
Message-ID<rXutY-5ec-9@gated-at.bofh.it>
In reply to#1448138
On Thu, Jul 21, 2016 at 01:55:57PM -0700, Hoan Tran wrote:
> This patch adds DT node to enable hwmon driver for APM X-Gene SoC.
> 
> Signed-off-by: Hoan Tran <hotran@apm.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 5 +++++
>  arch/arm64/boot/dts/apm/apm-storm.dtsi     | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> index c569f76..a5935f5 100644
> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> @@ -472,6 +472,11 @@
>  			mboxes = <&mailbox 0>;
>  		};
>  
> +		hwmonslimpro {
> +			compatible = "apm,xgene-slimpro-hwmon";
> +			mboxes = <&mailbox 7>;
> +		};
> +
>  		serial0: serial@10600000 {
>  			device_type = "serial";
>  			compatible = "ns16550";
> diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> index 5147d76..f8ea5b5 100644
> --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> @@ -716,6 +716,11 @@
>  			mboxes = <&mailbox 0>;
>  		};
>  
> +		hwmonslimpro {
> +			compatible = "apm,xgene-slimpro-hwmon";
> +			mboxes = <&mailbox 7>;
> +		};
> +
>  		serial0: serial@1c020000 {
>  			status = "disabled";
>  			device_type = "serial";
> -- 
> 1.9.1
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web