Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1447551 > unrolled thread
| Started by | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| First post | 2016-07-21 02:40 +0200 |
| Last post | 2016-07-21 16:50 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Andrew Lunn <andrew@lunn.ch> - 2016-07-21 02:40 +0200
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Florian Fainelli <f.fainelli@gmail.com> - 2016-07-21 04:20 +0200
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-21 16:50 +0200
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Andrew Lunn <andrew@lunn.ch> - 2016-07-21 17:00 +0200
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-21 16:50 +0200
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-07-21 02:40 +0200 |
| Subject | Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY |
| Message-ID | <rXabU-8r-5@gated-at.bofh.it> |
On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote:
> This patch simply moves the legacy DSA code from dsa.c to legacy.c,
> except the few shared symbols which remain in dsa.c.
I think it is a bit early for this. Lets convert all in kernel users
to the new binding first.
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> drivers/net/dsa/Kconfig | 4 +-
> drivers/net/dsa/mv88e6xxx/chip.c | 8 +
> include/net/dsa.h | 4 +
> net/dsa/Kconfig | 8 +
> net/dsa/Makefile | 1 +
> net/dsa/dsa.c | 985 ------------------------------------
> net/dsa/legacy.c | 1013 ++++++++++++++++++++++++++++++++++++++
I'm surprised git did not notice this is a rename.
Andrew
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2016-07-21 04:20 +0200 |
| Message-ID | <rXbKF-1hi-3@gated-at.bofh.it> |
| In reply to | #1447551 |
Le 20/07/2016 à 17:35, Andrew Lunn a écrit : > On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: >> This patch simply moves the legacy DSA code from dsa.c to legacy.c, >> except the few shared symbols which remain in dsa.c. > > I think it is a bit early for this. Lets convert all in kernel users > to the new binding first. Fine with me, let's try to get the in-tree DTS files converted to the new binding by v4.9 so we can then introduce this Kconfig symbol and start producing warnings if the old binding is encountered, how does that sound? -- Florian
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-07-21 16:50 +0200 |
| Message-ID | <rXnsv-gG-29@gated-at.bofh.it> |
| In reply to | #1447585 |
Florian Fainelli <f.fainelli@gmail.com> writes:
> Le 20/07/2016 à 17:35, Andrew Lunn a écrit :
>> On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote:
>>> This patch simply moves the legacy DSA code from dsa.c to legacy.c,
>>> except the few shared symbols which remain in dsa.c.
>>
>> I think it is a bit early for this. Lets convert all in kernel users
>> to the new binding first.
>
> Fine with me, let's try to get the in-tree DTS files converted to the
> new binding by v4.9 so we can then introduce this Kconfig symbol and
> start producing warnings if the old binding is encountered, how does
> that sound?
If you guys prefer going that way, that's fine with me too ;-)
Thanks,
Vivien
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-07-21 17:00 +0200 |
| Message-ID | <rXnCb-kD-39@gated-at.bofh.it> |
| In reply to | #1447937 |
On Thu, Jul 21, 2016 at 10:46:56AM -0400, Vivien Didelot wrote:
> Florian Fainelli <f.fainelli@gmail.com> writes:
>
> > Le 20/07/2016 à 17:35, Andrew Lunn a écrit :
> >> On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote:
> >>> This patch simply moves the legacy DSA code from dsa.c to legacy.c,
> >>> except the few shared symbols which remain in dsa.c.
> >>
> >> I think it is a bit early for this. Lets convert all in kernel users
> >> to the new binding first.
> >
> > Fine with me, let's try to get the in-tree DTS files converted to the
> > new binding by v4.9 so we can then introduce this Kconfig symbol and
> > start producing warnings if the old binding is encountered, how does
> > that sound?
>
> If you guys prefer going that way, that's fine with me too ;-)
Yes, i would prefer that.
Andrew
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-07-21 16:50 +0200 |
| Message-ID | <rXnsu-gG-15@gated-at.bofh.it> |
| In reply to | #1447551 |
Hi Andrew, Andrew Lunn <andrew@lunn.ch> writes: >> net/dsa/dsa.c | 985 ------------------------------------ >> net/dsa/legacy.c | 1013 ++++++++++++++++++++++++++++++++++++++ > > I'm surprised git did not notice this is a rename. I used -M though, even -C doesn't change anything... :-/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web