Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447791 > unrolled thread

Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Arnd Bergmann <arnd@arndb.de> - 2016-07-21 13:00 +0200
    Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Wan ZongShun <mcuos.com@gmail.com> - 2016-07-22 04:40 +0200

#1447791 — Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900

On Saturday, July 9, 2016 11:25:19 AM CEST Wan Zongshun wrote:
> On 2016年06月29日 23:27, Arnd Bergmann wrote:
> > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote:
> >> +#define IRQ_WDT             W90X900_IRQ(1)
> >> +#define IRQ_WWDT    W90X900_IRQ(2)
> >> +#define IRQ_LVD             W90X900_IRQ(3)
> >> +#define IRQ_EXT0    W90X900_IRQ(4)
> >> +#define IRQ_EXT1    W90X900_IRQ(5)
> >> +#define IRQ_EXT2    W90X900_IRQ(6)
> >> +#define IRQ_EXT3    W90X900_IRQ(7)
> >> +#define IRQ_EXT4    W90X900_IRQ(8)
> >> +#define IRQ_EXT5    W90X900_IRQ(9)
> >> +#define IRQ_EXT6    W90X900_IRQ(10)
> >
> > I'd suggest dropping the list, the contents are now in the dts.
> 
> Arnd, I will drop this file later, since old w90x900 plat still need it.

Sure.

> but I will remove the Macros related to nuc970 and avoid nuc970 
> interrupt using those Macro.
> 
> But I still need hack this irqs.h like below, since here NR_IRQS defined 
> and it is need for nuc970 irqchip driver.
> 
> #if !defined(CONFIG_SOC_NUC900)
> #define NR_IRQS         (IRQ_ADC+1)
> #else
> #define NR_IRQS         62
> #endif

Have you considered using CONFIG_SPARSE_IRQ? That would avoid the need
for setting NR_IRQS entirely, but may also require more work elsewhere.

	Arnd

[toc] | [next] | [standalone]

#1448312

>
>> but I will remove the Macros related to nuc970 and avoid nuc970
>> interrupt using those Macro.
>>
>> But I still need hack this irqs.h like below, since here NR_IRQS defined
>> and it is need for nuc970 irqchip driver.
>>
>> #if !defined(CONFIG_SOC_NUC900)
>> #define NR_IRQS         (IRQ_ADC+1)
>> #else
>> #define NR_IRQS         62
>> #endif
>
> Have you considered using CONFIG_SPARSE_IRQ? That would avoid the need
> for setting NR_IRQS entirely, but may also require more work elsewhere.

Sure, I will refer to your previous nuc900 series patches for SPARSE
IRQ, now I am waiting for rc1 release, and will send v3 patches.

>
>         Arnd



-- 
---
Vincent Wan(Zongshun)
www.mcuos.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web