Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447614 > unrolled thread

[PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined

Back to article view | Back to linux.kernel

Contents

  [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-21 07:10 +0200
    Re: [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is  undefined Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-22 14:40 +0200

#1447614 — [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined

This has been inconsistent; some returns -EINVAL, some -ENOTSUPP.
Make it consistent in this header, in favor of -ENOTSUPP.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/linux/reset.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index 5894f0f..c875b4b 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -71,14 +71,14 @@ static inline struct reset_control *__of_reset_control_get(
 					struct device_node *node,
 					const char *id, int index, int shared)
 {
-	return ERR_PTR(-EINVAL);
+	return ERR_PTR(-ENOTSUPP);
 }
 
 static inline struct reset_control *__devm_reset_control_get(
 					struct device *dev,
 					const char *id, int index, int shared)
 {
-	return ERR_PTR(-EINVAL);
+	return ERR_PTR(-ENOTSUPP);
 }
 
 #endif /* CONFIG_RESET_CONTROLLER */
-- 
1.9.1

[toc] | [next] | [standalone]

#1448557 — Re: [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined

Hi Masahiro,

Am Donnerstag, den 21.07.2016, 14:06 +0900 schrieb Masahiro Yamada:
> This has been inconsistent; some returns -EINVAL, some -ENOTSUPP.
> Make it consistent in this header, in favor of -ENOTSUPP.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  include/linux/reset.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 5894f0f..c875b4b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -71,14 +71,14 @@ static inline struct reset_control *__of_reset_control_get(
>  					struct device_node *node,
>  					const char *id, int index, int shared)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  static inline struct reset_control *__devm_reset_control_get(
>  					struct device *dev,
>  					const char *id, int index, int shared)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  #endif /* CONFIG_RESET_CONTROLLER */

Thanks, this has already been changed in commit 168d7c4e8bb2 ("reset:
Return -ENOTSUPP when not configured").

regards
Philipp

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web