Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447316 > unrolled thread

Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Thomas Backlund <tmb@mageia.org> - 2016-07-20 18:00 +0200
    Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Herbert Xu <herbert@gondor.apana.org.au> - 2016-07-21 06:20 +0200

#1447316 — Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

Den 01-07-2016 kl. 12:30, skrev Herbert Xu:
> On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote:
>> Parallel build can sporadically fail because asn1 headers may
>> not be built yet by the time qat_asym_algs.o is compiled:
>>   drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
>>    #include "qat_rsapubkey-asn1.h"
>>
>> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>
> Jan, Salvatore just posted a patch to delete the qat ASN code
> altogether, so your patch won't be needed.
>
> Thanks,
>

Yeah, but that patch seem to be heading to 4.8 only , so qat build in 
upcoming 4.7 still breaks...

and pulling that fix only to 4.7 breaks too, so I guess more fixes
would be needed for proper backport then...

or are the qat fixes already queued somewhere for 4.7 final ?

--
Thomas

[toc] | [next] | [standalone]

#1447609

On Wed, Jul 20, 2016 at 06:37:07PM +0300, Thomas Backlund wrote:
>
> Yeah, but that patch seem to be heading to 4.8 only , so qat build
> in upcoming 4.7 still breaks...
> 
> and pulling that fix only to 4.7 breaks too, so I guess more fixes
> would be needed for proper backport then...
> 
> or are the qat fixes already queued somewhere for 4.7 final ?

You're right.  This patch is probably the safest fix for 4.7.

I'll bounce it to stable.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web