Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1448776 > unrolled thread

Re: [PATCH 0/2] PCI: altera: fix link retrain

Started byBjorn Helgaas <helgaas@kernel.org>
First post2016-07-22 23:10 +0200
Last post2016-07-25 07:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 0/2] PCI: altera: fix link retrain Bjorn Helgaas <helgaas@kernel.org> - 2016-07-22 23:10 +0200
    Re: [PATCH 0/2] PCI: altera: fix link retrain Ley Foon Tan <lftan@altera.com> - 2016-07-25 07:10 +0200

#1448776 — Re: [PATCH 0/2] PCI: altera: fix link retrain

FromBjorn Helgaas <helgaas@kernel.org>
Date2016-07-22 23:10 +0200
SubjectRe: [PATCH 0/2] PCI: altera: fix link retrain
Message-ID<rXPRL-2CP-7@gated-at.bofh.it>
On Tue, Jun 21, 2016 at 04:53:11PM +0800, Ley Foon Tan wrote:
> This 2 patches fix the issue before and after retrain link.
> 
> Ley Foon Tan (2):
>   PCI: altera: check link status before retrain link
>   PCI: altera: Polling for link up status after retrain the link
> 
>  drivers/pci/host/pcie-altera.c | 48 +++++++++++++++++++++++++++---------------
>  1 file changed, 31 insertions(+), 17 deletions(-)

I applied these to pci/host-altera for v4.8, thanks!

I split the code move into its own patch so the bug fix is clearly
visible.  I also fixed these whitespace errors:

  if(!altera_pcie_link_is_up(pcie))
  while(!altera_pcie_link_is_up(pcie)) {

A space is required after "if" and "while".

[toc] | [next] | [standalone]


#1449284

FromLey Foon Tan <lftan@altera.com>
Date2016-07-25 07:10 +0200
Message-ID<rYGjn-v0-5@gated-at.bofh.it>
In reply to#1448776
On Sat, Jul 23, 2016 at 5:07 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Tue, Jun 21, 2016 at 04:53:11PM +0800, Ley Foon Tan wrote:
> > This 2 patches fix the issue before and after retrain link.
> >
> > Ley Foon Tan (2):
> >   PCI: altera: check link status before retrain link
> >   PCI: altera: Polling for link up status after retrain the link
> >
> >  drivers/pci/host/pcie-altera.c | 48 +++++++++++++++++++++++++++---------------
> >  1 file changed, 31 insertions(+), 17 deletions(-)
>
> I applied these to pci/host-altera for v4.8, thanks!
>
> I split the code move into its own patch so the bug fix is clearly
> visible.  I also fixed these whitespace errors:
>
>   if(!altera_pcie_link_is_up(pcie))
>   while(!altera_pcie_link_is_up(pcie)) {
>
> A space is required after "if" and "while".
Hi Bjorn

Thanks a lot!

Regards
Ley Foon

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web