Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448700 > unrolled thread

Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on  OF Ray Jui <ray.jui@broadcom.com> - 2016-07-22 20:10 +0200
    Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on  OF Randy Dunlap <rdunlap@infradead.org> - 2016-07-22 20:20 +0200

#1448700 — Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF

Hi Randy,

On 7/22/2016 11:06 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
> but COMPILE_TEST is enabled by making the driver depend on OF.
>
> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
>   .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> ---
>  drivers/pinctrl/bcm/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
> +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
> @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
>  config PINCTRL_CYGNUS_MUX
>  	bool "Broadcom Cygnus IOMUX driver"
>  	depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
> +	depends on OF
>  	select PINMUX
>  	select GENERIC_PINCONF
>  	default ARCH_BCM_CYGNUS
>

Thanks, but a fix was already submitted by Arnd and picked up by Linus: 
https://lkml.org/lkml/2016/7/15/649

Ray

[toc] | [next] | [standalone]

#1448710

On 07/22/16 11:09, Ray Jui wrote:
> Hi Randy,
> 
> On 7/22/2016 11:06 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
>> but COMPILE_TEST is enabled by making the driver depend on OF.
>>
>> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
>>   .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Ray Jui <rjui@broadcom.com>
>> Cc: bcm-kernel-feedback-list@broadcom.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: linux-gpio@vger.kernel.org
>> ---
>>  drivers/pinctrl/bcm/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
>> +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
>> @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
>>  config PINCTRL_CYGNUS_MUX
>>      bool "Broadcom Cygnus IOMUX driver"
>>      depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
>> +    depends on OF
>>      select PINMUX
>>      select GENERIC_PINCONF
>>      default ARCH_BCM_CYGNUS
>>
> 
> Thanks, but a fix was already submitted by Arnd and picked up by Linus: https://lkml.org/lkml/2016/7/15/649

OK, it's just not in linux-next yet.

Thanks.


-- 
~Randy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web