Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448550 > unrolled thread

Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size Michal Marek <mmarek@suse.com> - 2016-07-22 14:10 +0200

#1448550 — Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

On 2016-07-06 10:45, Dave Young wrote:
> On 07/04/16 at 01:55pm, Tautschnig, Michael wrote:
>> bin2c is used to create a valid C file out of a binary file where two
>> symbols will be globally defined: <name> and <name>_size. <name> is
>> passed as the first parameter of the host binary.
>>
>> Building using goto-cc reported that the purgatory binary code (the only
>> current user of this utility) declares kexec_purgatory_size as 'size_t'
>> where bin2c generate <name>_size to be 'int' so in a 64-bit host where
>> sizeof(size_t) > sizeof(int) this type mismatch will always yield the
>> wrong value for big-endian architectures while for little-endian it will
>> be wrong if the object laid in memory directly after
>> kexec_purgatory_size contains non-zero value at the time of reading.
>>
>> This commit changes <name>_size to be size_t instead.
>>
>> Note:
>>
>> Another way to fix the problem is to change the type of
>> kexec_purgatory_size to be 'int' as there's this check in code:
>> (kexec_purgatory_size <= 0)
>>
>> Signed-off-by: Michael Tautschnig <tautschn@amazon.com>
>> Cc: Michal Marek <mmarek@suse.com>
>> Cc: Vivek Goyal <vgoyal@redhat.com>
[...]
> Acked-by: Dave Young <dyoung@redhat.com>

Applied to kbuild.git#kbuild.

Michal

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web