Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447814 > unrolled thread

[PATCH 0/2] dra7: add support for two PCIe ports

Started byKishon Vijay Abraham I <kishon@ti.com>
First post2016-07-21 14:00 +0200
Last post2016-07-22 15:40 +0200
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] dra7: add support for two PCIe ports Kishon Vijay Abraham I <kishon@ti.com> - 2016-07-21 14:00 +0200
    [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I <kishon@ti.com> - 2016-07-21 14:00 +0200
      Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Arnd Bergmann <arnd@arndb.de> - 2016-07-21 14:10 +0200
        Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Tony Lindgren <tony@atomide.com> - 2016-07-22 09:20 +0200
          Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I <kishon@ti.com> - 2016-07-22 10:30 +0200
            Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Sekhar Nori <nsekhar@ti.com> - 2016-07-22 11:30 +0200
            Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Arnd Bergmann <arnd@arndb.de> - 2016-07-22 15:40 +0200

#1447814 — [PATCH 0/2] dra7: add support for two PCIe ports

FromKishon Vijay Abraham I <kishon@ti.com>
Date2016-07-21 14:00 +0200
Subject[PATCH 0/2] dra7: add support for two PCIe ports
Message-ID<rXkNX-6Xk-7@gated-at.bofh.it>
This series adds patches to support 2 PCIe ports simultaneously
on dra7 based boards.
None of the supported boards exposes 2 PCIe ports. However these are
mandatory changes that would be required in order to support
2 PCIe ports.

This series has been tested to see if there are regressions with 1
PCIe port. Though testing of 2 PCIe ports is not done
while sending this patch series, it has been verified in
few of the customer boards.

Kishon Vijay Abraham I (2):
  ARM: dts: DRA7: Add "linux,pci-domain" property for pci dt nodes
  ARM: DRA7: select PCI_DOMAINS config

 arch/arm/boot/dts/dra7.dtsi |    2 ++
 arch/arm/mach-omap2/Kconfig |    1 +
 2 files changed, 3 insertions(+)

-- 
1.7.9.5

[toc] | [next] | [standalone]

#1447815 — [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

FromKishon Vijay Abraham I <kishon@ti.com>
Date2016-07-21 14:00 +0200
Subject[PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Message-ID<rXkNY-6Xk-25@gated-at.bofh.it>
In reply to#1447814
PCI_DOMAINS is required for DRA7x SoCs since there are 2 PCIe
controllers and without PCI_DOMAINS config, only one PCIe
controller gets registered.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 1a648e9..8e6e2c0 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -86,6 +86,7 @@ config SOC_DRA7XX
 	select OMAP_INTERCONNECT_BARRIER
 	select PM_OPP if PM
 	select ZONE_DMA if ARM_LPAE
+	select PCI_DOMAINS if PCI
 
 config ARCH_OMAP2PLUS
 	bool
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1447817 — Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

FromArnd Bergmann <arnd@arndb.de>
Date2016-07-21 14:10 +0200
SubjectRe: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Message-ID<rXkXD-7fU-13@gated-at.bofh.it>
In reply to#1447815
On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 1a648e9..8e6e2c0 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>         select OMAP_INTERCONNECT_BARRIER
>         select PM_OPP if PM
>         select ZONE_DMA if ARM_LPAE
> +       select PCI_DOMAINS if PCI
>  
>  config ARCH_OMAP2PLUS
>         bool
> 

Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?

	Arnd

[toc] | [prev] | [next] | [standalone]

#1448433 — Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

FromTony Lindgren <tony@atomide.com>
Date2016-07-22 09:20 +0200
SubjectRe: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Message-ID<rXCUy-2Cb-5@gated-at.bofh.it>
In reply to#1447817
* Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
> > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > index 1a648e9..8e6e2c0 100644
> > --- a/arch/arm/mach-omap2/Kconfig
> > +++ b/arch/arm/mach-omap2/Kconfig
> > @@ -86,6 +86,7 @@ config SOC_DRA7XX
> >         select OMAP_INTERCONNECT_BARRIER
> >         select PM_OPP if PM
> >         select ZONE_DMA if ARM_LPAE
> > +       select PCI_DOMAINS if PCI
> >  
> >  config ARCH_OMAP2PLUS
> >         bool
> > 
> 
> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?

Makes sense to me if many SoCs need this.

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1448461 — Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

FromKishon Vijay Abraham I <kishon@ti.com>
Date2016-07-22 10:30 +0200
SubjectRe: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Message-ID<rXE0i-3hR-25@gated-at.bofh.it>
In reply to#1448433
Hi,

On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index 1a648e9..8e6e2c0 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>>>         select OMAP_INTERCONNECT_BARRIER
>>>         select PM_OPP if PM
>>>         select ZONE_DMA if ARM_LPAE
>>> +       select PCI_DOMAINS if PCI
>>>  
>>>  config ARCH_OMAP2PLUS
>>>         bool
>>>
>>
>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
> 
> Makes sense to me if many SoCs need this.

since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
        select MULTI_IRQ_HANDLER
        select SPARSE_IRQ
        select USE_OF
+       select PCI_DOMAINS if PCI

 config ARM_SINGLE_ARMV7M
        bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"

Thanks
Kishon

[toc] | [prev] | [next] | [standalone]

#1448496 — Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

FromSekhar Nori <nsekhar@ti.com>
Date2016-07-22 11:30 +0200
SubjectRe: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Message-ID<rXEWm-3U5-13@gated-at.bofh.it>
In reply to#1448461
On Friday 22 July 2016 01:56 PM, Kishon Vijay Abraham I wrote:

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 90542db..0cccb50 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
>         select MULTI_IRQ_HANDLER
>         select SPARSE_IRQ
>         select USE_OF
> +       select PCI_DOMAINS if PCI

Keep the select list in sorted order.

Regards,
Sekhar

[toc] | [prev] | [next] | [standalone]

#1448597 — Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

FromArnd Bergmann <arnd@arndb.de>
Date2016-07-22 15:40 +0200
SubjectRe: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Message-ID<rXIQi-6tq-39@gated-at.bofh.it>
In reply to#1448461
On Friday, July 22, 2016 1:56:47 PM CEST Kishon Vijay Abraham I wrote:
> 
> since it doesn't harm even if a platform has a single PCIe port, it should be
> okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
> okay.
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 90542db..0cccb50 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
>         select MULTI_IRQ_HANDLER
>         select SPARSE_IRQ
>         select USE_OF
> +       select PCI_DOMAINS if PCI
> 

Sounds good, but please remove all other 'select PCI_DOMAINS if PCI'
statements in arch/arm then in the same patch.

I have checked that all of them are for ARCH_MULTIPLATFORM based machines.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web