Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1441939 > unrolled thread
| Started by | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| First post | 2016-07-13 03:10 +0200 |
| Last post | 2016-07-14 22:20 +0200 |
| Articles | 8 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] rtc: remove intersil isl12057 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-13 03:10 +0200
[PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-13 03:10 +0200
Re: [PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support arno@natisbad.org (Arnaud Ebalard) - 2016-07-14 22:10 +0200
[PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-13 03:10 +0200
Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device arno@natisbad.org (Arnaud Ebalard) - 2016-07-14 22:20 +0200
Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-20 21:40 +0200
Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device Rob Herring <robh+dt@kernel.org> - 2016-07-21 00:50 +0200
Re: [PATCH 0/3] rtc: remove intersil isl12057 arno@natisbad.org (Arnaud Ebalard) - 2016-07-14 22:20 +0200
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-07-13 03:10 +0200 |
| Subject | [PATCH 0/3] rtc: remove intersil isl12057 |
| Message-ID | <rUgQx-4nw-5@gated-at.bofh.it> |
Arnaud, This is the series I intend to apply once you confirm my previous patch is working. Alexandre Belloni (3): Documentation: dt: Intersil isl12057 is not a trivial device rtc: ds1307: add Intersil ISL12057 support rtc: isl12057: remove driver .../devicetree/bindings/i2c/trivial-devices.txt | 1 - drivers/rtc/Kconfig | 18 +- drivers/rtc/Makefile | 1 - drivers/rtc/rtc-ds1307.c | 6 + drivers/rtc/rtc-isl12057.c | 643 --------------------- 5 files changed, 10 insertions(+), 659 deletions(-) delete mode 100644 drivers/rtc/rtc-isl12057.c -- 2.8.1
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-07-13 03:10 +0200 |
| Subject | [PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support |
| Message-ID | <rUgQx-4nw-15@gated-at.bofh.it> |
| In reply to | #1441939 |
Intersil ISL12057 is a drop-in replacement for DS1337. It can be supported
by the ds1307 driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/rtc/Kconfig | 8 ++++----
drivers/rtc/rtc-ds1307.c | 6 ++++++
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index f47c2f5ff70d..ba0b3e7ce4c5 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -198,14 +198,14 @@ config RTC_DRV_AS3722
will be called rtc-as3722.
config RTC_DRV_DS1307
- tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
+ tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, ISL12057"
help
If you say yes here you get support for various compatible RTC
chips (often with battery backup) connected with I2C. This driver
should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00,
- EPSON RX-8025 and probably other chips. In some cases the RTC
- must already have been initialized (by manufacturing or a
- bootloader).
+ EPSON RX-8025, Intersil ISL12057 and probably other chips. In some
+ cases the RTC must already have been initialized (by manufacturing or
+ a bootloader).
The first seven registers on these chips hold an RTC, and other
registers may add features such as NVRAM, a trickle charger for
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 4c5890864d9c..52be48f2e3c0 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -186,6 +186,7 @@ static const struct i2c_device_id ds1307_id[] = {
{ "mcp7941x", mcp794xx },
{ "pt7c4338", ds_1307 },
{ "rx8025", rx_8025 },
+ { "isl1207", ds_1337 },
{ }
};
MODULE_DEVICE_TABLE(i2c, ds1307_id);
@@ -1333,6 +1334,11 @@ static int ds1307_probe(struct i2c_client *client,
if (of_property_read_bool(client->dev.of_node, "wakeup-source")) {
ds1307_can_wakeup_device = true;
}
+ /* Intersil ISL12057 DT backward compatibility */
+ if (of_property_read_bool(client->dev.of_node,
+ "isil,irq2-can-wakeup-machine")) {
+ ds1307_can_wakeup_device = true;
+ }
#endif
switch (ds1307->type) {
--
2.8.1
[toc] | [prev] | [next] | [standalone]
| From | arno@natisbad.org (Arnaud Ebalard) |
|---|---|
| Date | 2016-07-14 22:10 +0200 |
| Subject | Re: [PATCH 2/3] rtc: ds1307: add Intersil ISL12057 support |
| Message-ID | <rUV7k-5LB-15@gated-at.bofh.it> |
| In reply to | #1441941 |
Alexandre Belloni <alexandre.belloni@free-electrons.com> writes:
> Intersil ISL12057 is a drop-in replacement for DS1337. It can be supported
> by the ds1307 driver.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/Kconfig | 8 ++++----
> drivers/rtc/rtc-ds1307.c | 6 ++++++
> 2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index f47c2f5ff70d..ba0b3e7ce4c5 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -198,14 +198,14 @@ config RTC_DRV_AS3722
> will be called rtc-as3722.
>
> config RTC_DRV_DS1307
> - tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
> + tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, ISL12057"
> help
> If you say yes here you get support for various compatible RTC
> chips (often with battery backup) connected with I2C. This driver
> should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00,
> - EPSON RX-8025 and probably other chips. In some cases the RTC
> - must already have been initialized (by manufacturing or a
> - bootloader).
> + EPSON RX-8025, Intersil ISL12057 and probably other chips. In some
> + cases the RTC must already have been initialized (by manufacturing or
> + a bootloader).
>
> The first seven registers on these chips hold an RTC, and other
> registers may add features such as NVRAM, a trickle charger for
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index 4c5890864d9c..52be48f2e3c0 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -186,6 +186,7 @@ static const struct i2c_device_id ds1307_id[] = {
> { "mcp7941x", mcp794xx },
> { "pt7c4338", ds_1307 },
> { "rx8025", rx_8025 },
> + { "isl1207", ds_1337 },
"isl12057"
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-07-13 03:10 +0200 |
| Subject | [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device |
| Message-ID | <rUgQy-4nw-17@gated-at.bofh.it> |
| In reply to | #1441939 |
The ISL12057 has a documentation file, remove it from trivial-devices.txt Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index 539874490492..a397d39ea741 100644 --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt @@ -50,7 +50,6 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) -isil,isl12057 Intersil ISL12057 I2C RTC Chip isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs -- 2.8.1
[toc] | [prev] | [next] | [standalone]
| From | arno@natisbad.org (Arnaud Ebalard) |
|---|---|
| Date | 2016-07-14 22:20 +0200 |
| Subject | Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device |
| Message-ID | <rUVgZ-5P0-11@gated-at.bofh.it> |
| In reply to | #1441942 |
Hello, Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: > The ISL12057 has a documentation file, remove it from trivial-devices.txt > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > index 539874490492..a397d39ea741 100644 > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > @@ -50,7 +50,6 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec > gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface > infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) > -isil,isl12057 Intersil ISL12057 I2C RTC Chip > isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor > maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator > maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs No strong advice on this but I thought it qualified as a trivial device because it did not *need* anything else except a compatible, an address and possibly an interrupt. The additional boolean property documented in Documentation/devicetree/bindings/rtc/isil,isl12057.txt is optional. a+
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-07-20 21:40 +0200 |
| Subject | Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device |
| Message-ID | <rX5vB-5AB-81@gated-at.bofh.it> |
| In reply to | #1443732 |
+robh On 14/07/2016 at 22:10:48 +0200, Arnaud Ebalard wrote : > Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: > > > The ISL12057 has a documentation file, remove it from trivial-devices.txt > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > index 539874490492..a397d39ea741 100644 > > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > @@ -50,7 +50,6 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec > > gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface > > infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > > infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) > > -isil,isl12057 Intersil ISL12057 I2C RTC Chip > > isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor > > maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator > > maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs > > No strong advice on this but I thought it qualified as a trivial device > because it did not *need* anything else except a compatible, an address > and possibly an interrupt. The additional boolean property documented in > Documentation/devicetree/bindings/rtc/isil,isl12057.txt is optional. > Well, my thinking is that trivial devices are in trivial-devices.txt because they are not documented anywhere else. This is mostly the case. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh+dt@kernel.org> |
|---|---|
| Date | 2016-07-21 00:50 +0200 |
| Subject | Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device |
| Message-ID | <rX8ts-7t1-11@gated-at.bofh.it> |
| In reply to | #1447421 |
On Wed, Jul 20, 2016 at 2:32 PM, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > +robh > > On 14/07/2016 at 22:10:48 +0200, Arnaud Ebalard wrote : >> Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: >> >> > The ISL12057 has a documentation file, remove it from trivial-devices.txt >> > >> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> >> > --- >> > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 - >> > 1 file changed, 1 deletion(-) Needs to go to DT list... >> > >> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt >> > index 539874490492..a397d39ea741 100644 >> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt >> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt >> > @@ -50,7 +50,6 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec >> > gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface >> > infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) >> > infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) >> > -isil,isl12057 Intersil ISL12057 I2C RTC Chip >> > isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor >> > maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator >> > maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs >> >> No strong advice on this but I thought it qualified as a trivial device >> because it did not *need* anything else except a compatible, an address >> and possibly an interrupt. The additional boolean property documented in >> Documentation/devicetree/bindings/rtc/isil,isl12057.txt is optional. An optional property, then it is not trivial. > > Well, my thinking is that trivial devices are in trivial-devices.txt > because they are not documented anywhere else. This is mostly the case. Correct. Rob
[toc] | [prev] | [next] | [standalone]
| From | arno@natisbad.org (Arnaud Ebalard) |
|---|---|
| Date | 2016-07-14 22:20 +0200 |
| Message-ID | <rUVgZ-5P0-13@gated-at.bofh.it> |
| In reply to | #1441939 |
Hi Alexandre, Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: > This is the series I intend to apply once you confirm my previous patch > is working. For previous patch and that series, once the typos are fixed: Acked-by: Arnaud Ebalard <arno@natisbad.org> Thanks for spotting the duplication and your work. Cheers, a+ > > Alexandre Belloni (3): > Documentation: dt: Intersil isl12057 is not a trivial device > rtc: ds1307: add Intersil ISL12057 support > rtc: isl12057: remove driver > > .../devicetree/bindings/i2c/trivial-devices.txt | 1 - > drivers/rtc/Kconfig | 18 +- > drivers/rtc/Makefile | 1 - > drivers/rtc/rtc-ds1307.c | 6 + > drivers/rtc/rtc-isl12057.c | 643 --------------------- > 5 files changed, 10 insertions(+), 659 deletions(-) > delete mode 100644 drivers/rtc/rtc-isl12057.c
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web