Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1445973 > unrolled thread

linux-next: build failure after merge of the l2-mtd tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2016-07-19 03:00 +0200
Last post2016-07-19 03:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build failure after merge of the l2-mtd tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-19 03:00 +0200
    Re: linux-next: build failure after merge of the l2-mtd tree Brian Norris <computersforpeace@gmail.com> - 2016-07-19 03:30 +0200
      Re: linux-next: build failure after merge of the l2-mtd tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-19 03:50 +0200

#1445973 — linux-next: build failure after merge of the l2-mtd tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-07-19 03:00 +0200
Subjectlinux-next: build failure after merge of the l2-mtd tree
Message-ID<rWry9-5fC-1@gated-at.bofh.it>
Hi Brian,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_read_execute':
drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration]
    readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
    ^
drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_write_execute':
drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]
   writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
   ^

Caused by commit

  140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")

Missing include of linux/io.h ...

I have used the l2-mtd tree from next-20160718 for today.

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1445981

FromBrian Norris <computersforpeace@gmail.com>
Date2016-07-19 03:30 +0200
Message-ID<rWs1b-5FM-3@gated-at.bofh.it>
In reply to#1445973
On Tue, Jul 19, 2016 at 10:59:30AM +1000, Stephen Rothwell wrote:
> Hi Brian,
> 
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_read_execute':
> drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration]
>     readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
>     ^
> drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_write_execute':
> drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]
>    writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
>    ^
> 
> Caused by commit
> 
>   140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")

Known:

http://lists.infradead.org/pipermail/linux-mtd/2016-July/068569.html

> Missing include of linux/io.h ...

It's not missing linux/io.h; x86 is missing readsl()/writesl(). If x86
folks don't have a solution, then I guess we'll just make this depend on
!X86.

> I have used the l2-mtd tree from next-20160718 for today.

Regards,
Brian

[toc] | [prev] | [next] | [standalone]


#1445983

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-07-19 03:50 +0200
Message-ID<rWsky-5MD-1@gated-at.bofh.it>
In reply to#1445981
Hi Brian,

On Mon, 18 Jul 2016 18:20:39 -0700 Brian Norris <computersforpeace@gmail.com> wrote:
>
> Known:
> 
> http://lists.infradead.org/pipermail/linux-mtd/2016-July/068569.html
> 
> > Missing include of linux/io.h ...  
> 
> It's not missing linux/io.h; x86 is missing readsl()/writesl(). If x86
> folks don't have a solution, then I guess we'll just make this depend on
> !X86.

or remove COMPILE_TEST if it can't compile for everyone ...

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web