Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444789 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-07-16 11:20 +0200 |
| Last post | 2016-07-19 02:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/2] [media] cx25821: Drop Freeing of Workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-16 11:20 +0200
Re: [PATCH 1/2] [media] cx25821: Drop Freeing of Workqueue Tejun Heo <tj@kernel.org> - 2016-07-19 02:00 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-07-16 11:20 +0200 |
| Subject | [PATCH 1/2] [media] cx25821: Drop Freeing of Workqueue |
| Message-ID | <rVtVn-1W3-3@gated-at.bofh.it> |
Workqueues shouldn't be freed. destroy_workqueue should be used instead. destroy_workqueue safely destroys a workqueue and ensures that all pending work items are done before destroying the workqueue. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- drivers/media/pci/cx25821/cx25821-audio-upstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821-audio-upstream.c b/drivers/media/pci/cx25821/cx25821-audio-upstream.c index 68dbc2d..05bd957 100644 --- a/drivers/media/pci/cx25821/cx25821-audio-upstream.c +++ b/drivers/media/pci/cx25821/cx25821-audio-upstream.c @@ -242,7 +242,7 @@ void cx25821_stop_upstream_audio(struct cx25821_dev *dev) dev->_audioframe_count = 0; dev->_audiofile_status = END_OF_FILE; - kfree(dev->_irq_audio_queues); + destroy_workqueue(dev->_irq_audio_queues); dev->_irq_audio_queues = NULL; kfree(dev->_audiofilename); -- 2.1.4
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-07-19 02:00 +0200 |
| Message-ID | <rWqC5-4yl-7@gated-at.bofh.it> |
| In reply to | #1444789 |
On Sat, Jul 16, 2016 at 02:41:49PM +0530, Bhaktipriya Shridhar wrote: > Workqueues shouldn't be freed. destroy_workqueue should be used instead. > destroy_workqueue safely destroys a workqueue and ensures that all pending > work items are done before destroying the workqueue. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> This needs to be marked for stable. Thanks. -- tejun
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web