Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1445672 > unrolled thread
| Started by | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| First post | 2016-07-18 19:50 +0200 |
| Last post | 2016-07-20 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-18 19:50 +0200
Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot Adrian Hunter <adrian.hunter@intel.com> - 2016-07-20 13:10 +0200
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2016-07-18 19:50 +0200 |
| Subject | Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot |
| Message-ID | <rWkQ1-PW-11@gated-at.bofh.it> |
On Fri 24 Jun 09:24 PDT 2016, Georgi Djakov wrote:
> The controller does not clear the "reset bit" when it is reset without
> a card in the slot. Because of this, the following error message is seen
> while booting with no plugged SD card.
>
> mmc1: Reset 0x1 never completed.
>
> Add the SDHCI_QUIRK_NO_CARD_NO_RESET quirk to avoid this.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/mmc/host/sdhci-msm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index ac5700233e12..c613137ae91e 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -477,6 +477,7 @@ static const struct sdhci_ops sdhci_msm_ops = {
>
> static const struct sdhci_pltfm_data sdhci_msm_pdata = {
> .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |
> + SDHCI_QUIRK_NO_CARD_NO_RESET |
> SDHCI_QUIRK_SINGLE_POWER_WRITE,
> .ops = &sdhci_msm_ops,
> };
[toc] | [next] | [standalone]
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2016-07-20 13:10 +0200 |
| Subject | Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot |
| Message-ID | <rWXy1-Dc-15@gated-at.bofh.it> |
| In reply to | #1445672 |
On 18/07/16 20:46, Bjorn Andersson wrote:
> On Fri 24 Jun 09:24 PDT 2016, Georgi Djakov wrote:
>
>> The controller does not clear the "reset bit" when it is reset without
>> a card in the slot. Because of this, the following error message is seen
>> while booting with no plugged SD card.
>>
>> mmc1: Reset 0x1 never completed.
>>
>> Add the SDHCI_QUIRK_NO_CARD_NO_RESET quirk to avoid this.
>>
>> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>
> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Be aware that SDHCI_QUIRK_NO_CARD_NO_RESET is not well implemented. It can
result in ->get_cd() being called under spinlock which could be a problem if
a card detect GPIO is used and might sleep. On the other hand, if you are
not using a card detect GPIO then it shouldn't be a problem.
Otherwise:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Regards,
> Bjorn
>
>> ---
>> drivers/mmc/host/sdhci-msm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
>> index ac5700233e12..c613137ae91e 100644
>> --- a/drivers/mmc/host/sdhci-msm.c
>> +++ b/drivers/mmc/host/sdhci-msm.c
>> @@ -477,6 +477,7 @@ static const struct sdhci_ops sdhci_msm_ops = {
>>
>> static const struct sdhci_pltfm_data sdhci_msm_pdata = {
>> .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |
>> + SDHCI_QUIRK_NO_CARD_NO_RESET |
>> SDHCI_QUIRK_SINGLE_POWER_WRITE,
>> .ops = &sdhci_msm_ops,
>> };
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web