Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1445436 > unrolled thread

drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

Started byDavid Binderman <linuxdev.baldrick@gmail.com>
First post2016-07-18 14:30 +0200
Last post2016-07-18 14:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-07-18 14:30 +0200

#1445436 — drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

FromDavid Binderman <linuxdev.baldrick@gmail.com>
Date2016-07-18 14:30 +0200
Subjectdrivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?
Message-ID<rWfQm-65G-39@gated-at.bofh.it>
Hello there,

drivers/usb/usbip/vudc_rx.c:145:27: warning: result of β€˜11 << 30’
requires 35 bits to represent, but β€˜int’ only has 32 bits
[-Wshift-overflow=]

Source code is

    urb_p->urb->pipe &= ~(11 << 30);

Maybe better code

    urb_p->urb->pipe &= ~(11UL << 30);

Regards

David Binderman

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web