Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444873 > unrolled thread
| Started by | Jiri Olsa <jolsa@kernel.org> |
|---|---|
| First post | 2016-07-16 18:20 +0200 |
| Last post | 2016-07-19 09:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] perf tests: Add is_printable_array test Jiri Olsa <jolsa@kernel.org> - 2016-07-16 18:20 +0200
Re: [PATCH 3/3] perf tests: Add is_printable_array test Jiri Olsa <jolsa@redhat.com> - 2016-07-18 14:20 +0200
Re: [PATCH 3/3] perf tests: Add is_printable_array test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-19 00:50 +0200
[tip:perf/core] perf tests: Add is_printable_array test tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-07-19 09:00 +0200
| From | Jiri Olsa <jolsa@kernel.org> |
|---|---|
| Date | 2016-07-16 18:20 +0200 |
| Subject | [PATCH 3/3] perf tests: Add is_printable_array test |
| Message-ID | <rVAtP-5ZD-9@gated-at.bofh.it> |
Add automated test for is_printable_array function.
Link: http://lkml.kernel.org/n/tip-if70lj3zhdc3csdqm5webjvc@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 ++++
tools/perf/tests/is_printable_array.c | 36 +++++++++++++++++++++++++++++++++++
tools/perf/tests/tests.h | 1 +
4 files changed, 42 insertions(+)
create mode 100644 tools/perf/tests/is_printable_array.c
diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
index 4158422cc2a6..cb20ae1c0d35 100644
--- a/tools/perf/tests/Build
+++ b/tools/perf/tests/Build
@@ -40,6 +40,7 @@ perf-y += event_update.o
perf-y += event-times.o
perf-y += backward-ring-buffer.o
perf-y += sdt.o
+perf-y += is_printable_array.o
$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
$(call rule_mkdir)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 4dd2d050788a..10eb30686c9c 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -222,6 +222,10 @@ static struct test generic_tests[] = {
.func = test__sdt_event,
},
{
+ .desc = "Test is_printable_array function",
+ .func = test__is_printable_array,
+ },
+ {
.func = NULL,
},
};
diff --git a/tools/perf/tests/is_printable_array.c b/tools/perf/tests/is_printable_array.c
new file mode 100644
index 000000000000..42e13393e502
--- /dev/null
+++ b/tools/perf/tests/is_printable_array.c
@@ -0,0 +1,36 @@
+#include <linux/compiler.h>
+#include "tests.h"
+#include "debug.h"
+#include "util.h"
+
+int test__is_printable_array(int subtest __maybe_unused)
+{
+ char buf1[] = { 'k', 'r', 4, 'v', 'a', 0 };
+ char buf2[] = { 'k', 'r', 'a', 'v', 4, 0 };
+ struct {
+ char *buf;
+ unsigned int len;
+ int ret;
+ } t[] = {
+ { (char *) "krava", sizeof("krava"), 1 },
+ { (char *) "krava", sizeof("krava") - 1, 0 },
+ { (char *) "", sizeof(""), 1 },
+ { (char *) "", 0, 0 },
+ { NULL, 0, 0 },
+ { buf1, sizeof(buf1), 0 },
+ { buf2, sizeof(buf2), 0 },
+ };
+ unsigned int i;
+
+ for (i = 0; i < ARRAY_SIZE(t); i++) {
+ int ret;
+
+ ret = is_printable_array((char *) t[i].buf, t[i].len);
+ if (ret != t[i].ret) {
+ pr_err("failed: test %u\n", i);
+ return TEST_FAIL;
+ }
+ }
+
+ return TEST_OK;
+}
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index a0288f8092b2..9bfc0e06c61a 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -89,6 +89,7 @@ int test__event_times(int subtest);
int test__backward_ring_buffer(int subtest);
int test__cpu_map_print(int subtest);
int test__sdt_event(int subtest);
+int test__is_printable_array(int subtest);
#if defined(__arm__) || defined(__aarch64__)
#ifdef HAVE_DWARF_UNWIND_SUPPORT
--
2.4.11
[toc] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2016-07-18 14:20 +0200 |
| Message-ID | <rWfGF-62e-19@gated-at.bofh.it> |
| In reply to | #1444873 |
On Mon, Jul 18, 2016 at 01:46:02PM +0200, Jiri Pirko wrote:
SNIP
> >diff --git a/tools/perf/tests/is_printable_array.c b/tools/perf/tests/is_printable_array.c
> >new file mode 100644
> >index 000000000000..42e13393e502
> >--- /dev/null
> >+++ b/tools/perf/tests/is_printable_array.c
> >@@ -0,0 +1,36 @@
> >+#include <linux/compiler.h>
> >+#include "tests.h"
> >+#include "debug.h"
> >+#include "util.h"
> >+
> >+int test__is_printable_array(int subtest __maybe_unused)
> >+{
> >+ char buf1[] = { 'k', 'r', 4, 'v', 'a', 0 };
> >+ char buf2[] = { 'k', 'r', 'a', 'v', 4, 0 };
> >+ struct {
> >+ char *buf;
> >+ unsigned int len;
> >+ int ret;
> >+ } t[] = {
> >+ { (char *) "krava", sizeof("krava"), 1 },
> >+ { (char *) "krava", sizeof("krava") - 1, 0 },
>
> "a cow" ? Really? :))
yea, trying to force it as 'perf animal' instead of that pony stuff ;-)
http://www.brendangregg.com/blog/2015-07-08/choosing-a-linux-tracer.html
jirka
[toc] | [prev] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2016-07-19 00:50 +0200 |
| Message-ID | <rWpwm-3Um-3@gated-at.bofh.it> |
| In reply to | #1445428 |
Em Mon, Jul 18, 2016 at 02:14:09PM +0200, Jiri Olsa escreveu:
> On Mon, Jul 18, 2016 at 01:46:02PM +0200, Jiri Pirko wrote:
>
> SNIP
>
> > >diff --git a/tools/perf/tests/is_printable_array.c b/tools/perf/tests/is_printable_array.c
> > >new file mode 100644
> > >index 000000000000..42e13393e502
> > >--- /dev/null
> > >+++ b/tools/perf/tests/is_printable_array.c
> > >@@ -0,0 +1,36 @@
> > >+#include <linux/compiler.h>
> > >+#include "tests.h"
> > >+#include "debug.h"
> > >+#include "util.h"
> > >+
> > >+int test__is_printable_array(int subtest __maybe_unused)
> > >+{
> > >+ char buf1[] = { 'k', 'r', 4, 'v', 'a', 0 };
> > >+ char buf2[] = { 'k', 'r', 'a', 'v', 4, 0 };
> > >+ struct {
> > >+ char *buf;
> > >+ unsigned int len;
> > >+ int ret;
> > >+ } t[] = {
> > >+ { (char *) "krava", sizeof("krava"), 1 },
> > >+ { (char *) "krava", sizeof("krava") - 1, 0 },
> >
> > "a cow" ? Really? :))
>
> yea, trying to force it as 'perf animal' instead of that pony stuff ;-)
>
> http://www.brendangregg.com/blog/2015-07-08/choosing-a-linux-tracer.html
Yeah, a vaca! 8-)
- ARnaldo
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Jiri Olsa <tipbot@zytor.com> |
|---|---|
| Date | 2016-07-19 09:00 +0200 |
| Subject | [tip:perf/core] perf tests: Add is_printable_array test |
| Message-ID | <rWxaz-FB-55@gated-at.bofh.it> |
| In reply to | #1444873 |
Commit-ID: 988dd774dcbd9151c2a643fc7284c5c3c4d0adb7
Gitweb: http://git.kernel.org/tip/988dd774dcbd9151c2a643fc7284c5c3c4d0adb7
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Sat, 16 Jul 2016 18:11:20 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 18 Jul 2016 19:50:35 -0300
perf tests: Add is_printable_array test
Add automated test for is_printable_array function.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1468685480-18951-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 ++++
tools/perf/tests/is_printable_array.c | 36 +++++++++++++++++++++++++++++++++++
tools/perf/tests/tests.h | 1 +
4 files changed, 42 insertions(+)
diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
index 4158422..cb20ae1 100644
--- a/tools/perf/tests/Build
+++ b/tools/perf/tests/Build
@@ -40,6 +40,7 @@ perf-y += event_update.o
perf-y += event-times.o
perf-y += backward-ring-buffer.o
perf-y += sdt.o
+perf-y += is_printable_array.o
$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
$(call rule_mkdir)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 4dd2d05..10eb306 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -222,6 +222,10 @@ static struct test generic_tests[] = {
.func = test__sdt_event,
},
{
+ .desc = "Test is_printable_array function",
+ .func = test__is_printable_array,
+ },
+ {
.func = NULL,
},
};
diff --git a/tools/perf/tests/is_printable_array.c b/tools/perf/tests/is_printable_array.c
new file mode 100644
index 0000000..42e1339
--- /dev/null
+++ b/tools/perf/tests/is_printable_array.c
@@ -0,0 +1,36 @@
+#include <linux/compiler.h>
+#include "tests.h"
+#include "debug.h"
+#include "util.h"
+
+int test__is_printable_array(int subtest __maybe_unused)
+{
+ char buf1[] = { 'k', 'r', 4, 'v', 'a', 0 };
+ char buf2[] = { 'k', 'r', 'a', 'v', 4, 0 };
+ struct {
+ char *buf;
+ unsigned int len;
+ int ret;
+ } t[] = {
+ { (char *) "krava", sizeof("krava"), 1 },
+ { (char *) "krava", sizeof("krava") - 1, 0 },
+ { (char *) "", sizeof(""), 1 },
+ { (char *) "", 0, 0 },
+ { NULL, 0, 0 },
+ { buf1, sizeof(buf1), 0 },
+ { buf2, sizeof(buf2), 0 },
+ };
+ unsigned int i;
+
+ for (i = 0; i < ARRAY_SIZE(t); i++) {
+ int ret;
+
+ ret = is_printable_array((char *) t[i].buf, t[i].len);
+ if (ret != t[i].ret) {
+ pr_err("failed: test %u\n", i);
+ return TEST_FAIL;
+ }
+ }
+
+ return TEST_OK;
+}
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index a0288f8..9bfc0e0 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -89,6 +89,7 @@ int test__event_times(int subtest);
int test__backward_ring_buffer(int subtest);
int test__cpu_map_print(int subtest);
int test__sdt_event(int subtest);
+int test__is_printable_array(int subtest);
#if defined(__arm__) || defined(__aarch64__)
#ifdef HAVE_DWARF_UNWIND_SUPPORT
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web