Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445352 > unrolled thread

[PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

Back to article view | Back to linux.kernel

Contents

  [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy <amir.jer.levy@intel.com> - 2016-07-18 12:10 +0200
    [PATCH v4 3/7] thunderbolt: Kconfig for Thunderbolt(TM) networking Amir Levy <amir.jer.levy@intel.com> - 2016-07-18 12:10 +0200
    Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM)  networking Joe Perches <joe@perches.com> - 2016-07-19 19:20 +0200
      RE: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM)  networking "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-20 08:10 +0200
        Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM)  networking Joe Perches <joe@perches.com> - 2016-07-20 08:40 +0200
    Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM)  networking Bjorn Helgaas <helgaas@kernel.org> - 2016-07-20 00:10 +0200
    Re: [PATCH v4 5/7] thunderbolt: Networking state machine Lukas Wunner <lukas@wunner.de> - 2016-07-25 00:40 +0200

#1445352 — [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

This is version 4 of Thunderbolt(TM) driver for non-Apple hardware.

Changes since v3:
 - Moved new Thunderbolt device IDs from pci_ids.h to icm_nhi.h.
 - Cleanup and added some comments in code.

These patches were pushed to GitHub where they can be reviewed more
comfortably with green/red highlighting:
	https://github.com/01org/thunderbolt-software-kernel-tree

Daemon code:
	https://github.com/01org/thunderbolt-software-daemon

For reference, here's a link to version 3:
[v3]:	https://lkml.org/lkml/2016/7/14/311

Amir Levy (7):
  thunderbolt: Macro rename
  thunderbolt: Updating the register definitions
  thunderbolt: Kconfig for Thunderbolt(TM) networking
  thunderbolt: Communication with the ICM (firmware)
  thunderbolt: Networking state machine
  thunderbolt: Networking transmit and receive
  thunderbolt: Networking doc

 Documentation/00-INDEX                   |    2 +
 Documentation/thunderbolt-networking.txt |  135 ++
 drivers/thunderbolt/Kconfig              |   25 +-
 drivers/thunderbolt/Makefile             |    3 +-
 drivers/thunderbolt/icm/Makefile         |   28 +
 drivers/thunderbolt/icm/icm_nhi.c        | 1642 +++++++++++++++++++++
 drivers/thunderbolt/icm/icm_nhi.h        |   93 ++
 drivers/thunderbolt/icm/net.c            | 2276 ++++++++++++++++++++++++++++++
 drivers/thunderbolt/icm/net.h            |  274 ++++
 drivers/thunderbolt/nhi_regs.h           |  115 +-
 10 files changed, 4585 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/thunderbolt-networking.txt
 create mode 100644 drivers/thunderbolt/icm/Makefile
 create mode 100644 drivers/thunderbolt/icm/icm_nhi.c
 create mode 100644 drivers/thunderbolt/icm/icm_nhi.h
 create mode 100644 drivers/thunderbolt/icm/net.c
 create mode 100644 drivers/thunderbolt/icm/net.h

-- 
2.7.4

[toc] | [next] | [standalone]

#1445354 — [PATCH v4 3/7] thunderbolt: Kconfig for Thunderbolt(TM) networking

Updating the Kconfig Thunderbolt(TM) description.

Signed-off-by: Amir Levy <amir.jer.levy@intel.com>
---
 drivers/thunderbolt/Kconfig  | 25 +++++++++++++++++++++----
 drivers/thunderbolt/Makefile |  2 +-
 2 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
index c121acc..d34b0f5 100644
--- a/drivers/thunderbolt/Kconfig
+++ b/drivers/thunderbolt/Kconfig
@@ -1,13 +1,30 @@
-menuconfig THUNDERBOLT
-	tristate "Thunderbolt support for Apple devices"
+config THUNDERBOLT
+	tristate "Thunderbolt(TM) support"
 	depends on PCI
 	select CRC32
 	help
-	  Cactus Ridge Thunderbolt Controller driver
+	  Thunderbolt(TM) Controller driver
+
+if THUNDERBOLT
+
+config THUNDERBOLT_APPLE
+	tristate "Apple hardware support"
+	help
 	  This driver is required if you want to hotplug Thunderbolt devices on
 	  Apple hardware.
 
 	  Device chaining is currently not supported.
 
-	  To compile this driver a module, choose M here. The module will be
+	  To compile this driver as a module, choose M here. The module will be
 	  called thunderbolt.
+
+config THUNDERBOLT_ICM
+	tristate "Thunderbolt(TM) Networking"
+	help
+	  This driver is required if you want Thunderbolt(TM) Networking on
+	  non-Apple hardware.
+
+	  To compile this driver as a module, choose M here. The module will be
+	  called thunderbolt_icm.
+
+endif
diff --git a/drivers/thunderbolt/Makefile b/drivers/thunderbolt/Makefile
index 5d1053c..7a85bd1 100644
--- a/drivers/thunderbolt/Makefile
+++ b/drivers/thunderbolt/Makefile
@@ -1,3 +1,3 @@
-obj-${CONFIG_THUNDERBOLT} := thunderbolt.o
+obj-${CONFIG_THUNDERBOLT_APPLE} := thunderbolt.o
 thunderbolt-objs := nhi.o ctl.o tb.o switch.o cap.o path.o tunnel_pci.o eeprom.o
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1446605 — Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote:
> This is version 4 of Thunderbolt(TM) driver for non-Apple hardware.
[]
>  Documentation/00-INDEX                   |    2 +
>  Documentation/thunderbolt-networking.txt |  135 ++
>  drivers/thunderbolt/Kconfig              |   25 +-
>  drivers/thunderbolt/Makefile             |    3 +-
>  drivers/thunderbolt/icm/Makefile         |   28 +
>  drivers/thunderbolt/icm/icm_nhi.c        | 1642 +++++++++++++++++++++
>  drivers/thunderbolt/icm/icm_nhi.h        |   93 ++
>  drivers/thunderbolt/icm/net.c            | 2276 ++++++++++++++++++++++++++++++
>  drivers/thunderbolt/icm/net.h            |  274 ++++
>  drivers/thunderbolt/nhi_regs.h           |  115 +-
>  10 files changed, 4585 insertions(+), 8 deletions(-)
>  create mode 100644 Documentation/thunderbolt-networking.txt
>  create mode 100644 drivers/thunderbolt/icm/Makefile
>  create mode 100644 drivers/thunderbolt/icm/icm_nhi.c
>  create mode 100644 drivers/thunderbolt/icm/icm_nhi.h
>  create mode 100644 drivers/thunderbolt/icm/net.c
>  create mode 100644 drivers/thunderbolt/icm/net.h

Is a MAINTAINERS update necessary or is Andreas going to
be the maintainer?

[toc] | [prev] | [next] | [standalone]

#1446992 — RE: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Tue, Jul 19 2016, 08:14 PM, Joe Perches wrote:
> On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote:
> > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware.
> []
> >  Documentation/00-INDEX                   |    2 +
> >  Documentation/thunderbolt-networking.txt |  135 ++
> >  drivers/thunderbolt/Kconfig              |   25 +-
> >  drivers/thunderbolt/Makefile             |    3 +-
> >  drivers/thunderbolt/icm/Makefile         |   28 +
> >  drivers/thunderbolt/icm/icm_nhi.c        | 1642 +++++++++++++++++++++
> >  drivers/thunderbolt/icm/icm_nhi.h        |   93 ++
> >  drivers/thunderbolt/icm/net.c            | 2276
> > ++++++++++++++++++++++++++++++
> >  drivers/thunderbolt/icm/net.h            |  274 ++++
> >  drivers/thunderbolt/nhi_regs.h           |  115 +-
> >  10 files changed, 4585 insertions(+), 8 deletions(-)
> >  create mode 100644 Documentation/thunderbolt-networking.txt
> >  create mode 100644 drivers/thunderbolt/icm/Makefile
> >  create mode 100644 drivers/thunderbolt/icm/icm_nhi.c
> >  create mode 100644 drivers/thunderbolt/icm/icm_nhi.h
> >  create mode 100644 drivers/thunderbolt/icm/net.c
> >  create mode 100644 drivers/thunderbolt/icm/net.h
> 
> Is a MAINTAINERS update necessary or is Andreas going to be the
> maintainer?

Now that the drivers are completely separated it make sense that 
I'll maintain the thunderbolt/icm driver,  if there are no objections.

[toc] | [prev] | [next] | [standalone]

#1447014 — Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Wed, 2016-07-20 at 06:02 +0000, Levy, Amir (Jer) wrote:
> On Tue, Jul 19 2016, 08:14 PM, Joe Perches wrote:
> > On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote:
> > > 
> > > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware.
> > []
> > >  Documentation/00-INDEX                   |    2 +
> > >  Documentation/thunderbolt-networking.txt |  135 ++
> > >  drivers/thunderbolt/Kconfig              |   25 +-
> > >  drivers/thunderbolt/Makefile             |    3 +-
> > >  drivers/thunderbolt/icm/Makefile         |   28 +
> > >  drivers/thunderbolt/icm/icm_nhi.c        | 1642 +++++++++++++++++++++
> > >  drivers/thunderbolt/icm/icm_nhi.h        |   93 ++
> > >  drivers/thunderbolt/icm/net.c            | 2276 ++++++++++++++++++++++++++++++
> > >  drivers/thunderbolt/icm/net.h            |  274 ++++
> > >  drivers/thunderbolt/nhi_regs.h           |  115 +-
> > >  10 files changed, 4585 insertions(+), 8 deletions(-)
> > >  create mode 100644 Documentation/thunderbolt-networking.txt
> > >  create mode 100644 drivers/thunderbolt/icm/Makefile
> > >  create mode 100644 drivers/thunderbolt/icm/icm_nhi.c
> > >  create mode 100644 drivers/thunderbolt/icm/icm_nhi.h
> > >  create mode 100644 drivers/thunderbolt/icm/net.c
> > >  create mode 100644 drivers/thunderbolt/icm/net.h
> > Is a MAINTAINERS update necessary or is Andreas going to be the
> > maintainer?
> Now that the drivers are completely separated it make sense that 
> I'll maintain the thunderbolt/icm driver,  if there are no objections.

I think that's fine and the MAINTAINERS file should have
a new section entry for this driver with your name too.

[toc] | [prev] | [next] | [standalone]

#1446747 — Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Mon, Jul 18, 2016 at 01:00:33PM +0300, Amir Levy wrote:
> This is version 4 of Thunderbolt(TM) driver for non-Apple hardware.
> 
> Changes since v3:
>  - Moved new Thunderbolt device IDs from pci_ids.h to icm_nhi.h.
>  - Cleanup and added some comments in code.
> 
> These patches were pushed to GitHub where they can be reviewed more
> comfortably with green/red highlighting:
> 	https://github.com/01org/thunderbolt-software-kernel-tree
> 
> Daemon code:
> 	https://github.com/01org/thunderbolt-software-daemon
> 
> For reference, here's a link to version 3:
> [v3]:	https://lkml.org/lkml/2016/7/14/311
> 
> Amir Levy (7):
>   thunderbolt: Macro rename
>   thunderbolt: Updating the register definitions
>   thunderbolt: Kconfig for Thunderbolt(TM) networking
>   thunderbolt: Communication with the ICM (firmware)
>   thunderbolt: Networking state machine
>   thunderbolt: Networking transmit and receive
>   thunderbolt: Networking doc
> 
>  Documentation/00-INDEX                   |    2 +
>  Documentation/thunderbolt-networking.txt |  135 ++
>  drivers/thunderbolt/Kconfig              |   25 +-
>  drivers/thunderbolt/Makefile             |    3 +-
>  drivers/thunderbolt/icm/Makefile         |   28 +
>  drivers/thunderbolt/icm/icm_nhi.c        | 1642 +++++++++++++++++++++
>  drivers/thunderbolt/icm/icm_nhi.h        |   93 ++
>  drivers/thunderbolt/icm/net.c            | 2276 ++++++++++++++++++++++++++++++
>  drivers/thunderbolt/icm/net.h            |  274 ++++
>  drivers/thunderbolt/nhi_regs.h           |  115 +-
>  10 files changed, 4585 insertions(+), 8 deletions(-)
>  create mode 100644 Documentation/thunderbolt-networking.txt
>  create mode 100644 drivers/thunderbolt/icm/Makefile
>  create mode 100644 drivers/thunderbolt/icm/icm_nhi.c
>  create mode 100644 drivers/thunderbolt/icm/icm_nhi.h
>  create mode 100644 drivers/thunderbolt/icm/net.c
>  create mode 100644 drivers/thunderbolt/icm/net.h

Andreas, I assume you'll handle this.

[toc] | [prev] | [next] | [standalone]

#1449218 — Re: [PATCH v4 5/7] thunderbolt: Networking state machine

On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote:
> +	const unique_id_be proto_uuid = APPLE_THUNDERBOLT_IP_PROTOCOL_UUID;
> +
> +	if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid,
> +		   sizeof(proto_uuid)) != 0) {

You may want to use the uuid_be data type provided by <linux/uuid.h>
instead of rolling your own, as well as the helper uuid_be_cmp()
defined ibidem.

Thanks,

Lukas

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web