Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446996 > unrolled thread

[PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units Andrew Jeffery <andrew@aj.id.au> - 2016-07-20 08:10 +0200
    Re: [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed  system control units Rob Herring <robh@kernel.org> - 2016-07-20 21:10 +0200
      Re: [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed  system control units Andrew Jeffery <andrew@aj.id.au> - 2016-07-21 03:20 +0200

#1446996 — [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt

diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
new file mode 100644
index 000000000000..4df798799101
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
@@ -0,0 +1,16 @@
+The Aspeed System Control Unit manages the global behaviour of the SoC,
+configuring elements such as clocks, pinmux, and reset.
+
+Required properties:
+- compatible:	One of:
+		"aspeed,g4-scu", "syscon", "simple-mfd"
+		"aspeed,g5-scu", "syscon", "simple-mfd"
+
+- reg:		contains the offset and length of the SCU memory region
+
+Example:
+
+syscon: syscon@1e6e2000 {
+	compatible = "aspeed,g4-scu", "syscon", "simple-mfd";
+	reg = <0x1e6e2000 0x1a8>;
+};
-- 
2.7.4

[toc] | [next] | [standalone]

#1447405 — Re: [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units

On Wed, Jul 20, 2016 at 03:28:28PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>  Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> new file mode 100644
> index 000000000000..4df798799101
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> @@ -0,0 +1,16 @@
> +The Aspeed System Control Unit manages the global behaviour of the SoC,
> +configuring elements such as clocks, pinmux, and reset.
> +
> +Required properties:
> +- compatible:	One of:
> +		"aspeed,g4-scu", "syscon", "simple-mfd"
> +		"aspeed,g5-scu", "syscon", "simple-mfd"

These (and the pinctrl probably) really need SoC specific compatible 
strings. You can keep these as fallbacks though. These are the parts of 
SoCs that really vary chip to chip.

Rob

[toc] | [prev] | [next] | [standalone]

#1447571 — Re: [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units

[Multipart message — attachments visible in raw view] — view raw

On Wed, 2016-07-20 at 14:09 -0500, Rob Herring wrote:
> On Wed, Jul 20, 2016 at 03:28:28PM +0930, Andrew Jeffery wrote:
> > 
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> >  Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > new file mode 100644
> > index 000000000000..4df798799101
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > @@ -0,0 +1,16 @@
> > +The Aspeed System Control Unit manages the global behaviour of the SoC,
> > +configuring elements such as clocks, pinmux, and reset.
> > +
> > +Required properties:
> > +- compatible:	One of:
> > +		"aspeed,g4-scu", "syscon", "simple-mfd"
> > +		"aspeed,g5-scu", "syscon", "simple-mfd"
> These (and the pinctrl probably) really need SoC specific compatible 
> strings. You can keep these as fallbacks though. These are the parts of 
> SoCs that really vary chip to chip.

I'll add the SoC-specific compatible strings.

Cheers,

Andrew

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web