Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1446892 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2016-07-20 04:30 +0200 |
| Last post | 2016-07-20 20:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: build warning after merge of the wireless-drivers-next tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-20 04:30 +0200
RE: linux-next: build warning after merge of the wireless-drivers-next tree "Reizer, Eyal" <eyalr@ti.com> - 2016-07-20 08:20 +0200
Re: linux-next: build warning after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-07-20 20:50 +0200
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2016-07-20 04:30 +0200 |
| Subject | linux-next: build warning after merge of the wireless-drivers-next tree |
| Message-ID | <rWPqN-3P2-1@gated-at.bofh.it> |
Hi all,
After merging the wireless-drivers-next tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:
drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of':
drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^
Introduced by commit
01efe65aba65 ("wlcore: spi: add wl18xx support")
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | "Reizer, Eyal" <eyalr@ti.com> |
|---|---|
| Date | 2016-07-20 08:20 +0200 |
| Subject | RE: linux-next: build warning after merge of the wireless-drivers-next tree |
| Message-ID | <rWT1n-6cr-3@gated-at.bofh.it> |
| In reply to | #1446892 |
Hi Stephen,
>
> After merging the wireless-drivers-next tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of':
> drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [-
> Wunused-variable]
> int ret;
> ^
>
> Introduced by commit
>
> 01efe65aba65 ("wlcore: spi: add wl18xx support")
>
Of course you are right. It is indeed redundant now.
Don't know how I have missed it. Don't remember seeing a warning from the tool chain I have used.
Anyway ,will submit an amended patch soon.
Best Regards,
Eyal
[toc] | [prev] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2016-07-20 20:50 +0200 |
| Subject | Re: linux-next: build warning after merge of the wireless-drivers-next tree |
| Message-ID | <rX4Jc-52e-13@gated-at.bofh.it> |
| In reply to | #1447001 |
"Reizer, Eyal" <eyalr@ti.com> writes:
>> After merging the wireless-drivers-next tree, today's linux-next build
>> (x86_64 allmodconfig) produced this warning:
>>
>> drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of':
>> drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [-
>> Wunused-variable]
>> int ret;
>> ^
>>
>> Introduced by commit
>>
>> 01efe65aba65 ("wlcore: spi: add wl18xx support")
>
> Of course you are right. It is indeed redundant now. Don't know how I
>have missed it. Don't remember seeing a warning from the tool chain I
>have used. Anyway ,will submit an amended patch soon.
I didn't notice it either as I didn't have CONFIG_WLCORE_SPI enabled.
But what's odd is that kbuild didn't report anything, it's usually quite
good to catch warnings like this.
Anyway, I have pushed the fix to wireless-drivers-next:
cb6a11518850 wlcore: spi: fix build warning caused by redundant variable
--
Kalle Valo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web